From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 916DD3858C30 for ; Wed, 8 Mar 2023 07:33:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 916DD3858C30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x534.google.com with SMTP id y19so9092253pgk.5 for ; Tue, 07 Mar 2023 23:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678260786; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IB/1gJA1NFYtrg1/634lzuEeWx0760kYRyf6SLEwss0=; b=GgG4xy9V9MK26oonnhiFm/zhgMRYOiskLB7j8tp1LI58TwCrWEou69YeM0bxf+4YLY NjTpbq9s/ikMa4Jn8v8Qa0T129VFpTSpeFrbQKRnfi9csKze9swRFG9mY3gxNqkNPkdv HAomxg913WO0BX5e405CKA0ptilBsock9zCWbp/hzmygfX4dwZCSpLlKoDxeci+ihQgV tcUrOnQG/lKVTEm6iGig6age61Izl/P4yrotaz4kYZlW2y3nKdn8TC2r5W/J3yDshfiD ubTtzM+LRtC41BXe+/5SPt1x/KpMovHDyWsK+cML8GZYH1/OCHQQWyZgslI2239URVPH T40A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678260786; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IB/1gJA1NFYtrg1/634lzuEeWx0760kYRyf6SLEwss0=; b=quUINgIx2poY/Gr8FTIgsLhAj1+DjArz4uqc2u5zXdyRNLq01rFFJnroKqg7y2yOwz K7Gl037A9x377p4d7hIBI0AQrAgD1KCtfHSOoOAlI0ZLTqS8f0la0oNO2Z54dpjtA6ne brIXP8nhxRoC7eN0qitGafQcb/iOCmhsO4YQdklel50jW8mv8ETVhrzGf0V5s5LEnjPS 5mhdJONZzsmSVlHjzV4+tiAji5grjkMl3SYi5ZOwGBIAZgRNZ2Wb6nJCwFELSc6dQo89 VVZzAzmMeuAV+6y3j9+/6MiD0JDxdqKpZq1kJ5DgNlM//PWopR0zxC7E/ydzaf2jKmGF /LRQ== X-Gm-Message-State: AO0yUKXjxaxR+/GGjqTdrFEpqZC4jPf3DUteK8c5TkxUGVWZSLLkPUUc wqTwUh3zdrVweuiBLPU0bsyW1kFq3MRJW3U6Y50= X-Google-Smtp-Source: AK7set8JYdmZ5QYrDzsI1e/NmXcakAdppJShfEFNI+dkAaucJzFxoYrCZH5oOAhrjW3uv2e27Z7uHWk7TpPumXFeHAU= X-Received: by 2002:a62:cdc9:0:b0:5d9:27a5:6311 with SMTP id o192-20020a62cdc9000000b005d927a56311mr5670837pfg.6.1678260786523; Tue, 07 Mar 2023 23:33:06 -0800 (PST) MIME-Version: 1.0 References: <582085ac-0d07-a516-732d-e82e0a4e01c9@netcologne.de> In-Reply-To: <582085ac-0d07-a516-732d-e82e0a4e01c9@netcologne.de> From: Paul Richard Thomas Date: Wed, 8 Mar 2023 07:32:55 +0000 Message-ID: Subject: Re: [Patch, fortran] PR37336 finalization To: Thomas Koenig , Steve Kargl Cc: "fortran@gcc.gnu.org" Content-Type: multipart/alternative; boundary="00000000000005720205f65e8a14" X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,KAM_BADIPHTTP,KAM_SHORT,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000005720205f65e8a14 Content-Type: text/plain; charset="UTF-8" Hi Thomas and Steve, Last night, I scoped out the work required to get the patch ready to commit. Sorting out the testcases will be the main load since they have grown "organically". I propose to change over to one test for each paragraph of F2018 7.5.6.2/7.5.6.3 and to verify them against the other brands. I suspect that this will allow a weeding out of the existing tests. It will take me a couple of weeks. Could you please review the patch on that self same time scale? I would be happy to have feedback one file at a time. Salvatore alerted me to an ICE on valid, which occurs with -fcheck=all. Eliminating the assert at trans.cc:1101 fixes it. I am not convinced that the line does anything useful now and so consider it to be erased. I suspect that future bugs will result from components that are finalizable and allocatable and so I will be paying close attention to it. In the course of the last few months, I have found that the associate construct causes a lot of niggles. Looking at pr87477, I see that I fixed a number of the dependencies a while since, on a branch other than the development branch of the time. As a result, the fixes got lost. I will turn to pr87477 just as soon as pr37336 is done and dusted. Cheers Paul On Tue, 7 Mar 2023 at 14:58, Thomas Koenig wrote: > Paul, > > first of all, thank you very much indeed for the hard work you put into > this! This is a great step for gfortran. > > > I can hurry this along to get the patch > > into 13-branch or I can wait until 14-branch opens. > > Personally, I think that this fixes so many bugs, and makes > the compiler so much better, that I would prefer having it > in gcc-13. Finalization was only of very limited use before, > and the risk of meaningful regressions (short of a build > failure) is therefore very low. > > Again, thanks a lot! > > Best regards > > Thomas > > > > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein --00000000000005720205f65e8a14--