From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id A1A793858D32; Mon, 23 Jan 2023 07:31:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1A793858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x430.google.com with SMTP id c26so8094283pfp.10; Sun, 22 Jan 2023 23:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=iclLNhB68SaBHfpXJMk/kHBV8wklgIY2if4qwCGA4Ko=; b=Or92Jk7QL5E2XeXMYSpdOjPaIlrDDK9DeaHNEP8s+WlenNXlpDU/uajlqr5CSCsm3l Hp2GQD7vsdwjSbySO++ISOko2voS/7VZYx+4hc6B3xCZ/fAE5DUTht7hYL2cY2gXEWXE 9SS9Choel5GDajT6MizTMHtW63igJBYUZ/SqV8uyw2BikZLWauJx98uQvHf1dDCoCyRw ownXc5kwRKBaeN1oKScHgiYI6ycRge6hQ0laGWVtDYlqYY716jZD4jjYnNxjHaVpeRyy rdsBAUld/99UgZsWAwO8fGVLgTLHYIII8PS8SW43j6FUzIxEbU73ZJ7BTNFzxEfTMMVA PEGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iclLNhB68SaBHfpXJMk/kHBV8wklgIY2if4qwCGA4Ko=; b=jys60r8Jrjqu2VabIIcQ01oLM5lEbn/CiahTX4X6i7PV2w7yLW7n6QHz8h7tMakfMC ym1YAvlVXAtqwl3OHUN+1or6uZ76cFwwD8GnsDOm7QQOBoQmadfO8eGn/CR1Z2RJtbyI EUZOu9xu/hs8g5gQua/6RTvwOWur1V66KdT1lGHf6a7WzQEkj8IaAmknb4O547r9Iywr Z6ok5Er6FsyX3dWVCDKw5Sdn9w4VvSzBTguvribXsQsfyp5mwg8o/oTyKBb19Ey7/Bgx iQ1PWEgqICLiFzYHiSi1yGXSjZk4+06jRMpgiYUSXiErlymYtwlZkCr4YzvLeCW/Abdh gE6Q== X-Gm-Message-State: AFqh2krGCo5gLAVCOGCpSxDMS4GU0C6xHqOgVA9iKGGSg3u5DxX+IuRQ wqxlChGfAnubseznh+ETGT3w4eDFq9yQZAsExTo= X-Google-Smtp-Source: AMrXdXse47xfcK2bZnVEicO16reSSw+lK3/L7hm9LAUpErC3sU/R9tVNVCYr1MvOBsYlr4K8KL6v33lrhOmN4sg3r5s= X-Received: by 2002:a63:5d1c:0:b0:4c6:5d84:977d with SMTP id r28-20020a635d1c000000b004c65d84977dmr257041pgb.5.1674459058673; Sun, 22 Jan 2023 23:30:58 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Mon, 23 Jan 2023 07:30:47 +0000 Message-ID: Subject: Re: [PATCH] Fortran: fix ICE in check_charlen_present [PR108420] To: Harald Anlauf Cc: fortran , gcc-patches Content-Type: multipart/alternative; boundary="000000000000621f1f05f2e96149" X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000621f1f05f2e96149 Content-Type: text/plain; charset="UTF-8" Hi Harald, This is fine for mainline and for backporting if you feel so inclined. Thanks for the patch. Paul On Mon, 16 Jan 2023 at 21:12, Harald Anlauf via Fortran wrote: > Dear all, > > it appears that the fix for pr107874 uncovered a latent bug > for the case of arrays of type character and size zero when > passed to the intrinsics MERGE and SPREAD as SOURCE. In that > case, there is no constructor from which we could obtain > another character length. A reasonable solution seems to > retain the array's character length. > > Since I could not find a simple case where this fails, I've > added an assertion that we actually have a meaningful length. > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > Thanks, > Harald > > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein --000000000000621f1f05f2e96149--