From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53247 invoked by alias); 8 Oct 2017 12:40:00 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 53237 invoked by uid 89); 8 Oct 2017 12:39:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=U*jvdelisle, D*charter.net, jvdelisle@charter.net, jvdelislecharternet X-HELO: mail-qt0-f177.google.com Received: from mail-qt0-f177.google.com (HELO mail-qt0-f177.google.com) (209.85.216.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Oct 2017 12:39:58 +0000 Received: by mail-qt0-f177.google.com with SMTP id f15so38778068qtf.7 for ; Sun, 08 Oct 2017 05:39:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CA1avfczFjx9k/AB4TEc8Xgmq83FHLyfCbzgbj+MIpU=; b=ms4nKKhu4u76qqAGBsTLG7+SLdnRxJnY8xApkuozQqsetVVGsg5rxevSS/OL50g7j0 Dam1HWj5GPFdJaky5kSpp0VbVUUGG/c2IRqc3aGErdm8eCVt6oaeGnABH0llNPtEmKSH 2D94MqwwiNYTFAen5vJiW4cPrfNOWAayAQO4i4E8arJofFrmr27GkXsGbTKXLHGVUge+ ITgJhozKzWSZ7r4ocDE1cC15JLmQUgc2+c5qe6KFJv++hLjMPo90hp5MjTOBDHDsgU/u xhHEJEdUP9i1aesjA65ON7bLg3k6SJGIr/0AurZ/SFt0vMILtiTHx7nktc5IszR5GW6r e1kA== X-Gm-Message-State: AMCzsaXdK/E666ZI7vMoYUBYElCy5ivNJ6FJFy90MrCx7BR5pmoizVZL 8p/TqzNECnvUVH5A9Ff0uPceuNfZgEB2cOkSepY= X-Google-Smtp-Source: AOwi7QAVl2fdHjStu25wwmX6CPWyaC1Rwbpuode16YZD+MFZ9M6R63EEWH85KQ5/Oqfh0jUb1cwmuoPeIoapHCnYt6k= X-Received: by 10.129.181.71 with SMTP id c7mr1735982ywk.435.1507466396615; Sun, 08 Oct 2017 05:39:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.129.2.7 with HTTP; Sun, 8 Oct 2017 05:39:56 -0700 (PDT) In-Reply-To: References: <63e37bf3-95d2-67d7-9a8d-aabe970094ae@charter.net> From: Paul Richard Thomas Date: Sun, 08 Oct 2017 12:40:00 -0000 Message-ID: Subject: Re: Draft patch: Fortran 2015 teams support and extension To: Damian Rouson Cc: Jerry DeLisle , Soren Rasmussen , gfortran , "Filippone, Salvatore" , Alessandro Fanfarillo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00042.txt.bz2 Hi Jerry, The reason that I asked if the testcase was sufficient is that it didn't seem to do anything other than to check the parsing. Shouldn't it do something to establish that the teams actually work, well... , as teams? Cheers Paul On 8 October 2017 at 01:07, Damian Rouson wr= ote: > > Hi Jerry, > > I=E2=80=99ll be glad to run the regression tests if you can provide instr= uctions on > how to do so. On a related note, upon completion of the work on integrat= ing > MPICH and OpenCoarrays into the GCC build scripts, it would be a good idea > to add the OpenCoarrays unit tests to the GCC test suite. > > > On October 6, 2017 at 10:15:03 PM, Jerry DeLisle (jvdelisle@charter.net) > wrote: > > On 09/28/2017 06:32 AM, Paul Richard Thomas wrote: >> Hi Damian and Sandro, >> >> I have taken a look at the patch. Please remove the commented out >> sections, eg. in gfc_match_change_team. Apart from that, the patch is >> ready for submission. >> >> Is that testcase sufficient? I am asking because I don't know. >> >> Cheers >> >> Paul >> > > I assume this has all been regression tested with our current testsuite. = Are > all > features tested in test cases? > > Jerry --=20 "If you can't explain it simply, you don't understand it well enough" - Albert Einstein