From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id DC16A3858CDB; Tue, 22 Aug 2023 06:32:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC16A3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-564b6276941so2669348a12.3; Mon, 21 Aug 2023 23:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692685974; x=1693290774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=US+8pSTsc+B5DyMeg7RjZFJUM4Ga9hJRM3ReoMRzql0=; b=aRa7N33q0VS2z2vO0WrMMIupfZgQMpXVemOL54sae5hj+zstYfWkUdB6u6UfbrBnFv BTwPUGcbiiS6x96nhMAAEc77OB4M4gbW9I0wjXgIMigcoV+fH+e+pqv/WrXALGKyyLNF /lzvh0ZXstanEqEFdD5ZhR3WFtmPwa5CQ3EGIpKd1SyrmM/vWIiztzwONF6U4aA9AptS w4kBf9e2yUQ5ubXhU1eBuexfVQSo6fyTt8MFLMpAKjhzCQwmbpL7D9cwYjEpwwdWuXMQ Hu4wLhRoxfqxLEGCwTiy5nC2YeAYPHS1qaQJXVsIDwiQ7ipJjGGMTIsuW8pPXDrlG84L rIGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692685974; x=1693290774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=US+8pSTsc+B5DyMeg7RjZFJUM4Ga9hJRM3ReoMRzql0=; b=HoVB7dcYeZhcocALMPag/cye9735pPtAH19ydKutkhLARQYOuALE+rWgfFuYEFmjML IFBHzrxWQmC53m3Yzz7HPA4DObrBU85qNoEfAYuMjFLsMnBQW8/D2fQfrWYj5FgkV5vd f+IG6zi3+Ztzv9bU5ANSJtCE0lkdIi8yMqpCDdJz4ELrwDyYwL+nTP4WLt4vYQeesz3r rvb6BRL05MRjy713OPTKwpLnsBxsC6AYktNRRaoa/3k2XtxwOk3BFza7FwBpbL0TNah0 sDrNd6W/OOMICwgR/6xYwjXyF1xU94x30EmWfMOFyCH9BRstxNMRbAKVv0FQ+QEUTRJI NbCA== X-Gm-Message-State: AOJu0Yzc8VV4DMh+uUMI7ZXzPgZC4DyQBJI1qC+qvCenY+k/n9ifXQBD ta0NEY70IjIy2++burG+f5Bu7CuMp0FQOmUQbVE= X-Google-Smtp-Source: AGHT+IFg6uNXFJzEtwYGUCl5XDnUQlYlVMQHPA9RADXYa1leLfr8AvhjPDQSH1g/Q5mOylR2Y7qhWdY/3k++cd+K5fM= X-Received: by 2002:a17:90a:420d:b0:268:1d1e:baaf with SMTP id o13-20020a17090a420d00b002681d1ebaafmr8019283pjg.17.1692685973600; Mon, 21 Aug 2023 23:32:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Tue, 22 Aug 2023 07:32:42 +0100 Message-ID: Subject: Re: [PATCH] Fortran: implement vector sections in DATA statements [PR49588] To: Harald Anlauf Cc: fortran , gcc-patches Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Harald, It all looks good to me and does indeed make the code clearer. OK for trunk. Thanks for the patch. I was shocked to find that there are 217 older bugs than 49588. Does anybody test older bugs to check if any of them have been fixed? Paul On Mon, 21 Aug 2023 at 20:48, Harald Anlauf via Fortran wrote: > > Dear all, > > the attached patch implements vector sections in DATA statements. > > The implementation is simpler than the size of the patch suggests, > as part of changes try to clean up the existing code to make it > easier to understand, as ordinary sections (start:end:stride) > and vector sections may actually share some common code. > > The basisc idea of the implementation is that one needs a > temporary vector that keeps track of the offsets into the > array constructors for the indices in the array reference > that are vectors. > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > Thanks, > Harald >