From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id 0C63338E9577; Sun, 10 Apr 2022 07:46:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0C63338E9577 Received: by mail-qt1-x82a.google.com with SMTP id r25so746732qtp.8; Sun, 10 Apr 2022 00:46:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ip/bMBbd11RnME4AF/ALIHMLEBr98ldj13+vEyCGAe8=; b=UD9olGavTARWKwmu+NdTeRC7w1sfs3w7xvMINCOfhgKkH6oqKWi8RkC3UreXqjkNmw iA56MfvaBJgKnZxAQ2+YG+2hHC3AoAEJ0xtNrZSxfZJlL6Py033LNpsq2ZnbKn7KxdMh Wk2fchsOtHm3sfELW3R5rUPGfogPPcFgh7gHxk8abtZCCLPLXtzq/Wx/G+ML9GoLAl0F IF2uFdfYYno8UVR6a357XLKf2PVuecd2gpwJEpJDb1nZ7PXxlXE+hPfjlheVymULW735 Ih9z6ru770czDh0jZz7pFOJk1AGWwI4AAt2eJ8vSEfbXRBW3ysTKQXChUHi74iHB8wxK 9dyg== X-Gm-Message-State: AOAM530yZi5jUcKEkRq8uG0gCvBxuFS6/qEPWEog7BHBOpg7JBR542la Bp+fwayrr0no3ul8xT+xPCJCgLmwZxaEs1pojD8= X-Google-Smtp-Source: ABdhPJyWeLLuKP0EuvTF4o0aWCbTa3+khlrQAfOl5HXbfJ9+rd/aQ3acjFRg3C8+FpRKLOLAeZfv5axQwh/N+4jYE+k= X-Received: by 2002:a05:622a:10:b0:2e1:c3b3:4317 with SMTP id x16-20020a05622a001000b002e1c3b34317mr21765868qtw.39.1649576765368; Sun, 10 Apr 2022 00:46:05 -0700 (PDT) MIME-Version: 1.0 References: <00368e5d-a283-0069-fa5e-1f0401516ddf@gmx.de> In-Reply-To: <00368e5d-a283-0069-fa5e-1f0401516ddf@gmx.de> From: Paul Richard Thomas Date: Sun, 10 Apr 2022 08:45:54 +0100 Message-ID: Subject: Re: [PATCH, v2] PR fortran/105184 - ICE in gfc_array_init_size, at fortran/trans-array.cc:5841 To: Harald Anlauf Cc: fortran , gcc-patches X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Apr 2022 07:46:10 -0000 Hi Harald, It looks good to me - OK for mainline. Thanks Paul On Fri, 8 Apr 2022 at 21:45, Harald Anlauf via Fortran wrote: > Dear all, > > Am 06.04.22 um 22:30 schrieb Harald Anlauf via Fortran: > > Dear all, > > > > the logic for checking the allocate-coshape-spec in an ALLOCATE > > statement was sort of sideways, and allowed to pass invalid > > specifications to the code generation. > > > > The fix seems obvious (to me). > > after submitting the previous patch, I found another invalid case with > a missing lower bound which was still silently accepted. The attached > revised patch adds this check, improves the original error message to > actually point to the coarray specification, and renames the testcase > to align better with existing coarray testcases. > > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > (12 or wait for 13?). > > Regtested again with no new failures. OK for mainline? > > Thanks, > Harald > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein