From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id CDE683896832; Sat, 13 Mar 2021 08:59:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CDE683896832 Received: by mail-lf1-x12a.google.com with SMTP id k9so49142102lfo.12; Sat, 13 Mar 2021 00:59:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BRUVFXVM2yPgboVDkwxsLEE/VhjT/Ky20NjEeWsvtiE=; b=nZnWb1JwLtlAaLptEmfBK/8vjRFqNsb9cKtUdAYcAdouccbQN1QXVD3TMb95rCmuL6 RDq3SqyaB6Ldwy8RHDThzI1MR9zueCYlzBE7GMSh24j9Emmfwc5kKZ5HFMCiPxDVJhH9 OOWJpjkJQPFVocD2q+Qk22r47t59vkVFrm95gdBkp4d4fvBaIeMycdGbq5JKEHoOccb1 77L1knfjPXYQ7qINm4dfetHphjH1m+zLkQKvQZHhLN0bjRM60fT1s+Oz6gBnV1BReEKs 3ZmGVTg7kMLFr4EJWFhciSiboxAUP0SevYhwwFakvy8kSFaIloXkiSAYiQ0gIa1bVXu1 uoKQ== X-Gm-Message-State: AOAM530Xt9BDBySo86NE0Em2T12yBPiTgKzlbDB0RosJq3SdUJBoMuf8 9PkxpRaBfiwNdysfFPbn1Lwof9wXVykG9Ce8OvI= X-Google-Smtp-Source: ABdhPJxYAPQb1Jhdgu5sD0/UThuHwO0eYFGBhg7fcXmlbC06kLG3QN3d+FcghzMiPg6MDE/fllJ24/HFMIIEgctocPE= X-Received: by 2002:a05:6512:5d7:: with SMTP id o23mr2009782lfo.81.1615625945414; Sat, 13 Mar 2021 00:59:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Sat, 13 Mar 2021 08:58:53 +0000 Message-ID: Subject: Re: [PATCH] PR fortran/99112 - [11 Regression] ICE with runtime diagnostics for SIZE intrinsic function To: Harald Anlauf Cc: fortran , gcc-patches X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2021 08:59:08 -0000 Hi Harald, I am not sure of the etiquette for this - it looks OK to me :-) Cheers Paul On Fri, 12 Mar 2021 at 21:20, Harald Anlauf via Fortran wrote: > Dear all, > > the addition of runtime checks for the SIZE intrinsic created a regression > that showed up for certain CLASS arguments to procedures. Paul did most of > the work (~ 99%), but asked me to dig into an issue with an inappropriately > selected error message. This actually turned out to be a simple one-liner > on top of Paul's patch. > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > > Thanks, > Harald > > P.S.: I couldn't find a Changelog entry that uses co-authors. Is the > version > below correct? > > > PR fortran/99112 - ICE with runtime diagnostics for SIZE intrinsic function > > Add/fix handling of runtime checks for CLASS arguments with ALLOCATABLE > or POINTER attribute. > > gcc/fortran/ChangeLog: > > * trans-expr.c (gfc_conv_procedure_call): Fix runtime checks for > CLASS arguments. > * trans-intrinsic.c (gfc_conv_intrinsic_size): Likewise. > > gcc/testsuite/ChangeLog: > > * gfortran.dg/pr99112.f90: New test. > > Co-authored-by: Paul Thomas > > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein