From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 97E7A3858D32; Fri, 7 Apr 2023 13:53:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97E7A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2401d30c59aso175602a91.1; Fri, 07 Apr 2023 06:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680875626; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=j8NnOaRrXTJ8h8K9p7oEn9oEe7jYGoVUEunHmINRrW8=; b=fKcrW5IIe6gzWG61Ls5lMeNrOnZDua3bjSjAf2WtjnyviLMDpGg2hJpS2rIGwsw9Tc Pb+Un+8MeyoB8nQ2iLsl3qNOHCSoF+HMr9mLd2czsSPsj3hBBNGV/F5BLzxbnF3Ie4g/ C5j8gsH0HmdSwcA9HtaOd31vLryutzHUsTC+1PdeLSUR7P1XpTyysLhInrhrjkUr/P32 q3deaytKlslOQK3Mk6dxzzQqCC5pQmOUHYsEZTrPprzrg/2UzxauVGT/H3D5wzgCr1G0 9PdB313hlZ0MVJNHncqEI94KtBsKdzSzqKN37C+YLxRng2etcnaU+bQgArUUdqX/TZXW iOeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680875626; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j8NnOaRrXTJ8h8K9p7oEn9oEe7jYGoVUEunHmINRrW8=; b=2Kw7TUoRTXXJwhpNIDizTaYgKhDqfkRvjb1vVuaU7eWpDVhZp2tO/vasBWUSpmujIa iyoCSXAyU7yO8ovecJXieJ6DEiKMlMaHsSbcDOU937h7s2e2qesL2ZQ6H2cOWqzpAXky mqfMNe90FtEbhbbuXetrzZ4/9uQMzch6sts01GMGmoEs/fykap6uBpsJHDR8Cs4v0tl2 GUgjW/Jos3KlDEiOvQO8QcIgzBRsZemGTDbEkGHpxoIZCk5ap6IFNeXHZZxsXfCyqzEf Pip+CZQtNnDDySaRxuxciEg2hLFBURoNdQX6KUtDI2/FJc403CiY+v2goZ99nx6H/AOE 0miA== X-Gm-Message-State: AAQBX9c3yVCEC2on2ksCTvFGl5+PP6GByIvcF+SJIsfQbQQ4ohygmOVu MlO3CdxIbPBkX1CjoQ9IbFFXKt+sypHvpJ8RlfA= X-Google-Smtp-Source: AKy350aaIvYiew5YI9e5WHv2movoYMmwTeyTplmLq/ODLSjX22al3LeS7H1QHPxA7xWg/6dknRmB8DAx1aJ7wLj2Dd0= X-Received: by 2002:a05:6a00:2391:b0:626:23a1:7b9d with SMTP id f17-20020a056a00239100b0062623a17b9dmr1345577pfc.6.1680875626251; Fri, 07 Apr 2023 06:53:46 -0700 (PDT) MIME-Version: 1.0 References: <67044cbd-2fa5-8abf-e1d2-42fb150d0124@gmx.de> In-Reply-To: <67044cbd-2fa5-8abf-e1d2-42fb150d0124@gmx.de> From: Paul Richard Thomas Date: Fri, 7 Apr 2023 14:53:34 +0100 Message-ID: Subject: Re: Ping! [Patch, fortran] PR87477 - [meta-bug] [F03] issues concerning the ASSOCIATE statement To: Harald Anlauf Cc: "fortran@gcc.gnu.org" , gcc-patches Content-Type: multipart/mixed; boundary="0000000000009dbe7105f8bf5a5c" X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000009dbe7105f8bf5a5c Content-Type: multipart/alternative; boundary="0000000000009dbe6f05f8bf5a5a" --0000000000009dbe6f05f8bf5a5a Content-Type: text/plain; charset="UTF-8" duuuh! Please find them attached. Thanks Paul On Fri, 7 Apr 2023 at 10:41, Harald Anlauf wrote: > Hi Paul, > > I don't see the new testcases. Is this an issue on my side, > or did you forget to attach them? > > Thanks, > Harald > > On 4/7/23 09:07, Paul Richard Thomas via Gcc-patches wrote: > > Dear All, > > > > Please find attached a slightly updated version of the patch with a > > consolidated testcase. The three additional testcases are nothing to do > > with associate and test fixes of character related bugs. > > > > OK for mainline? > > > > Cheers > > > > Paul > > Fortran: Fix some of the bugs in associate [PR87477] > > > > 2023-04-07 Paul Thomas > > > > gcc/fortran > > PR fortran/87477 > > * resolve.cc (resolve_assoc_var): Handle parentheses around the > > target expression. > > (resolve_block_construct): Remove unnecessary static decls. > > * trans-array.cc (gfc_conv_expr_descriptor): Guard string len > > expression in condition. Improve handling of string length and > > span, especially for substrings of the descriptor. > > (duplicate_allocatable): Make element type more explicit with > > 'eltype'. > > * trans_decl.cc (gfc_get_symbol_decl): Emit a fatal error with > > appropriate message instead of ICE if symbol type is unknown. > > * trans-expr.cc (gfc_get_expr_charlen): Retain last charlen in > > 'previous' and use if end expression in substring reference is > > null. > > (gfc_conv_string_length): Use gfc_conv_expr_descriptor if > > 'expr_flat' is an array. > > (gfc_trans_alloc_subarray_assign): If this is a deferred string > > length component, store the string length in the hidden comp. > > Update the typespec length accordingly. Generate a new type > > spec for the call to gfc_duplicate-allocatable in this case. > > * trans-io.cc (gfc_trans_transfer): Scalarize transfer of > > deferred character array components. > > > > > > gcc/testsuite/ > > PR fortran/87477 > > * gfortran.dg/finalize_47.f90 : Enable substring test. > > * gfortran.dg/finalize_51.f90 : Update an error message. > > > > PR fortran/85686 > > PR fortran/88247 > > PR fortran/91941 > > PR fortran/92779 > > PR fortran/93339 > > PR fortran/93813 > > PR fortran/100948 > > PR fortran/102106 > > * gfortran.dg/associate_60.f90 : New test > > > > PR fortran/98408 > > * gfortran.dg/pr98408.f90 : New test > > > > PR fortran/105205 > > * gfortran.dg/pr105205.f90 : New test > > > > PR fortran/106918 > > * gfortran.dg/pr106918.f90 : New test > > -- "If you can't explain it simply, you don't understand it well enough" - Albert Einstein --0000000000009dbe6f05f8bf5a5a-- --0000000000009dbe7105f8bf5a5c Content-Type: text/x-fortran; charset="US-ASCII"; name="associate_60.f90" Content-Disposition: attachment; filename="associate_60.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lg6lqibk0 ISB7IGRnLWRvIHJ1biB9CiEKISBUZXN0cyBmaXhlcyBmb3IgdmFyaW91cyBw cjg3NDc3IGRlcGVuZGVuY2llcwohCiEgQ29udHJpYnV0ZWQgYnkgR2VyaGFy ZCBTdGVpbm1ldHogIDxnc2NmcUB0LW9ubGluZS5kZT4gZXhjZXB0IGZvciBw cjEwMjEwNjoKISB3aGljaCB3YXMgY29udHJpYnV0ZWQgYnkgQnJhZCBSaWNo YXJkc29uICA8ZXZlcnl0aGluZ2Z1bmN0aW9uYWxAcHJvdG9ubWFpbC5jb20+ CiEKcHJvZ3JhbSBhc3NvY2lhdGVfNjAKICBpbXBsaWNpdCBub25lCiAgY2hh cmFjdGVyKDIwKSA6OiBidWZmZXIKCiAgY2FsbCBwcjEwMjEwNgogIGNhbGwg cHIxMDA5NDgKICBjYWxsIHByODU2ODYKICBjYWxsIHByODgyNDcKICBjYWxs IHByOTE5NDEKICBjYWxsIHByOTI3NzkKICBjYWxsIHByOTMzMzkKICBjYWxs IHByOTM4MTMKCmNvbnRhaW5zCgogIHN1YnJvdXRpbmUgcHIxMDIxMDYKICAg IHR5cGUgOjogc3ViX2NsYXNzX3QKICAgICAgICBpbnRlZ2VyIDo6IGkKICAg IGVuZCB0eXBlCiAgICB0eXBlIDo6IHdpdGhfcG9seW1vcnBoaWNfY29tcG9u ZW50X3QKICAgICAgICBjbGFzcyhzdWJfY2xhc3NfdCksIGFsbG9jYXRhYmxl IDo6IHN1Yl9vYmpfCiAgICBlbmQgdHlwZQogICAgYXNzb2NpYXRlKG9iaiA9 PiB3aXRoX3BvbHltb3JwaGljX2NvbXBvbmVudF90KHN1Yl9jbGFzc190KDQy KSkpCiAgICAgICAgaWYgKG9iaiVzdWJfb2JqXyVpIC5uZS4gNDIpIHN0b3Ag MQogICAgZW5kIGFzc29jaWF0ZQogIGVuZAoKICBzdWJyb3V0aW5lIHByMTAw OTQ4CiAgICB0eXBlIHQKICAgICAgY2hhcmFjdGVyKDopLCBhbGxvY2F0YWJs ZSA6OiBjKDopCiAgICBlbmQgdHlwZQogICAgdHlwZSh0KSwgYWxsb2NhdGFi bGUgOjogeAohCiEgVmFsaWQgdGVzdCBpbiBjb21tZW50IDEKIQogICAgeCA9 IHQoWydhYicsJ2NkJ10pCiAgICBhc3NvY2lhdGUgKHkgPT4geCVjKDopKQog ICAgICBpZiAoYW55ICh5IC5uZS4geCVjKSkgc3RvcCAyCiAgICAgIGlmIChh bnkgKHkgLm5lLiBbJ2FiJywnY2QnXSkpIHN0b3AgMwogICAgZW5kIGFzc29j aWF0ZQogICAgZGVhbGxvY2F0ZSAoeCkKIQohIEFsbG9jYXRpb24gd2l0aCBz b3VyY2Ugd2FzIGZvdW5kIHRvIG9ubHkgY29weSBvdmVyIG9uZSBvZiB0aGUg YXJyYXkgZWxlbWVudHMKIQogICAgYWxsb2NhdGUgKHgsIHNvdXJjZSA9IHQo WydlZicsJ2doJ10pKQogICAgYXNzb2NpYXRlICh5ID0+IHglYyg6KSkKICAg ICAgaWYgKGFueSAoeSAubmUuIHglYykpIHN0b3AgNAogICAgICBpZiAoYW55 ICh5IC5uZS4gWydlZicsJ2doJ10pKSBzdG9wIDUKICAgIGVuZCBhc3NvY2lh dGUKICAgIGRlYWxsb2NhdGUgKHgpCiAgZW5kCgogIHN1YnJvdXRpbmUgcHI4 NTY4NgogICAgY2FsbCBzODU2ODYoWyIgZydkYXkgIiwiIGJ5ZSEhICJdKQog ICAgaWYgKHRyaW0gKGJ1ZmZlcikgLm5lLiAiIGEgZydkYXkgYSBieWUhISIp IHN0b3AgNgogIGVuZAoKICBzdWJyb3V0aW5lIHM4NTY4Nih4KQogICAgY2hh cmFjdGVyKCopIDo6IHgoOikKICAgIGFzc29jaWF0ZSAoeSA9PiAnYScvL3gp CiAgICAgIHdyaXRlIChidWZmZXIsICopIHkgISBVc2VkIHRvIHNlZ2ZhdWx0 IGF0IHRoZSB3cml0ZSBzdGF0ZW1lbnQuCiAgICBlbmQgYXNzb2NpYXRlCiAg ZW5kCgogIHN1YnJvdXRpbmUgcHI4ODI0NwogICAgICB0eXBlIHQKICAgICAg ICAgY2hhcmFjdGVyKDopLCBkaW1lbnNpb24oOiksIGFsbG9jYXRhYmxlIDo6 IGQKICAgICAgZW5kIHR5cGUgdAogICAgICB0eXBlKHQpLCBhbGxvY2F0YWJs ZSA6OiB4CiAgICAgIGNoYXJhY3Rlcig1KSA6OiBidWZmZXIoMykKICAgICAg YWxsb2NhdGUgKHgsIHNvdXJjZSA9IHQgKFsnYWInLCdjZCddKSkgISBEaWRu J3Qgd29yawogICAgICB3cml0ZShidWZmZXIoMSksICopIHglZCgyOjE6LTEp ICAgICAgICAhIFdhcyBmb3VuZCB0byBiZSBicm9rZW4KICAgICAgd3JpdGUo YnVmZmVyKDIpLCAqKSBbeCVkKDI6MTotMSldICAgICAgISBXYXMgT0sKICAg ICAgYXNzb2NpYXRlICh5ID0+IFt4JWQoMjoxOi0xKV0pCiAgICAgICAgd3Jp dGUoYnVmZmVyKDMpLCAqKSB5ICAgICAgICAgICAgICAgICEgQnVnIGluIGNv bW1lbnQgNwogICAgICBlbmQgYXNzb2NpYXRlCiAgICAgIGlmIChhbnkgKGJ1 ZmZlciAubmUuICIgY2RhYiIpKSBzdG9wIDcKICBlbmQKCiAgc3Vicm91dGlu ZSBwcjkxOTQxCiAgICBjaGFyYWN0ZXIoOiksIGFsbG9jYXRhYmxlIDo6IHgo OiksIHooOikKICAgIHggPSBbJyBhYmMnLCAnIHh5eiddCiAgICB6ID0gYWRq dXN0bCh4KQogICAgYXNzb2NpYXRlICh5ID0+IGFkanVzdGwoeCkpICAgICAg ICAgICAgICAhIFdyb25nIGNoYXJhY3RlciBsZW5ndGggd2FzIHBhc3NlZAog ICAgICBpZiAoYW55KHkgLm5lLiBbJ2FiYyAnLCAneHl6ICddKSkgc3RvcCA4 CiAgICBlbmQgYXNzb2NpYXRlCiAgZW5kCgogIHN1YnJvdXRpbmUgcHI5Mjc3 OQogICAgY2hhcmFjdGVyKDMpIDo6IGEgPSAnYWJjJwogICAgYXNzb2NpYXRl ICh5ID0+IHNwcmVhZCh0cmltKGEpLDEsMikgLy8gJ2QnKQogICAgICBpZiAo YW55ICh5IC5uZS4gWydhYmNkJywnYWJjZCddKSkgc3RvcCA5CiAgICBlbmQg YXNzb2NpYXRlCiAgZW5kCgogIHN1YnJvdXRpbmUgcHI5MzMzOQogICAgdHlw ZSB0CiAgICAgIGNoYXJhY3Rlcig6KSwgYWxsb2NhdGFibGUgOjogYSg6KQog ICAgZW5kIHR5cGUKICAgIHR5cGUodCkgOjogeAogICAgeCA9IHQoWyJhYmMg Il0pICAgICAgICAgICAgICAgICAgICAhIERpZG4ndCBhc3NpZ24gYW55dGhp bmcKISAgIGFsbG9jYXRlICh4JWEoMSksIHNvdXJjZSA9ICdhYmMnKSAhIFdv cmtlZCBPSwogICAgYXNzb2NpYXRlICh5ID0+IHglYSkKICAgICAgIGlmIChh bnkgKHkgLm5lLiAnYWJjICcpKSBzdG9wIDEwCiAgICAgICAgICBhc3NvY2lh dGUgKHogPT4geCVhKQogICAgICAgICAgICBpZiAoYW55ICh5IC5uZS4geikp IHN0b3AgMTEKICAgICAgICAgIGVuZCBhc3NvY2lhdGUKICAgIGVuZCBhc3Nv Y2lhdGUKICBlbmQKCiAgc3Vicm91dGluZSBwcjkzODEzCiAgICB0eXBlIHQK ICAgIGVuZCB0eXBlCiAgICB0eXBlLCBleHRlbmRzKHQpIDo6IHQyCiAgICBl bmQgdHlwZQogICAgY2xhc3ModCksIGFsbG9jYXRhYmxlIDo6IHgKICAgIGlu dGVnZXIgOjogaSA9IDAKICAgIGFzc29jaWF0ZSAoeSA9PiAoeCkpICAhIFRo ZSBwYXJlbnRoZXNlcyB0cmlnZ2VyZWQgYW4gSUNFIGluIHNlbGVjdCB0eXBl CiAgICAgIHNlbGVjdCB0eXBlICh5KQogICAgICB0eXBlIGlzICh0MikKICAg ICAgICAgIHN0b3AgMTIKICAgICAgdHlwZSBpcyAodCkKICAgICAgICAgIGkg PSA0MgogICAgICBjbGFzcyBkZWZhdWx0CiAgICAgICAgICBzdG9wIDEzCiAg ICAgIGVuZCBzZWxlY3QKICAgIGVuZCBhc3NvY2lhdGUKICAgIGlmIChpIC5u ZS4gNDIpIHN0b3AgMTQKICBlbmQKZW5kCg== --0000000000009dbe7105f8bf5a5c Content-Type: text/x-fortran; charset="US-ASCII"; name="pr98408.f90" Content-Disposition: attachment; filename="pr98408.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lg6ltvsv1 ISB7IGRnLWRvIHJ1biB9CiEKISBDb250cmlidXRlZCBieSBUaG9tYXMgS29l bmlnICA8dGtvZW5pZ0BnY2MuZ251Lm9yZz4KIQpwcm9ncmFtIG1haW4KICBj aGFyYWN0ZXIgKGxlbj06KSwgYWxsb2NhdGFibGUgOjogYSg6KQogIGFsbG9j YXRlIChjaGFyYWN0ZXIobGVuPTEwKSA6OiBhKDUpKQogIGlmIChzaXplb2Yo YSkgLm5lLiA1MCkgc3RvcCAxCiAgZGVhbGxvY2F0ZSAoYSkKZW5kIHByb2dy YW0gbWFpbgo= --0000000000009dbe7105f8bf5a5c Content-Type: text/x-fortran; charset="US-ASCII"; name="pr105205.f90" Content-Disposition: attachment; filename="pr105205.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lg6lvnan2 ISB7IGRnLWRvIHJ1biB9CiEKISBDb250cmlidXRlZCBieSBSaWNoIFRvd25z ZW5kICA8dG93bnNlbmRAYXN0cm8ud2lzYy5lZHU+CiEKcHJvZ3JhbSBhbGxv Y19jaGFyX3R5cGUKICAgaW1wbGljaXQgbm9uZQogICBpbnRlZ2VyLCBwYXJh bWV0ZXIgOjogc3RhcnQgPSAxLCBmaW5pc2ggPSA0CiAgIGNoYXJhY3Rlcigz KSA6OiBjaGVjayg0KQogICB0eXBlIG15dHlwZQogICAgICBjaGFyYWN0ZXIo OiksIGFsbG9jYXRhYmxlIDo6IGMoOikKICAgZW5kIHR5cGUgbXl0eXBlCiAg IHR5cGUobXl0eXBlKSA6OiBhCiAgIHR5cGUobXl0eXBlKSA6OiBiCiAgIGlu dGVnZXIgOjogaQogICBhJWMgPSBbJ2ZvbycsJ2JhcicsJ2JpeicsJ2J1eidd CiAgIGNoZWNrID0gWydmb28nLCdiYXInLCdiaXonLCdidXonXQogICBiID0g YQogICBkbyBpID0gMSwgc2l6ZShiJWMpCiAgICAgIGlmIChiJWMoaSkgLm5l LiBjaGVjayhpKSkgc3RvcCAxCiAgIGVuZCBkbwogICBpZiAoYW55IChhJWMg Lm5lLiBjaGVjaykpIHN0b3AgMgogICBpZiAoYW55IChhJWMoc3RhcnQ6Zmlu aXNoKSAubmUuIGNoZWNrKSkgc3RvcCAzCiAgIGRlYWxsb2NhdGUgKGElYykK ICAgZGVhbGxvY2F0ZSAoYiVjKQplbmQK --0000000000009dbe7105f8bf5a5c Content-Type: text/x-fortran; charset="US-ASCII"; name="pr106918.f90" Content-Disposition: attachment; filename="pr106918.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lg6lwrrs3 ISB7IGRnLWRvIHJ1biB9CiEKISBDb250cmlidXRlZCBieSBMaW9uZWwgR3Vl eiAgPGd1ZXpAbG1kLmVucy5mcj4KIQogIGNoYXJhY3RlcihsZW4gPSA6KSwg YWxsb2NhdGFibGU6OiBhdHRyX25hbWUoOikKICBjaGFyYWN0ZXIoNikgOjog YnVmZmVyCiAgdHlwZSBjb29yZF9kZWYKICAgICBjaGFyYWN0ZXIobGVuID0g OiksIGFsbG9jYXRhYmxlOjogYXR0cl9uYW1lKDopCiAgZW5kIHR5cGUgY29v cmRfZGVmCiAgdHlwZShjb29yZF9kZWYpIGNvb3JkaW5hdGVzCiAgYXR0cl9u YW1lID0gWyJ1bml0cyJdCiAgd3JpdGUgKGJ1ZmZlciwgKikgYXR0cl9uYW1l CiAgaWYgKGJ1ZmZlciAubmUuICIgdW5pdHMiKSBzdG9wIDEKICBjb29yZGlu YXRlcyA9IGNvb3JkX2RlZihhdHRyX25hbWUpCiAgd3JpdGUgKGJ1ZmZlciwg KikgY29vcmRpbmF0ZXMlYXR0cl9uYW1lCiAgaWYgKGJ1ZmZlciAubmUuICIg dW5pdHMiKSBzdG9wIDIKICBkZWFsbG9jYXRlIChhdHRyX25hbWUpCiAgZGVh bGxvY2F0ZSAoY29vcmRpbmF0ZXMlYXR0cl9uYW1lKQplbmQK --0000000000009dbe7105f8bf5a5c--