From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37796 invoked by alias); 26 Oct 2015 12:04:36 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 37759 invoked by uid 89); 26 Oct 2015 12:04:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-oi0-f43.google.com Received: from mail-oi0-f43.google.com (HELO mail-oi0-f43.google.com) (209.85.218.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 26 Oct 2015 12:04:29 +0000 Received: by oifu63 with SMTP id u63so56166555oif.2; Mon, 26 Oct 2015 05:04:27 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.202.105.84 with SMTP id e81mr2091965oic.30.1445861067845; Mon, 26 Oct 2015 05:04:27 -0700 (PDT) Received: by 10.202.168.133 with HTTP; Mon, 26 Oct 2015 05:04:27 -0700 (PDT) In-Reply-To: <20151026110314.29862118@vepi2> References: <20151025133102.2aa5ebd6@vepi2> <20151026110314.29862118@vepi2> Date: Mon, 26 Oct 2015 12:04:00 -0000 Message-ID: Subject: Re: [Patch, Fortran, 66927, v2.1] [6 Regression] ICE in gfc_conf_procedure_call From: Paul Richard Thomas To: Andre Vehreschild Cc: =?UTF-8?Q?Dominique_d=27Humi=C3=A8res?= , gcc-patches , Mikael Morin , GNU GFortran Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg00146.txt.bz2 Hi Andre, Yes, that's good to fix the problem. OK to commit Thanks for the rapid fix. Paul On 26 October 2015 at 11:03, Andre Vehreschild wrote: > Hi all, > > unfortunately did my last patch create a segfault on some 32-bit > system. This happens because in the scalarizer the lower bound of the > deferred length array of the source=3D expression was taken to be > constant zero instead of taking that information from the array > descriptor. This patch fixes the segfault by taking the lower -- and to > keep it in sync also the upper -- bound from the array descriptor when > doing the array assign in the allocate (). > > Bootstrapped and regtested on x86_64-linux-gnu/f21. > > Ok for trunk? > > Sorry for the regression. > > Regards, > Andre > > On Sun, 25 Oct 2015 13:31:02 +0100 > Andre Vehreschild wrote: > >> Hi Paul, hi all, >> >> thanks for the review. Submitted as r229294. >> >> Regards, >> Andre >> >> On Sun, 25 Oct 2015 08:43:24 +0100 >> Paul Richard Thomas wrote: >> >> > Dear Andre, >> > >> > As far as I can see, the problems with PR57117 are specific to RESHAPE >> > and need not affect committing your patch. To my surprise, the >> > combination of your patch and mine for PR67171 fixes PR67044 in that >> > the ICE no longer occurs. I have to get my head around how to write a >> > testcase for it that tests the functionality though! >> > >> > You can commit this patch to trunk. As I said elsewhere, I will rename >> > the testcase for PR67171. >> > >> > Many thanks for the patch. >> > >> > Paul >> > >> > On 23 October 2015 at 09:44, Paul Richard Thomas >> > wrote: >> > > Dear Andre, >> > > >> > > I will wait until you fix the problems that Dominique has pointed ou= t. >> > > However, if by Sunday afternoon (rain forecast!) you haven't found t= he >> > > time, I will see if I can locate the source of these new problems. >> > > >> > > With best regards >> > > >> > > Paul >> > > >> > > On 7 October 2015 at 19:51, Dominique d'Humi=C3=A8res wrote: >> > >> This patch also fixes pr57117 comment 2, the original test and the = test in comment 3 now give an ICE >> > >> >> > >> pr57117.f90:82:0: >> > >> >> > >> allocate(z(9), source=3Dreshape(x, (/ 9 /))) >> > >> 1 >> > >> internal compiler error: Segmentation fault: 11 >> > >> >> > >> and pr67044. >> > >> >> > >> Thanks, >> > >> >> > >> Dominique >> > >> >> > > >> > > >> > > >> > > -- >> > > Outside of a dog, a book is a man's best friend. Inside of a dog it's >> > > too dark to read. >> > > >> > > Groucho Marx >> > >> > >> > >> >> > > > -- > Andre Vehreschild * Email: vehre ad gmx dot de --=20 Outside of a dog, a book is a man's best friend. Inside of a dog it's too dark to read. Groucho Marx