* [Patch, fortran] PR84219 - [8 Regression] ICE: Invalid expression in gfc_target_interpret_expr
@ 2018-03-01 13:28 Paul Richard Thomas
2018-03-02 8:26 ` Christophe Lyon
0 siblings, 1 reply; 6+ messages in thread
From: Paul Richard Thomas @ 2018-03-01 13:28 UTC (permalink / raw)
To: fortran, gcc-patches
Committed as 'obvious' in revision 258098.
Paul
2018-03-01 Paul Thomas <pault@gcc.gnu.org>
PR fortran/84219
* target-memory.c (gfc_interpret_derived): Assert that BT_VOID
components are caf tokens.
(gfc_target_interpret_expr): Treat BT_VOID expressions as
integers.
2018-03-01 Paul Thomas <pault@gcc.gnu.org>
PR fortran/84219
* gfortran.dg/coarray_47.f90: New test.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, fortran] PR84219 - [8 Regression] ICE: Invalid expression in gfc_target_interpret_expr
2018-03-01 13:28 [Patch, fortran] PR84219 - [8 Regression] ICE: Invalid expression in gfc_target_interpret_expr Paul Richard Thomas
@ 2018-03-02 8:26 ` Christophe Lyon
2018-03-02 8:38 ` Paul Richard Thomas
0 siblings, 1 reply; 6+ messages in thread
From: Christophe Lyon @ 2018-03-02 8:26 UTC (permalink / raw)
To: Paul Richard Thomas; +Cc: fortran, gcc-patches
On 1 March 2018 at 14:28, Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
> Committed as 'obvious' in revision 258098.
>
> Paul
>
> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/84219
> * target-memory.c (gfc_interpret_derived): Assert that BT_VOID
> components are caf tokens.
> (gfc_target_interpret_expr): Treat BT_VOID expressions as
> integers.
>
> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>
> PR fortran/84219
> * gfortran.dg/coarray_47.f90: New test.
Hi Paul,
You may already be aware of that, but the new test fails at least on
aarch64 and arm targets:
FAIL: gfortran.dg/coarray_47.f90 -O (test for errors, line 12)
As a matter of fact, I can see no error message in gfortran.log, hence
dg-error fails to match.
Christophe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, fortran] PR84219 - [8 Regression] ICE: Invalid expression in gfc_target_interpret_expr
2018-03-02 8:26 ` Christophe Lyon
@ 2018-03-02 8:38 ` Paul Richard Thomas
2018-03-02 8:41 ` Christophe Lyon
2018-03-02 8:53 ` Paul Richard Thomas
0 siblings, 2 replies; 6+ messages in thread
From: Paul Richard Thomas @ 2018-03-02 8:38 UTC (permalink / raw)
To: Christophe Lyon; +Cc: fortran, gcc-patches
Hi Christophe,
I was not aware. Thanks for letting me know.
It's wierd that there is no error message or an ICE. Previously, an
ICE would occur instead of the intended error message.
I do not have access to either targets. Would you be so kind as to run
coarray_47.f90 separately to see what happens? Note that 7-branch
behaves correctly.
Cheers
Paul
On 2 March 2018 at 08:26, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> On 1 March 2018 at 14:28, Paul Richard Thomas
> <paul.richard.thomas@gmail.com> wrote:
>> Committed as 'obvious' in revision 258098.
>>
>> Paul
>>
>> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>>
>> PR fortran/84219
>> * target-memory.c (gfc_interpret_derived): Assert that BT_VOID
>> components are caf tokens.
>> (gfc_target_interpret_expr): Treat BT_VOID expressions as
>> integers.
>>
>> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>>
>> PR fortran/84219
>> * gfortran.dg/coarray_47.f90: New test.
>
>
> Hi Paul,
>
> You may already be aware of that, but the new test fails at least on
> aarch64 and arm targets:
> FAIL: gfortran.dg/coarray_47.f90 -O (test for errors, line 12)
> As a matter of fact, I can see no error message in gfortran.log, hence
> dg-error fails to match.
>
> Christophe
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, fortran] PR84219 - [8 Regression] ICE: Invalid expression in gfc_target_interpret_expr
2018-03-02 8:38 ` Paul Richard Thomas
@ 2018-03-02 8:41 ` Christophe Lyon
2018-03-02 8:46 ` Paul Richard Thomas
2018-03-02 8:53 ` Paul Richard Thomas
1 sibling, 1 reply; 6+ messages in thread
From: Christophe Lyon @ 2018-03-02 8:41 UTC (permalink / raw)
To: Paul Richard Thomas; +Cc: fortran, gcc-patches
On 2 March 2018 at 09:38, Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
> Hi Christophe,
>
> I was not aware. Thanks for letting me know.
>
> It's wierd that there is no error message or an ICE. Previously, an
> ICE would occur instead of the intended error message.
>
> I do not have access to either targets. Would you be so kind as to run
> coarray_47.f90 separately to see what happens? Note that 7-branch
> behaves correctly.
>
> Cheers
According to https://gcc.gnu.org/ml/gcc-testresults/2018-03/
it also happens on x86_64, I suspect that's easier for you?
Thanks,
Christophe
>
> Paul
>
> On 2 March 2018 at 08:26, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>> On 1 March 2018 at 14:28, Paul Richard Thomas
>> <paul.richard.thomas@gmail.com> wrote:
>>> Committed as 'obvious' in revision 258098.
>>>
>>> Paul
>>>
>>> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>>>
>>> PR fortran/84219
>>> * target-memory.c (gfc_interpret_derived): Assert that BT_VOID
>>> components are caf tokens.
>>> (gfc_target_interpret_expr): Treat BT_VOID expressions as
>>> integers.
>>>
>>> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>>>
>>> PR fortran/84219
>>> * gfortran.dg/coarray_47.f90: New test.
>>
>>
>> Hi Paul,
>>
>> You may already be aware of that, but the new test fails at least on
>> aarch64 and arm targets:
>> FAIL: gfortran.dg/coarray_47.f90 -O (test for errors, line 12)
>> As a matter of fact, I can see no error message in gfortran.log, hence
>> dg-error fails to match.
>>
>> Christophe
>
>
>
> --
> "If you can't explain it simply, you don't understand it well enough"
> - Albert Einstein
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, fortran] PR84219 - [8 Regression] ICE: Invalid expression in gfc_target_interpret_expr
2018-03-02 8:41 ` Christophe Lyon
@ 2018-03-02 8:46 ` Paul Richard Thomas
0 siblings, 0 replies; 6+ messages in thread
From: Paul Richard Thomas @ 2018-03-02 8:46 UTC (permalink / raw)
To: Christophe Lyon; +Cc: fortran, gcc-patches
By golly you are right!
Je vous en remercie :-)
Paul
On 2 March 2018 at 08:41, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> On 2 March 2018 at 09:38, Paul Richard Thomas
> <paul.richard.thomas@gmail.com> wrote:
>> Hi Christophe,
>>
>> I was not aware. Thanks for letting me know.
>>
>> It's wierd that there is no error message or an ICE. Previously, an
>> ICE would occur instead of the intended error message.
>>
>> I do not have access to either targets. Would you be so kind as to run
>> coarray_47.f90 separately to see what happens? Note that 7-branch
>> behaves correctly.
>>
>> Cheers
>
> According to https://gcc.gnu.org/ml/gcc-testresults/2018-03/
> it also happens on x86_64, I suspect that's easier for you?
>
> Thanks,
>
> Christophe
>
>>
>> Paul
>>
>> On 2 March 2018 at 08:26, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>>> On 1 March 2018 at 14:28, Paul Richard Thomas
>>> <paul.richard.thomas@gmail.com> wrote:
>>>> Committed as 'obvious' in revision 258098.
>>>>
>>>> Paul
>>>>
>>>> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>>>>
>>>> PR fortran/84219
>>>> * target-memory.c (gfc_interpret_derived): Assert that BT_VOID
>>>> components are caf tokens.
>>>> (gfc_target_interpret_expr): Treat BT_VOID expressions as
>>>> integers.
>>>>
>>>> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>>>>
>>>> PR fortran/84219
>>>> * gfortran.dg/coarray_47.f90: New test.
>>>
>>>
>>> Hi Paul,
>>>
>>> You may already be aware of that, but the new test fails at least on
>>> aarch64 and arm targets:
>>> FAIL: gfortran.dg/coarray_47.f90 -O (test for errors, line 12)
>>> As a matter of fact, I can see no error message in gfortran.log, hence
>>> dg-error fails to match.
>>>
>>> Christophe
>>
>>
>>
>> --
>> "If you can't explain it simply, you don't understand it well enough"
>> - Albert Einstein
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Patch, fortran] PR84219 - [8 Regression] ICE: Invalid expression in gfc_target_interpret_expr
2018-03-02 8:38 ` Paul Richard Thomas
2018-03-02 8:41 ` Christophe Lyon
@ 2018-03-02 8:53 ` Paul Richard Thomas
1 sibling, 0 replies; 6+ messages in thread
From: Paul Richard Thomas @ 2018-03-02 8:53 UTC (permalink / raw)
To: Christophe Lyon; +Cc: fortran, gcc-patches
Hi Christophe,
I committed the wrong test :-( Corrected r258128.
Many thanks
Paul
On 2 March 2018 at 08:38, Paul Richard Thomas
<paul.richard.thomas@gmail.com> wrote:
> Hi Christophe,
>
> I was not aware. Thanks for letting me know.
>
> It's wierd that there is no error message or an ICE. Previously, an
> ICE would occur instead of the intended error message.
>
> I do not have access to either targets. Would you be so kind as to run
> coarray_47.f90 separately to see what happens? Note that 7-branch
> behaves correctly.
>
> Cheers
>
> Paul
>
> On 2 March 2018 at 08:26, Christophe Lyon <christophe.lyon@linaro.org> wrote:
>> On 1 March 2018 at 14:28, Paul Richard Thomas
>> <paul.richard.thomas@gmail.com> wrote:
>>> Committed as 'obvious' in revision 258098.
>>>
>>> Paul
>>>
>>> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>>>
>>> PR fortran/84219
>>> * target-memory.c (gfc_interpret_derived): Assert that BT_VOID
>>> components are caf tokens.
>>> (gfc_target_interpret_expr): Treat BT_VOID expressions as
>>> integers.
>>>
>>> 2018-03-01 Paul Thomas <pault@gcc.gnu.org>
>>>
>>> PR fortran/84219
>>> * gfortran.dg/coarray_47.f90: New test.
>>
>>
>> Hi Paul,
>>
>> You may already be aware of that, but the new test fails at least on
>> aarch64 and arm targets:
>> FAIL: gfortran.dg/coarray_47.f90 -O (test for errors, line 12)
>> As a matter of fact, I can see no error message in gfortran.log, hence
>> dg-error fails to match.
>>
>> Christophe
>
>
>
> --
> "If you can't explain it simply, you don't understand it well enough"
> - Albert Einstein
--
"If you can't explain it simply, you don't understand it well enough"
- Albert Einstein
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-02 8:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01 13:28 [Patch, fortran] PR84219 - [8 Regression] ICE: Invalid expression in gfc_target_interpret_expr Paul Richard Thomas
2018-03-02 8:26 ` Christophe Lyon
2018-03-02 8:38 ` Paul Richard Thomas
2018-03-02 8:41 ` Christophe Lyon
2018-03-02 8:46 ` Paul Richard Thomas
2018-03-02 8:53 ` Paul Richard Thomas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).