From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <paul.richard.thomas@gmail.com>
Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com
 [IPv6:2607:f8b0:4864:20::f2a])
 by sourceware.org (Postfix) with ESMTPS id 61A313858D39;
 Thu,  3 Feb 2022 17:49:19 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 61A313858D39
Received: by mail-qv1-xf2a.google.com with SMTP id h16so3183246qvk.10;
 Thu, 03 Feb 2022 09:49:19 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=iKeNJmzBCiAeMPrL7sxiCzZ7X8o2g907VUvIkp26Krk=;
 b=7GkkZoz/0ywYUOVJgRW3sg2oj0qjZC5jT/yeUI7SctwhJs9gg91ldmoF8QysRQV603
 Mm7O6UIYRdrADZLFqrmVmuzc2eDfDVa23Te/YjciaOwZkcNm79To/5w+i3vlCDpzFv7N
 7CIkVB2KtgKO3sAUTomYSrJCTnYH8vzmRY15gxb1lEt/MtIBW+oOYff/K1BdR9ufxQHG
 KIogNNlxRHHLGO8q/P8hOlv2Vftd6eWOLvV2v3KbREEsTVzuK31BFGPJNsvbd95l1+wp
 3/CUVvTxg36iplvqIpqgtnWoTRKrWqNWgt+9RwTS1+wVhyWVR32LJ6ayLQ9ywC2mMZrC
 SFUw==
X-Gm-Message-State: AOAM5320ofWrI1nPz2aiFGprSwBYIIfTuw5zbxxeDIwnA0DkG4q0gDim
 UYiEB2p0KO9HqLrS8BncYalHrP2G5U6c+rR+wDM=
X-Google-Smtp-Source: ABdhPJxiVTJvxRzL9CQbkNLMN5IC7V37SvD8QGcafvTUIi6gjSIauwGMY+dx0AenKfYIP7ckX7VVKu88zDctbteogEE=
X-Received: by 2002:a05:6214:da2:: with SMTP id
 h2mr32155897qvh.49.1643910559028; 
 Thu, 03 Feb 2022 09:49:19 -0800 (PST)
MIME-Version: 1.0
References: <204cec48-ce99-500a-7951-939ee51d31d6@orange.fr>
 <67713536-50cf-575e-9fdb-20d83a095d0b@gmx.de>
In-Reply-To: <67713536-50cf-575e-9fdb-20d83a095d0b@gmx.de>
From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
Date: Thu, 3 Feb 2022 17:49:08 +0000
Message-ID: <CAGkQGiKuUR_ftXMeY8j0G_BQtNovVNnyRYPkN6=PUJH=SHO9tQ@mail.gmail.com>
Subject: Re: [PATCH] fortran: Unshare associate var charlen [PR104228]
To: Harald Anlauf <anlauf@gmx.de>
Cc: Mikael Morin <morin-mikael@orange.fr>, gfortran <fortran@gcc.gnu.org>, 
 gcc-patches <gcc-patches@gcc.gnu.org>
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE,
 RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
X-BeenThere: fortran@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Fortran mailing list <fortran.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/fortran/>
List-Help: <mailto:fortran-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/fortran>,
 <mailto:fortran-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2022 17:49:20 -0000

Hi Harald and Mikael,

This looks fine to me. OK for all the listed branches.

Thanks for the patch

Paul


On Wed, 2 Feb 2022 at 20:20, Harald Anlauf via Fortran <fortran@gcc.gnu.org=
>
wrote:

> Hi Mikael,
>
> Am 29.01.22 um 15:24 schrieb Mikael Morin:
> > Hello,
> >
> > the attached patch is a fix for PR104228.
> > Even if simple, I wouldn=E2=80=99t call it obvious, as it=E2=80=99s inv=
olving character
> > length and associate, so I don=E2=80=99t mind some extra review eyes.
>
> I am probably not experienced enough to review this.  Paul?
>
> Nevertheless, I looked at the commits that introduced the code
> you touched.  It appears that these did not cover, maybe even
> avoid the current case where the associate target is not a dummy.
> Your changes seem to make sense and fix the issue.
>
> > Tested on x86_64-pc-linux-gnu. Ok for master/11/10/9?
>
> OK, and thanks for the patch!
>
> Harald
>


--=20
"If you can't explain it simply, you don't understand it well enough" -
Albert Einstein