From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by sourceware.org (Postfix) with ESMTPS id E1699385840E; Tue, 19 Mar 2024 17:27:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1699385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1699385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1029 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710869276; cv=none; b=sVB+0QA2E5HaH6NY77YUePq6ZOwhdCeIQUeTIfbzPxlCN48x2O8KekBNytnWG9HDTSWTU9oIRn8q+KK0ffX6lgBftThTchjJENW/tpgDOPQhrXDVuVmw+pHCAhubhiN7R7rFLYajib+LL+gFfinfTApL+AJ0XGPQWkWlM2C9fGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710869276; c=relaxed/simple; bh=V7xUjmmnJ09EA7rz90ioT7RjB+lNJw4BJFbeOIVOi5g=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=l1mt0R/Bob/GMJLrbNos3+AB4sBVBA8R+vIQRSBBVjgvr1cJLzISHi18+7OUJOLadWpTesrRbhMvm0BQcPh+2Y3YzYGma8ejNB46zuTua91GXJCbV//IvoXmJ08U6t84YtyDuCeODvgfq7rX3WSFdz9AMepCbxTdXamvLv2txbw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-29de4e12d12so4135909a91.3; Tue, 19 Mar 2024 10:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710869273; x=1711474073; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Nqk2qfAC703Hyma6cby9xcS33nQZF/2R9qSE1ZqcyHw=; b=dKUNp8kwm4D1wW41MZtQsr3gWQLOdKFnicvgyoUCVpkN2L9a5RDwWYHZ7+eMw84BAG w5Nlb9iG/FuxZbWCdmfnDctQaoeVQnuMOghpDMqnmJDryS/0etR/rInqpBNfJnQfctQ7 tnQ64gr+DduqV3Vzp5UQDMheAsgI3WkDZEeLquXLs6Tm01GDle+TumiWXyV35bwB0GUL 5hxjbawuDLOLV8h1YQenlLMV41G9T2z2ZAyh5DWZpmxcQT1lPzFgmobDRihAcTnGUYTf BkHb6YGynhAtBVGeaH8Pufu3dfPA3Imlyta3rM72T5xd3UXxVozDAFnJjPzCXveJ4orw z7dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710869273; x=1711474073; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nqk2qfAC703Hyma6cby9xcS33nQZF/2R9qSE1ZqcyHw=; b=aLUfe75nsjnM7nLuxyI9eAsq9/OGWTDZGDOrrgkIqjJGi1IbhqEb33nt/Fub9H9uu6 L+dQy7plxIuKjBrnVCcZfTIzGRNGMHyVx5UudY73uTlHw1MfHgj8lmlgaLHl2bo6KQAO im+4yCw2v/j/DRwn9fXruqPh7TMQUz8/8V/7WN5/88ZlMLEC0HxI6dEbG50zKDHLmSnD MuB9CTu3XA1fPA5dDYH48uJooIPl12HRtt1+U5E2IcUvGSiTHaeSg7RYn3+v9D5uTm9+ 96yz9BDqH15Zuj3FGa7iIZSKVU1ZplfmlnlEhYEoQqxsjG0hzCCOLSE9qMtGHx2/uUvt QjWg== X-Forwarded-Encrypted: i=1; AJvYcCXqcEE5Nbc67eB8UnZFD0DnzXwfLxNGMw+uWtkss/TMiMyMpuadeXZmVL2befg4UaPF4G4wFVy347eRAbyvY2FA84d1ymmtKg== X-Gm-Message-State: AOJu0YwctHCz1hhP1KfDDyotS78aWfDw1AVUPmnOG7pdsY6AeOhrkIDi QgecTXOX2/XSAlLPPTgAx7CRN0QV+miGSBYNy/ntbbVMCBc/3X65lb5uY4MEd9+CbUip1mkrDLM RCsNxMywVWVR7u/c4tf6s7AuB+jiqJzVd X-Google-Smtp-Source: AGHT+IEj4ZxwUyzMfSIhwV4cSd2VoElujLxWIEb9khzEoSXUlEt+NthymPA8XUQdlFFCkqEXsyj+zEuKBrY+AU3ZscU= X-Received: by 2002:a17:90b:903:b0:29d:e193:e46d with SMTP id bo3-20020a17090b090300b0029de193e46dmr10777536pjb.39.1710869272582; Tue, 19 Mar 2024 10:27:52 -0700 (PDT) MIME-Version: 1.0 References: <20240319154918.272178-1-mikael@gcc.gnu.org> In-Reply-To: <20240319154918.272178-1-mikael@gcc.gnu.org> From: Paul Richard Thomas Date: Tue, 19 Mar 2024 17:27:41 +0000 Message-ID: Subject: Re: [PATCH v3 0/2] fortran: Fix specification checks [PR111781] To: Mikael Morin Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="0000000000003fe284061406cb60" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000003fe284061406cb60 Content-Type: text/plain; charset="UTF-8" Hi Mikael, Sorry, I am replying to these in the order that they appear in my intray :-) OK for mainline and, if you wish, 13-branch. Thanks Paul On Tue, 19 Mar 2024 at 15:49, Mikael Morin wrote: > Hello, > > these patches correct diagnostics dealing with variables in specification > expressions. > The first patch is a testsuite change, which fixes invalid specification > expressions that the second patch would diagnose. > The second patch removes a spurious diagnostic when a dummy procedure is > involved, and enables more valid ones, as visible in the testcases from the > first patch. > > I haven't tested it again (same code as v2), but I plan to do it before > the final push. > Ok for master? > > Mikael > > v2 -> v3 changes: > > - Correct first name in testcase comment > - Clarify and correct log and changelog text from second patch > - Target current stage (stage4) instead of next (stage1) > > v1 -> v2 changes: > > - Fix condition guarding sym->result access. > > > Mikael Morin (2): > testsuite: Declare fortran array bound variables > fortran: Fix specification expression error with dummy procedures > [PR111781] > > gcc/fortran/expr.cc | 8 +- > gcc/fortran/gfortran.h | 4 +- > gcc/fortran/resolve.cc | 77 +++++++++---------- > gcc/fortran/symbol.cc | 58 ++++++++++++++ > .../gfortran.dg/graphite/pr107865.f90 | 2 +- > gcc/testsuite/gfortran.dg/pr101267.f90 | 2 +- > gcc/testsuite/gfortran.dg/pr112404.f90 | 2 +- > gcc/testsuite/gfortran.dg/pr78061.f | 2 +- > gcc/testsuite/gfortran.dg/pr79315.f90 | 6 +- > gcc/testsuite/gfortran.dg/spec_expr_8.f90 | 24 ++++++ > gcc/testsuite/gfortran.dg/spec_expr_9.f90 | 19 +++++ > gcc/testsuite/gfortran.dg/vect/pr90681.f | 2 +- > gcc/testsuite/gfortran.dg/vect/pr97761.f90 | 2 +- > gcc/testsuite/gfortran.dg/vect/pr99746.f90 | 2 +- > 14 files changed, 152 insertions(+), 58 deletions(-) > create mode 100644 gcc/testsuite/gfortran.dg/spec_expr_8.f90 > create mode 100644 gcc/testsuite/gfortran.dg/spec_expr_9.f90 > > -- > 2.43.0 > > --0000000000003fe284061406cb60--