From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id E50113858D33; Sat, 20 Apr 2024 07:54:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E50113858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E50113858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713599671; cv=none; b=N4loJfoeRKdZMRtr+do6DpxuPjVzZ0XrGdw95+F0iNvWaRTPzMH9Aljh/ihFUx26WTkqrfgjFjOahSgrsRvvJfl5pste66XEalOhxmZUEmQmO6CV7wCOC+GLl7ACl+Ztbi7k1zpkyOvnV+Z0J3WRzywl7QRyejM22loDwzODPHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713599671; c=relaxed/simple; bh=y8nSFOsA8myR8bdCb2KbzSU1d+syVNvpCk9LNu+TG1w=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=h3UeuEnMVGtgNnHSxx97EjM7sTHPukfSwEPKxFL18zLwa4oXLGQVzM2CNggG8jQE4vQnaAAUA/LUh9QpjCCJWqFHK2L2MhdYxOXq2SSZtz6A12XO7kuyyy74cwQ/Yde65u2gxEU7HI4vWKkyzEoJoHhtlR7TffWnknCyJ+v3y0c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6ecec796323so2892504b3a.3; Sat, 20 Apr 2024 00:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713599665; x=1714204465; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cYVLdB7xswVyO+M7Hv/kXQuR3vKx2j47Z+UbmGjvxHY=; b=WXjb6sC/LkBo/t7irHE6lxM7C4+svKcwL7wmw1IcaT5hCFgkoCH41GheRktDV9CPI3 r81wbwQb14ae8J3Y0lcrdfTjIpqJHr7rFkKkyHP0Sp3KWo/THmakMAzq41GWe+yVvXJa 2pmvTLKtxaiQg/jWL8KtR3htpui3qAe3lIndszUvgX2cS1AuP1y5YLifV3nN4hTYaOGd WmWPWPkStEIgqnjIUBYwUqhEmunaiOZ4XoV82twuBj394vkFg4tWvCW7pA3jVn1cbIH/ dCm8C89CgrMwezHwclGd2DLHeBx8UiJL1VnL9UkPqoU+izso7SgMLqcNKX94FbjTOd7S jX1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713599665; x=1714204465; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cYVLdB7xswVyO+M7Hv/kXQuR3vKx2j47Z+UbmGjvxHY=; b=YXBuVFUomf3q+x4RBrwEB/AHgwyTG1XcWzoP+JCYAkiMpq+JBGTOYpFE/u/4vIBtrz 8dYTJK6+wmV15tck6Vx34+Trl+yqKChrkFlcnB3AHtkTx8cKvMgnM5RiycQDfOr02lz8 f2cMGOS1h2raKg/2R8YdFiJngV1Dyx19rM8XaFRl44RkZErkZuiDjBsmiGyT6tFn7KTV ttDUO3WlHCL+CWI07i3i9hTmIE1areheu08CNQTU8rKt+YQPkrRcOuYcHPtJHU7E7TwJ tx9dZIOa83lwDJW+fMhoeXPPtczWi3YAzq5JSl9ZULU0Dmg93mQzHwaklvcuV3Ta88m+ O0AQ== X-Forwarded-Encrypted: i=1; AJvYcCWWOxY/PXHiFf1Gqr+KLUm8qLaGfebYQcrjBR/nQrh+rLVgeWKKmdsxDxUtuof3MQNM3Ke1iVHwmOxevvCUfcJ9Mqp0 X-Gm-Message-State: AOJu0Yw/ux3VNVtYR9h+Z726U2Mj7BtxlnZkfBaktpFwKijnOAhwJUU6 evzfdRbIaQ/tra1fZY/WhL99O6o+KdqSbjCow6KOx8FE//rphPNOq70O4ZmkBp5NM6E5Gq495J4 CaCCGmwzOIVFjYrLhH90rgqFk31fmCQ== X-Google-Smtp-Source: AGHT+IEOvcUaBGvV1OjsCpHBxY5UNA2L8eLi0trLVlQtTR855+9IHY0tcCIOI6bkirPYV34hcjezP8u+TF6inYZifxo= X-Received: by 2002:a05:6a21:348b:b0:1ac:3a2c:b42 with SMTP id yo11-20020a056a21348b00b001ac3a2c0b42mr5608134pzb.9.1713599664757; Sat, 20 Apr 2024 00:54:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Sat, 20 Apr 2024 08:54:12 +0100 Message-ID: Subject: Re: [Patch, fortran] PR103471 - [11/12/13/14 Regression] ICE in gfc_typenode_for_spec, at fortran/trans-types.c:1114 To: Harald Anlauf Cc: gcc-patches , fortran Content-Type: multipart/alternative; boundary="0000000000004e2a7b061682832d" X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000004e2a7b061682832d Content-Type: text/plain; charset="UTF-8" Hi Harald, > > the patch is OK, but I had to manually fix it. I wonder how you managed > to produce: > Yes, I had to use --whitespace fix when I reapplied it a few minutes ago. > > diff --git a/gcc/testsuite/gfortran.dg/pr93484.f90 > I had followed comment 1 in the PR and wrongly named the file because of it. Now corrected. > > subroutine sub > implicit none > real, external :: x > real :: y(10) > integer :: kk > print *, [real(x(k))] > ! print *, [real(y(k))] > end > This is another problem, somewhere upstream from resolve.cc, which I have just spent an hour failing to find. In the presence of both print statements, in no matter which order, it is the error in trans-decl.cc that applies. > Thus I have the impression that the testcase tests something different > on the one hand, and on the other I wonder if we would want to change > the error message and replace "no default type" to "no IMPLICIT type". > It still would not hit the fuzzy check, but that is something that > might not be important now. > The fuzzy check was intended to ensure that the error was being detected in the "right" place. I want to keep the "no default type" message for the time being at least so as to identify exactly where it comes from. Getting to trans-decl.cc with an unknown type is just wrong. I'll come back to you on this. Thanks for the report. Paul --0000000000004e2a7b061682832d--