From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77649 invoked by alias); 1 Oct 2018 10:19:04 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 77601 invoked by uid 89); 1 Oct 2018 10:19:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2153, dominiqlpsensfr, dominiq@lps.ens.fr, H*f:sk:z9MOhAK X-HELO: mail-yb1-f172.google.com Received: from mail-yb1-f172.google.com (HELO mail-yb1-f172.google.com) (209.85.219.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Oct 2018 10:19:00 +0000 Received: by mail-yb1-f172.google.com with SMTP id o63-v6so5366283yba.2 for ; Mon, 01 Oct 2018 03:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=z4AdHHVnvxYU9va+9axn6Qwc5ZNCjQMUt9xBFrMADMs=; b=hNJ86zsrFxX7Yl/hVjuAWinNmCwzlENQXPiGzDFpbqw49mv5ysjnpmQ2+tNC9qeOkF tlSoVNOCnpImmMUcCQV2DNrsDBjFL0UCZ1eqtcZOGlyEeROaLiL02/LNq2kULINwavJp szsrNLBLWH1icVcIj0YyXhR0SfqdbI5Urofo5bRSj3kh2/xJXHpUkwRcOdHhhb2f/OuS y8Hoh2p0KjXuOkBp38zLTJf6gxfsqEo/ScweUCWCWQQ4mvN9J4LuekAZW38sWPqPRiLN agICidQIhFxGnkKiWx4ihEL0ZNjbgK8PlNKacrT2akq4cROoNnMlwA4VJgd/CM6upggV 8eyw== MIME-Version: 1.0 References: <9E853743-7B5F-4EE8-8B22-4C1C94E024BD@lps.ens.fr> In-Reply-To: From: Paul Richard Thomas Date: Mon, 01 Oct 2018 10:19:00 -0000 Message-ID: Subject: Re: [Patch, fortran] PR65677 - Incomplete assignment on deferred-length character variable To: Dominique Dhumieres Cc: "fortran@gcc.gnu.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00001.txt.bz2 The attached fix breaks the very thing that I set out to fix in the first place. I'm working on it. Paul On Mon, 1 Oct 2018 at 08:54, Paul Richard Thomas wrote: > > Hi Dominique, > > I seem to have got the wrong PR number right from the moment that I > created the directory for it and kept copying it thereafter - > apologies, I will put it right. > > As to the regression, the fix is simple and is attached. I had quite > forgotten about that assertion, which I am not very convinced is > necessary. > > Many thanks for alerting me to these problems. > > Paul > > On Sun, 30 Sep 2018 at 18:16, Dominique d'Humi=C3=A8res wrote: > > > > Hi Paul, > > > > First your patch has been committed with wrong entry: 65667 instead of = 65677. > > > > Second, I suspect it is responsible of the following ICE: > > > > % gfc pr72755.f90 -fno-range-check > > pr72755.f90:1485:0: > > > > 1485 | this%buffer =3D transfer( c(start:iend), this%buffer ) > > | > > internal compiler error: in gfc_dep_resolver, at fortran/dependency.c:2= 257 > > > > and > > > > % gfc pr64125_db.f90 > > pr64125_db.f90:20:0: > > > > 20 | left%chars =3D transfer( right, left%chars ) > > | > > internal compiler error: in gfc_dep_resolver, at fortran/dependency.c:2= 257 > > > > for > > > > module test > > type t_string > > private > > character(len=3D:), allocatable :: chars > > end type t_string > > > > contains > > > > pure subroutine string_assign_from_array( left, right ) > > > > ! The target string > > type(t_string), intent(out) :: left > > > > ! The source string > > character, dimension(:), intent(in) :: right > > > > > > ! Copy memory > > allocate( character(len=3Dsize(right)) :: left%chars ) > > left%chars =3D transfer( right, left%chars ) > > > > end subroutine string_assign_from_array > > > > end module test > > > > Cheers, > > > > Dominique > > > > > -- > "If you can't explain it simply, you don't understand it well enough" > - Albert Einstein --=20 "If you can't explain it simply, you don't understand it well enough" - Albert Einstein