From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 584CF3850410 for ; Wed, 6 Jan 2021 20:24:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 584CF3850410 Received: by mail-lf1-x134.google.com with SMTP id m12so9471798lfo.7 for ; Wed, 06 Jan 2021 12:24:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gL4ywRo5boJ8igzQVn+UkB9Uo9A4SWSbaq1rLa4iYTA=; b=p5RgoGx7dHBcJv/w3ugePKTBwoMFDsGT5g+KbqfxDC0aDcoRDgcNjd9K4lO9qaTOkh 0RDrTqtK9RQV3C6wxCrrP0Vz3oELp/R/xnJuRR1FGFwhiHqY6kaUnWmYOvbK8k7v3pNc dx18yWumw9ieLJoOC0xYL5ibcMLy3QNBpkZv3c0cy8kQ0v7Uaf71DpPGrBDnQXlB7PPk mMJp7hEctbV0Qz9kBYeaPpd/Jmm2UYHXM1pBrppMWwCUroFbAV0oSZi9Klcn0ppO7QWJ nWQD5+TuZk5hWM4/m/Mfi+RrKPTCWrvIVcrqbcrAo4zJWEvNdFN6/CrEkXLtD4enwmdQ AfVA== X-Gm-Message-State: AOAM5324nt45Rozf0UL+bUz9noZQIcSiie26PZQMFeBIzMhQ4C8JFBpa ihioHL4NYzR6UsMsrepDlbtnZcRBymY0KTuKhKt19nfToSPwcQ== X-Google-Smtp-Source: ABdhPJxWeNM2+lbCkVHzItR7i1ms4P5IFbRAOGtVPglOuOSWINzLESqspw5hwILr62o/aQV2q/Cu5kEoOsRT8oGBYE8= X-Received: by 2002:a19:7d2:: with SMTP id 201mr2445306lfh.518.1609964693953; Wed, 06 Jan 2021 12:24:53 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Wed, 6 Jan 2021 20:24:42 +0000 Message-ID: Subject: Re: [Patch, fortran] PR96320 - gfortran 8-10 shape mismatch in assumed-length dummy argument character array To: "fortran@gcc.gnu.org" Content-Type: multipart/mixed; boundary="000000000000af48a605b8411de2" X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2021 20:24:57 -0000 --000000000000af48a605b8411de2 Content-Type: text/plain; charset="UTF-8" Sorry, the testcases were left off. Paul On Wed, 6 Jan 2021 at 20:23, Paul Richard Thomas < paul.richard.thomas@gmail.com> wrote: > This patch fixes the problems in comments 23 and 24 of the PR. > > Comment 23 is fixed by the chunk in expr.c. The chunks in decl.c and > resolve.c fix #24. To be quite honest, I am not sure why they were not > needed in the first place! However, the changes don't cause any problems. > Removing the interface bodies causes the expected error cascade. > > Regtests on FC33/x86_64 - OK for master and, after a decent delay 9- and > 10- branches? > > Paul > > Fortran: This patch fixes comments 23 and 24 of PR96320. > > 2021-01-06 Paul Thomas > > gcc/fortran > PR fortran/96320 > * decl.c (gfc_match_modproc): It is not an error to find a > module procedure declaration within a contains block. > * expr.c (gfc_check_vardef_context): Pure procedure result is > assignable. Change 'own_scope' accordingly. > * resolve.c (resolve_typebound_procedure): A procedure that > has the module procedure attribute is almost certainly a > module procedure, whatever its interface. > > gcc/testsuite/ > PR fortran/96320 > * gfortran.dg/module_procedure_5.f90 : New test. > * gfortran.dg/module_procedure_6.f90 : New test. > --000000000000af48a605b8411de2 Content-Type: text/x-fortran; charset="UTF-8"; name="module_procedure_5.f90" Content-Disposition: attachment; filename="module_procedure_5.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjlveh7i0 ISB7IGRnLWRvIGNvbXBpbGUgfQohCiEgVGVzdCB0aGUgZml4IGZvciB0aGUgdGVzdGNhc2UgaW4g Y29tbWVudCAyMyBvZiBQUjk2MzIwLCB3aGljaCB1c2VkIHRvCiEgZmFpbCB3aXRoIHRoZSBtZXNz YWdlOiBWYXJpYWJsZSDigJhuZXdfZm9v4oCZIGNhbm5vdCBhcHBlYXIgaW4gYSB2YXJpYWJsZQoh IGRlZmluaXRpb24gY29udGV4dC4KIQohIENvbnRyaWJ1dGVkIGJ5IERhbWlhbiBSb3Vzb24gIDxk YW1pYW5Ac291cmNlcnlpbnN0aXR1dGUub3JnPgohCm1vZHVsZSBmb29iYXIKICBpbXBsaWNpdCBu b25lCgogIHR5cGUgZm9vCiAgICBpbnRlZ2VyIGJhcgogIGVuZCB0eXBlCgogIGludGVyZmFjZQog ICAgcHVyZSBtb2R1bGUgZnVuY3Rpb24gY3JlYXRlKCkgcmVzdWx0KG5ld19mb28pCiAgICAgIGlt cGxpY2l0IG5vbmUKICAgICAgdHlwZShmb28pIG5ld19mb28KICAgIGVuZCBmdW5jdGlvbgogIGVu ZCBpbnRlcmZhY2UKCmNvbnRhaW5zCiAgbW9kdWxlIHByb2NlZHVyZSBjcmVhdGUKICAgIG5ld19m b28lYmFyID0gMSAgISBFcnJvciBoZXJlCiAgZW5kIHByb2NlZHVyZQplbmQgbW9kdWxlCgogIHVz ZSBmb29iYXIKICBwcmludCAqLCBjcmVhdGUgKCkKZW5kCg== --000000000000af48a605b8411de2 Content-Type: text/x-fortran; charset="UTF-8"; name="module_procedure_6.f90" Content-Disposition: attachment; filename="module_procedure_6.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjlveh7s1 ISB7IGRnLWRvIHJ1biB9CiEKISBUZXN0IHRoZSBmaXggZm9yIHRoZSB0ZXN0Y2FzZSBpbiBjb21t ZW50IDI0IG9mIFBSOTYzMjAsIHdoaWNoIHVzZWQgdG8KISBmYWlsIHdpdGggdGhlIG1lc3NhZ2U6 IOKAmHNldF91c2VyX2RlZmluZWTigJkgbXVzdCBiZSBhIG1vZHVsZSBwcm9jZWR1cmUgb3IKISBh biBleHRlcm5hbCBwcm9jZWR1cmUgd2l0aCBhbiBleHBsaWNpdCBpbnRlcmZhY2UgYXQgKDEpCiEK ISBDb250cmlidXRlZCBieSBEYW1pYW4gUm91c29uICA8ZGFtaWFuQHNvdXJjZXJ5aW5zdGl0dXRl Lm9yZz4KIQptb2R1bGUgaG9sZV9pbnRlcmZhY2UKICB0eXBlIGhvbGVfdAogICAgaW50ZWdlciA6 OiB1c2VyX2RlZmluZWQKICAgIHJlYWwgOjogaG9sZV9kaWFtZXRlcgogIGNvbnRhaW5zCiAgICBw cm9jZWR1cmUgc2V0X3VzZXJfZGVmaW5lZAogICAgcHJvY2VkdXJlIHNldF9kaWFtZXRlcgogIGVu ZCB0eXBlCgogIGludGVyZmFjZQogICAgbW9kdWxlIHN1YnJvdXRpbmUgc2V0X2RpYW1ldGVyICh0 aGlzLCBkaWFtZXRlcikKICAgICAgY2xhc3MoaG9sZV90KSA6OiB0aGlzCiAgICAgIHJlYWwgOjog ZGlhbWV0ZXIKICAgIGVuZCBzdWJyb3V0aW5lCgogICAgbW9kdWxlIHN1YnJvdXRpbmUgc2V0X3Vz ZXJfZGVmaW5lZCh0aGlzLCB1c2VyX2RlZmluZWQpCiAgICAgIGNsYXNzKGhvbGVfdCkgOjogdGhp cwogICAgICBpbnRlZ2VyIDo6IHVzZXJfZGVmaW5lZAogICAgZW5kIHN1YnJvdXRpbmUKICBlbmQg aW50ZXJmYWNlCgpjb250YWlucwogIG1vZHVsZSBwcm9jZWR1cmUgc2V0X3VzZXJfZGVmaW5lZAog ICAgdGhpcyV1c2VyX2RlZmluZWQgPSB1c2VyX2RlZmluZWQKICBlbmQgcHJvY2VkdXJlCgogIG1v ZHVsZSBwcm9jZWR1cmUgc2V0X2RpYW1ldGVyCiAgICB0aGlzJWhvbGVfZGlhbWV0ZXIgPSBkaWFt ZXRlcgogICAgaWYgKHRoaXMldXNlcl9kZWZpbmVkIC5sdC4gMCkgdGhlbgogICAgICBjYWxsIHRo aXMlc2V0X3VzZXJfZGVmaW5lZCAoMCkKICAgIGVuZCBpZgogIGVuZCBwcm9jZWR1cmUKZW5kIG1v ZHVsZQoKICB1c2UgaG9sZV9pbnRlcmZhY2UgISBFcnJvciB3YXMgaGVyZQogIHR5cGUgKGhvbGVf dCkgOjogaHQgPSBob2xlX3QgKC0xLCAwLjApCiAgY2FsbCBodCVzZXRfZGlhbWV0ZXIoMS4wKQog IGlmICgoaHQldXNlcl9kZWZpbmVkIC5uZS4gMCkgLmFuZC4gKGh0JWhvbGVfZGlhbWV0ZXIgLm5l LiAxLjApKSBzdG9wIDEKICBjYWxsIGh0JXNldF91c2VyX2RlZmluZWQgKDUpCiAgaWYgKChodCV1 c2VyX2RlZmluZWQgLm5lLiA1KSAuYW5kLiAoaHQlaG9sZV9kaWFtZXRlciAubmUuIDEuMCkpIHN0 b3AgMgogIGNhbGwgaHQlc2V0X2RpYW1ldGVyKDIuMCkKICBpZiAoKGh0JXVzZXJfZGVmaW5lZCAu bmUuIDUpIC5hbmQuIChodCVob2xlX2RpYW1ldGVyIC5uZS4gMi4wKSkgc3RvcCAzCmVuZAo= --000000000000af48a605b8411de2--