From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id AA3C53840C1D for ; Fri, 15 Jan 2021 09:03:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AA3C53840C1D Received: by mail-lf1-x131.google.com with SMTP id a12so12109536lfl.6 for ; Fri, 15 Jan 2021 01:03:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j81fuTvccdA5z2UwDUNhIh4+QrzKHA+y+t2EFy5xbQo=; b=r8s43HzxNmv8+Vm7W1aXGxCATftcLkv/1V7ozHunHvllhG6lg61hZWBZPueFI2Cev4 5nahBJ2et/ma+KgDo1OVyfjRQbaiIX7KLVsr+S2HYeEktLydiC3iIiNAyKDcMaL4j3P6 gHX/53dBblW8sYOLwlTOOzJO+b8XOJ6gVlBFUp6i15jcdSugZ3fYSlYMtR5aSDxc41JL FCi+oFGMOpVm418QP4EneEsv6j94DyKEGrA2h+SQmKpbhj3Nyj2bZMRTlcfVqPXR0w6r 0/AaB2EXNMoW4OnYzZZtgqQFHPJXXOnp0h8NVn0PRVkqXyfL+Nv8ZvTwrOe0b9nWqiqA GD5w== X-Gm-Message-State: AOAM530FXDx9Qt5gMVt5BEfnmoMwmMxybTz3+i8Cd8rn+9F+BzYOGQky UU4oIAWx1tsVqo2tnCCJ/HbXCKbZIjkIqK0TsNCywU6RWfb+aw== X-Google-Smtp-Source: ABdhPJzVBQ1Ti4GsB38nUvTsRfmAKyE+0I4ICikkaf0lXld834d0Qtnhi+2TVWVzjpEL8/4XKxTFVHI7G5N7D1DnL5U= X-Received: by 2002:a05:6512:3090:: with SMTP id z16mr5566112lfd.44.1610701417243; Fri, 15 Jan 2021 01:03:37 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul Richard Thomas Date: Fri, 15 Jan 2021 09:03:26 +0000 Message-ID: Subject: Un-Ping: [Patch, fortran] PR96320 - gfortran 8-10 shape mismatch in assumed-length dummy argument character array To: "fortran@gcc.gnu.org" Content-Type: multipart/mixed; boundary="000000000000d0817205b8eca51a" X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2021 09:03:40 -0000 --000000000000d0817205b8eca51a Content-Type: text/plain; charset="UTF-8" Thomas points out that the attachments went AWOL - apologies. This patch fixes the problems in comments 23 and 24 of the PR. Comment 23 is fixed by the chunk in expr.c. The chunks in decl.c and resolve.c fix #24. To be quite honest, I am not sure why they were not needed in the first place! However, the changes don't cause any problems. Removing the interface bodies causes the expected error cascade. Regtests on FC33/x86_64 - OK for master and, after a decent delay 9- and 10- branches? Paul Fortran: This patch fixes comments 23 and 24 of PR96320. 2021-01-15 Paul Thomas gcc/fortran PR fortran/96320 * decl.c (gfc_match_modproc): It is not an error to find a module procedure declaration within a contains block. * expr.c (gfc_check_vardef_context): Pure procedure result is assignable. Change 'own_scope' accordingly. * resolve.c (resolve_typebound_procedure): A procedure that has the module procedure attribute is almost certainly a module procedure, whatever its interface. gcc/testsuite/ PR fortran/96320 * gfortran.dg/module_procedure_5.f90 : New test. * gfortran.dg/module_procedure_6.f90 : New test. --000000000000d0817205b8eca51a Content-Type: text/x-patch; charset="US-ASCII"; name="submit2.diff" Content-Disposition: attachment; filename="submit2.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjy20cmn0 ZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL2RlY2wuYyBiL2djYy9mb3J0cmFuL2RlY2wuYwppbmRl eCA0NzcxYjU5MWYxYS4uNzIzOTE1ODIyZjMgMTAwNjQ0Ci0tLSBhL2djYy9mb3J0cmFuL2RlY2wu YworKysgYi9nY2MvZm9ydHJhbi9kZWNsLmMKQEAgLTk4NTYsNyArOTg1Niw4IEBAIGdmY19tYXRj aF9tb2Rwcm9jICh2b2lkKQogICBnZmNfbmFtZXNwYWNlICptb2R1bGVfbnM7CiAgIGdmY19pbnRl cmZhY2UgKm9sZF9pbnRlcmZhY2VfaGVhZCwgKmludGVyZmFjZTsKIAotICBpZiAoZ2ZjX3N0YXRl X3N0YWNrLT5zdGF0ZSAhPSBDT01QX0lOVEVSRkFDRQorICBpZiAoKGdmY19zdGF0ZV9zdGFjay0+ c3RhdGUgIT0gQ09NUF9JTlRFUkZBQ0UKKyAgICAgICAmJiBnZmNfc3RhdGVfc3RhY2stPnN0YXRl ICE9IENPTVBfQ09OVEFJTlMpCiAgICAgICB8fCBnZmNfc3RhdGVfc3RhY2stPnByZXZpb3VzID09 IE5VTEwKICAgICAgIHx8IGN1cnJlbnRfaW50ZXJmYWNlLnR5cGUgPT0gSU5URVJGQUNFX05BTUVM RVNTCiAgICAgICB8fCBjdXJyZW50X2ludGVyZmFjZS50eXBlID09IElOVEVSRkFDRV9BQlNUUkFD VCkKZGlmZiAtLWdpdCBhL2djYy9mb3J0cmFuL2V4cHIuYyBiL2djYy9mb3J0cmFuL2V4cHIuYwpp bmRleCAxODhlNzk2NjljYi4uNGY0NTZmYzYyOWEgMTAwNjQ0Ci0tLSBhL2djYy9mb3J0cmFuL2V4 cHIuYworKysgYi9nY2MvZm9ydHJhbi9leHByLmMKQEAgLTYyNDMsNiArNjI0Myw5IEBAIGdmY19j aGVja192YXJkZWZfY29udGV4dCAoZ2ZjX2V4cHIqIGUsIGJvb2wgcG9pbnRlciwgYm9vbCBhbGxv Y19vYmosCiAKICAgLyogVmFyaWFibGUgbm90IGFzc2lnbmFibGUgZnJvbSBhIFBVUkUgcHJvY2Vk dXJlIGJ1dCBhcHBlYXJzIGluCiAgICAgIHZhcmlhYmxlIGRlZmluaXRpb24gY29udGV4dC4gICov CisgIG93bl9zY29wZSA9IG93bl9zY29wZQorCSAgICAgIHx8IChzeW0tPmF0dHIucmVzdWx0ICYm IHN5bS0+bnMtPnByb2NfbmFtZQorCQkgICYmIHN5bSA9PSBzeW0tPm5zLT5wcm9jX25hbWUtPnJl c3VsdCk7CiAgIGlmICghcG9pbnRlciAmJiAhb3duX3Njb3BlICYmIGdmY19wdXJlIChOVUxMKSAm JiBnZmNfaW1wdXJlX3ZhcmlhYmxlIChzeW0pKQogICAgIHsKICAgICAgIGlmIChjb250ZXh0KQpk aWZmIC0tZ2l0IGEvZ2NjL2ZvcnRyYW4vcmVzb2x2ZS5jIGIvZ2NjL2ZvcnRyYW4vcmVzb2x2ZS5j CmluZGV4IGZhNmY3NTZkMjg1Li4yY2IwMDlmOGNlZiAxMDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4v cmVzb2x2ZS5jCisrKyBiL2djYy9mb3J0cmFuL3Jlc29sdmUuYwpAQCAtMTQwMTYsNyArMTQwMTYs OCBAQCByZXNvbHZlX3R5cGVib3VuZF9wcm9jZWR1cmUgKGdmY19zeW10cmVlKiBzdHJlZSkKICAg ICAgIC8qIENoZWNrIGZvciBGMDg6QzQ2NS4gICovCiAgICAgICBpZiAoKCFwcm9jLT5hdHRyLnN1 YnJvdXRpbmUgJiYgIXByb2MtPmF0dHIuZnVuY3Rpb24pCiAJICB8fCAocHJvYy0+YXR0ci5wcm9j ICE9IFBST0NfTU9EVUxFCi0JICAgICAgJiYgcHJvYy0+YXR0ci5pZl9zb3VyY2UgIT0gSUZTUkNf SUZCT0RZKQorCSAgICAgICYmIHByb2MtPmF0dHIuaWZfc291cmNlICE9IElGU1JDX0lGQk9EWQor CSAgICAgICYmICFwcm9jLT5hdHRyLm1vZHVsZV9wcm9jZWR1cmUpCiAJICB8fCBwcm9jLT5hdHRy LmFic3RyYWN0KQogCXsKIAkgIGdmY19lcnJvciAoIiVxcyBtdXN0IGJlIGEgbW9kdWxlIHByb2Nl ZHVyZSBvciBhbiBleHRlcm5hbCAiCg== --000000000000d0817205b8eca51a Content-Type: text/x-fortran; charset="UTF-8"; name="module_procedure_6.f90" Content-Disposition: attachment; filename="module_procedure_6.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjy20q1k1 ISB7IGRnLWRvIHJ1biB9CiEKISBUZXN0IHRoZSBmaXggZm9yIHRoZSB0ZXN0Y2FzZSBpbiBjb21t ZW50IDI0IG9mIFBSOTYzMjAsIHdoaWNoIHVzZWQgdG8KISBmYWlsIHdpdGggdGhlIG1lc3NhZ2U6 IOKAmHNldF91c2VyX2RlZmluZWTigJkgbXVzdCBiZSBhIG1vZHVsZSBwcm9jZWR1cmUgb3IKISBh biBleHRlcm5hbCBwcm9jZWR1cmUgd2l0aCBhbiBleHBsaWNpdCBpbnRlcmZhY2UgYXQgKDEpCiEK ISBDb250cmlidXRlZCBieSBEYW1pYW4gUm91c29uICA8ZGFtaWFuQHNvdXJjZXJ5aW5zdGl0dXRl Lm9yZz4KIQptb2R1bGUgaG9sZV9pbnRlcmZhY2UKICB0eXBlIGhvbGVfdAogICAgaW50ZWdlciA6 OiB1c2VyX2RlZmluZWQKICAgIHJlYWwgOjogaG9sZV9kaWFtZXRlcgogIGNvbnRhaW5zCiAgICBw cm9jZWR1cmUgc2V0X3VzZXJfZGVmaW5lZAogICAgcHJvY2VkdXJlIHNldF9kaWFtZXRlcgogIGVu ZCB0eXBlCgogIGludGVyZmFjZQogICAgbW9kdWxlIHN1YnJvdXRpbmUgc2V0X2RpYW1ldGVyICh0 aGlzLCBkaWFtZXRlcikKICAgICAgY2xhc3MoaG9sZV90KSA6OiB0aGlzCiAgICAgIHJlYWwgOjog ZGlhbWV0ZXIKICAgIGVuZCBzdWJyb3V0aW5lCgogICAgbW9kdWxlIHN1YnJvdXRpbmUgc2V0X3Vz ZXJfZGVmaW5lZCh0aGlzLCB1c2VyX2RlZmluZWQpCiAgICAgIGNsYXNzKGhvbGVfdCkgOjogdGhp cwogICAgICBpbnRlZ2VyIDo6IHVzZXJfZGVmaW5lZAogICAgZW5kIHN1YnJvdXRpbmUKICBlbmQg aW50ZXJmYWNlCgpjb250YWlucwogIG1vZHVsZSBwcm9jZWR1cmUgc2V0X3VzZXJfZGVmaW5lZAog ICAgdGhpcyV1c2VyX2RlZmluZWQgPSB1c2VyX2RlZmluZWQKICBlbmQgcHJvY2VkdXJlCgogIG1v ZHVsZSBwcm9jZWR1cmUgc2V0X2RpYW1ldGVyCiAgICB0aGlzJWhvbGVfZGlhbWV0ZXIgPSBkaWFt ZXRlcgogICAgaWYgKHRoaXMldXNlcl9kZWZpbmVkIC5sdC4gMCkgdGhlbgogICAgICBjYWxsIHRo aXMlc2V0X3VzZXJfZGVmaW5lZCAoMCkKICAgIGVuZCBpZgogIGVuZCBwcm9jZWR1cmUKZW5kIG1v ZHVsZQoKICB1c2UgaG9sZV9pbnRlcmZhY2UgISBFcnJvciB3YXMgaGVyZQogIHR5cGUgKGhvbGVf dCkgOjogaHQgPSBob2xlX3QgKC0xLCAwLjApCiAgY2FsbCBodCVzZXRfZGlhbWV0ZXIoMS4wKQog IGlmICgoaHQldXNlcl9kZWZpbmVkIC5uZS4gMCkgLmFuZC4gKGh0JWhvbGVfZGlhbWV0ZXIgLm5l LiAxLjApKSBzdG9wIDEKICBjYWxsIGh0JXNldF91c2VyX2RlZmluZWQgKDUpCiAgaWYgKChodCV1 c2VyX2RlZmluZWQgLm5lLiA1KSAuYW5kLiAoaHQlaG9sZV9kaWFtZXRlciAubmUuIDEuMCkpIHN0 b3AgMgogIGNhbGwgaHQlc2V0X2RpYW1ldGVyKDIuMCkKICBpZiAoKGh0JXVzZXJfZGVmaW5lZCAu bmUuIDUpIC5hbmQuIChodCVob2xlX2RpYW1ldGVyIC5uZS4gMi4wKSkgc3RvcCAzCmVuZAo= --000000000000d0817205b8eca51a Content-Type: text/x-fortran; charset="UTF-8"; name="module_procedure_5.f90" Content-Disposition: attachment; filename="module_procedure_5.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjy20q1x2 ISB7IGRnLWRvIGNvbXBpbGUgfQohCiEgVGVzdCB0aGUgZml4IGZvciB0aGUgdGVzdGNhc2UgaW4g Y29tbWVudCAyMyBvZiBQUjk2MzIwLCB3aGljaCB1c2VkIHRvCiEgZmFpbCB3aXRoIHRoZSBtZXNz YWdlOiBWYXJpYWJsZSDigJhuZXdfZm9v4oCZIGNhbm5vdCBhcHBlYXIgaW4gYSB2YXJpYWJsZQoh IGRlZmluaXRpb24gY29udGV4dC4KIQohIENvbnRyaWJ1dGVkIGJ5IERhbWlhbiBSb3Vzb24gIDxk YW1pYW5Ac291cmNlcnlpbnN0aXR1dGUub3JnPgohCm1vZHVsZSBmb29iYXIKICBpbXBsaWNpdCBu b25lCgogIHR5cGUgZm9vCiAgICBpbnRlZ2VyIGJhcgogIGVuZCB0eXBlCgogIGludGVyZmFjZQog ICAgcHVyZSBtb2R1bGUgZnVuY3Rpb24gY3JlYXRlKCkgcmVzdWx0KG5ld19mb28pCiAgICAgIGlt cGxpY2l0IG5vbmUKICAgICAgdHlwZShmb28pIG5ld19mb28KICAgIGVuZCBmdW5jdGlvbgogIGVu ZCBpbnRlcmZhY2UKCmNvbnRhaW5zCiAgbW9kdWxlIHByb2NlZHVyZSBjcmVhdGUKICAgIG5ld19m b28lYmFyID0gMSAgISBFcnJvciBoZXJlCiAgZW5kIHByb2NlZHVyZQplbmQgbW9kdWxlCgogIHVz ZSBmb29iYXIKICBwcmludCAqLCBjcmVhdGUgKCkKZW5kCg== --000000000000d0817205b8eca51a Content-Type: text/x-fortran; charset="US-ASCII"; name="module_procedure_4.f90" Content-Disposition: attachment; filename="module_procedure_4.f90" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjy20q2c3 ISB7IGRnLWRvIHJ1biB9CiEKISBUZXN0IHRoZSBmaXggZm9yIFBSOTYzMjAgaW4gd2hpY2ggdGhl IGFzc3VtZWQgc2hhcGUgb2YgJ2FyZycgaW4gdGhlCiEgaW50ZXJmYWNlIGZvciAnYmFyJyB3YXMg bWlycm9yZWQgYnkgdGhlICdhcmcnIGluIHRoZSBtb2R1bGUgcHJvY2VkdXJlCiEgaW5jb3JyZWN0 bHkgaGF2ZSBkZWZlcnJlZCBzaGFwZS4KIQohIENvbnRyaWJ1dGVkIGJ5IERhbWlhbiBSb3Vzb24g IDxkYW1pYW5Ac291cmNlcnlpbnN0aXR1dGUub3JnPgohCm1vZHVsZSBmb29iYXIKICB0eXBlIGZv bwogIGNvbnRhaW5zCiAgICBwcm9jZWR1cmUsIG5vcGFzcyA6OiBiYXIxCiAgICBwcm9jZWR1cmUs IG5vcGFzcyA6OiBiYXIyCiAgICBwcm9jZWR1cmUsIG5vcGFzcyA6OiBiYXIzCiAgZW5kIHR5cGUK CiAgaW50ZXJmYWNlCgogICAgbW9kdWxlIHN1YnJvdXRpbmUgYmFyMShhcmcpCiAgICAgIGNoYXJh Y3RlcihsZW49KikgYXJnKDopCiAgICBlbmQgc3Vicm91dGluZQoKICAgIG1vZHVsZSBzdWJyb3V0 aW5lIGJhcjIoYXJnKQogICAgICBjaGFyYWN0ZXIobGVuPSopIGFyZygzOikKICAgIGVuZCBzdWJy b3V0aW5lCgogICAgbW9kdWxlIHN1YnJvdXRpbmUgYmFyMyhhcmcpCiAgICAgIGNoYXJhY3Rlcihs ZW49KikgYXJnKDIpCiAgICBlbmQgc3Vicm91dGluZQoKICBlbmQgaW50ZXJmYWNlCmNvbnRhaW5z CgogIG1vZHVsZSBwcm9jZWR1cmUgYmFyMQogICAgaWYgKGxib3VuZChhcmcsIDEpIC5uZS4gMSkg c3RvcCAxCiAgICBpZiAoYXJnKDMpIC5uZS4gJ2hpamsnKSBzdG9wIDIKICBlbmQgcHJvY2VkdXJl CgohIE1ha2Ugc3VyZSB0aGF0IHRoZSBsb3dlciBib3VuZCBvZiBhbiBhc3N1bWVkIHNoYXBlIGFy cmF5IGR1bW15LAohIGlmIGRlZmluZWQsIGlzIHBhc3NlZCB0byB0aGUgbW9kdWxlIHByb2NlZHVy ZS4KCiAgbW9kdWxlIHByb2NlZHVyZSBiYXIyCiAgICBpZiAobGJvdW5kKGFyZywgMSkgLm5lLiAz KSBzdG9wIDMKICAgIGlmIChhcmcoMykgLm5lLiAnYWJjZCcpIHN0b3AgNAogIGVuZCBwcm9jZWR1 cmUKCiEgVGhpcyBtYWtlcyBzdXJlIHRoYXQgYW4gZHVtbXkgd2l0aCBleHBsaWNpdCBzaGFwZSBo YXMgdGhlIHVwcGVyCiEgYm91bmQgY29ycmVjdGx5IHNldCBpbiB0aGUgbW9kdWxlIHByb2NlZHVy ZS4KCiAgbW9kdWxlIHByb2NlZHVyZSBiYXIzCiAgICBpZiAobGJvdW5kKGFyZywgMSkgLm5lLiAx KSBzdG9wIDUKICAgIGlmIChhcmcoMykgLm5lLiAnaGlqaycpIHN0b3AgNiAgICAgICAhIHsgZGct d2FybmluZyAiaXMgb3V0IG9mIGJvdW5kcyIgfQogIGVuZCBwcm9jZWR1cmUKCmVuZCBtb2R1bGUK CiAgdXNlIGZvb2JhcgogIGNoYXJhY3Rlcig0KSA6OiBsaXN0KDMpID0gWydhYmNkJywgJ2VmZ2gn ICwgJ2hpamsnXQogIHR5cGUoZm9vKSA6OiBmCiAgY2FsbCBmJWJhcjEobGlzdCkKICBjYWxsIGYl YmFyMihsaXN0KQogIGNhbGwgZiViYXIzKGxpc3QpCmVuZAo= --000000000000d0817205b8eca51a--