From: Paul Richard Thomas <paul.richard.thomas@gmail.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: Fix CLASS handling in SIZEOF intrinsic
Date: Wed, 9 Mar 2022 08:33:31 +0000 [thread overview]
Message-ID: <CAGkQGiLobogEMXiL06gBPynGnhhr8j9fBtHQNr-e98G-3zLVDg@mail.gmail.com> (raw)
In-Reply-To: <d053f97e-1c81-6ae2-4d03-347724ae82f7@codesourcery.com>
Hi Tobias,
Thanks for the patch and the particularly comprehensive testcase.
OK for mainline as far as I am concerned.
Paul
On Tue, 8 Mar 2022 at 20:06, Tobias Burnus <tobias@codesourcery.com> wrote:
> Fix SIZEOF handling.
>
> I have to admit that I do understand what the current code does,
> but do not understand what the previous code did. However, it
> still passes the testsuite - and also some code which did ICE
> now compiles :-)
>
> While writing the testcase, I did find two issues:
> * Passing a CLASS to TYPE(*),dimension(..) will have an
> elem_len of the declared type and not of the dynamic type.
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104844
> * var%class_array(1,1)%array will have size(...) == 0
> instead of size(... % array).
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104845
>
> OK for mainline? (Unless you want to hold off until GCC 13)
>
> Tobias
>
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201,
> 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer:
> Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München;
> Registergericht München, HRB 106955
>
--
"If you can't explain it simply, you don't understand it well enough" -
Albert Einstein
prev parent reply other threads:[~2022-03-09 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 20:06 Tobias Burnus
2022-03-09 8:33 ` Paul Richard Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGkQGiLobogEMXiL06gBPynGnhhr8j9fBtHQNr-e98G-3zLVDg@mail.gmail.com \
--to=paul.richard.thomas@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).