From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38050 invoked by alias); 15 Mar 2018 15:45:53 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 37980 invoked by uid 89); 15 Mar 2018 15:45:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-it0-f51.google.com Received: from mail-it0-f51.google.com (HELO mail-it0-f51.google.com) (209.85.214.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Mar 2018 15:45:49 +0000 Received: by mail-it0-f51.google.com with SMTP id w3-v6so9644741itc.4; Thu, 15 Mar 2018 08:45:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6rxBSIzmmSnobszzJJA9KOt+mNyspwCHP2WVE4sr8CM=; b=FA3P/RoQTnCjFlWkhabO90ynmXFgLsC4te1CYHyyXNRiYAAAgG+C85IZgCIrLiiY1d P+4nc63mSqERwlNDT0p9VNIvbuhdZdtHJ3nShQVh4VcKK0EacNJzpoi5DHvDDQGO63Xn 1IPZCReufdYNJhUK/1D5NYlL0SgI+2lxYjhmrC/A9zvUZuS8ohuWKLPIFN0AHFi3SjPQ uy/EP15i4iECxP0ZV7Il0rGGCKaYWZNpAeWVNKD7CtjfvjGNprxlqEgN8upuHFxodKz3 YWlKti8qxNtMSozuWxJCbVRxJbnZLNnw6FjIIK9sDNRif5J8vHp7qP6ZhvZfnj1uaX4K LRsg== X-Gm-Message-State: AElRT7G23kLfx2++xlhD5WvUqSYVDHr7FAWcYU/aLWid8W3NKWv4FU54 IpV/gy5FnnWhUr53AlgVXyZjTFJs8EcaXqgE+xc= X-Google-Smtp-Source: AG47ELugxoeUmxchgpEG0VD+ko+3WaCKLRDKU1a+7hVpAX3iXKjpY+/R7tQ4Q1b+j0tiINc9moT5McohURkqagjYvAY= X-Received: by 10.36.217.138 with SMTP id p132mr7054403itg.41.1521128748015; Thu, 15 Mar 2018 08:45:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.2.30.221 with HTTP; Thu, 15 Mar 2018 08:45:47 -0700 (PDT) In-Reply-To: <20180315150810.GS8577@tucnak> References: <20180312173706.GB61632@troutmask.apl.washington.edu> <20180313040809.GA69151@troutmask.apl.washington.edu> <20180314005722.GA43280@troutmask.apl.washington.edu> <20180315141026.GA57660@troutmask.apl.washington.edu> <20180315150810.GS8577@tucnak> From: "Bin.Cheng" Date: Thu, 15 Mar 2018 15:45:00 -0000 Message-ID: Subject: Re: [PATCH] Fortran -- clean up KILL To: Jakub Jelinek Cc: Steve Kargl , Richard Biener , Janne Blomqvist , Fortran List , GCC Patches Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2018-03/txt/msg00063.txt.bz2 On Thu, Mar 15, 2018 at 3:08 PM, Jakub Jelinek wrote: > On Thu, Mar 15, 2018 at 07:10:26AM -0700, Steve Kargl wrote: >> On Thu, Mar 15, 2018 at 01:35:23PM +0100, Richard Biener wrote: >> > > >> > > extern GFC_INTEGER_4 kill (GFC_INTEGER_4, GFC_INTEGER_4); >> > > extern __typeof(kill) kill __asm__("" "_gfortran_kill"); >> > >> > Why do you need to jump through these hoops anyway? Just do ... >> > >> >> Not sure who the "you" refers to. The easiest >> fix be appending a 4 to kill. I'll do that >> later. > > I think this is even easier, no need to rename anything: > > 2018-03-15 Jakub Jelinek > > PR libgfortran/84880 > * intrinsics/kill.c (kill): Rename to... > (PREFIX (kill)): ... this. Use export_proto_np instead of export_proto. > > --- libgfortran/intrinsics/kill.c.jj 2018-03-14 09:44:57.988975360 +0100 > +++ libgfortran/intrinsics/kill.c 2018-03-15 16:01:02.725668658 +0100 > @@ -51,11 +51,11 @@ kill_sub (GFC_INTEGER_4 pid, GFC_INTEGER > } > iexport(kill_sub); > > -extern GFC_INTEGER_4 kill (GFC_INTEGER_4, GFC_INTEGER_4); > -export_proto(kill); > +extern GFC_INTEGER_4 PREFIX (kill) (GFC_INTEGER_4, GFC_INTEGER_4); > +export_proto_np(PREFIX (kill)); > > GFC_INTEGER_4 > -kill (GFC_INTEGER_4 pid, GFC_INTEGER_4 signal) > +PREFIX (kill) (GFC_INTEGER_4 pid, GFC_INTEGER_4 signal) > { > int val; > val = (int)kill (pid, signal); Hi, FYI, both your patches fix the compilation issue. Thanks, bin > > > Jakub