From: "Bin.Cheng" <amker.cheng@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>,
Richard Biener <richard.guenther@gmail.com>,
Janne Blomqvist <blomqvist.janne@gmail.com>,
Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran -- clean up KILL
Date: Thu, 15 Mar 2018 15:57:00 -0000 [thread overview]
Message-ID: <CAHFci29Pa56r9P1VaVpDGkxOmtUXtaJNABnxbCAhe_amat8o=Q@mail.gmail.com> (raw)
In-Reply-To: <20180315155442.GT8577@tucnak>
On Thu, Mar 15, 2018 at 3:54 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Mar 15, 2018 at 03:45:47PM +0000, Bin.Cheng wrote:
>> FYI, both your patches fix the compilation issue.
>
> It isn't just a compilation problem, it really can't work at all.
> Without the patch, if the function builds, it looks like:
Ah, Thanks. I haven't checked generated code when it builds.
Thanks,
bin
> 00000000002308b0 <_gfortran_kill>:
> 2308b0: f3 0f 1e fa endbr64
> 2308b4: 48 83 ec 08 sub $0x8,%rsp
> 2308b8: e8 f3 ff ff ff callq 2308b0 <_gfortran_kill>
> 2308bd: 85 c0 test %eax,%eax
> 2308bf: 74 07 je 2308c8 <_gfortran_kill+0x18>
> 2308c1: e8 4a 92 de ff callq 19b10 <__errno_location@plt>
> 2308c6: 8b 00 mov (%rax),%eax
> 2308c8: 48 83 c4 08 add $0x8,%rsp
> 2308cc: c3 retq
> 2308cd: 0f 1f 00 nopl (%rax)
> i.e. there is endless recursion, it doesn't call the libc kill, but itself.
>
> Jakub
next prev parent reply other threads:[~2018-03-15 15:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-11 16:52 Steve Kargl
2018-03-11 20:16 ` Janne Blomqvist
2018-03-11 20:42 ` Steve Kargl
2018-03-12 16:56 ` Janne Blomqvist
2018-03-12 17:37 ` Steve Kargl
2018-03-12 19:05 ` Janne Blomqvist
2018-03-13 4:08 ` Steve Kargl
2018-03-13 19:49 ` Janne Blomqvist
2018-03-14 0:57 ` Steve Kargl
2018-03-15 10:18 ` Bin.Cheng
2018-03-15 12:11 ` Bin.Cheng
2018-03-15 12:20 ` Bin.Cheng
2018-03-15 15:07 ` Steve Kargl
2018-03-15 12:35 ` Richard Biener
2018-03-15 14:10 ` Steve Kargl
2018-03-15 16:35 ` Jakub Jelinek
2018-03-15 15:45 ` Bin.Cheng
2018-03-15 17:35 ` Jakub Jelinek
2018-03-15 15:57 ` Bin.Cheng [this message]
2018-03-15 16:28 ` Steve Kargl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHFci29Pa56r9P1VaVpDGkxOmtUXtaJNABnxbCAhe_amat8o=Q@mail.gmail.com' \
--to=amker.cheng@gmail.com \
--cc=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=richard.guenther@gmail.com \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).