From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3374 invoked by alias); 15 Dec 2015 13:28:58 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 3351 invoked by uid 89); 15 Dec 2015 13:28:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_40,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-io0-f179.google.com Received: from mail-io0-f179.google.com (HELO mail-io0-f179.google.com) (209.85.223.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 15 Dec 2015 13:28:56 +0000 Received: by mail-io0-f179.google.com with SMTP id o67so18795278iof.3; Tue, 15 Dec 2015 05:28:55 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.107.33.203 with SMTP id h194mr32239585ioh.108.1450186134082; Tue, 15 Dec 2015 05:28:54 -0800 (PST) Received: by 10.107.34.75 with HTTP; Tue, 15 Dec 2015 05:28:54 -0800 (PST) In-Reply-To: <566F1251.7060104@net-b.de> References: <566F1251.7060104@net-b.de> Date: Tue, 15 Dec 2015 13:28:00 -0000 Message-ID: Subject: Re: [Fortran, Patch} Fix ICE for coarray Critical inside module procedure From: Alessandro Fanfarillo To: Tobias Burnus Cc: gfortran , gcc-patches , opencoarrays@googlegroups.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00089.txt.bz2 Committed as revision 231649 on trunk and as revision 231650 on gcc-5-branch. Thanks. 2015-12-14 20:02 GMT+01:00 Tobias Burnus : > Dear Alessandro, > > Alessandro Fanfarillo wrote: >> >> the compiler returns an ICE when a coarray critical section is used >> inside a module procedure. >> The symbols related with the lock variables were left uncommitted >> inside resolve_critical(). A gfc_commit_symbol after each symbol or a >> gfc_commit_symbols at the end of resolve_critical() fixed the issue. >> >> The latter solution is proposed in the attached patch. >> Built and regtested on x86_64-pc-linux-gnu > > > Looks good to me. > >> PS: This patch should be also included in GCC 5. > > > Yes, that's fine with me. > > Tobias > > PS: I saw that you now have a GCC account, which you can use to commit to > both the trunk and gcc-5-branch. See https://gcc.gnu.org/svnwrite.html. > Additionally, you should update MAINTAINERS (trunk only) by adding yourself > under "Write After Approval"; you can simply commit this patch yourself, but > you should write an email to gcc-patches with the patch - like Alan did at > https://gcc.gnu.org/ml/gcc-patches/2015-10/msg02390.html