From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94576 invoked by alias); 10 Dec 2015 15:37:27 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 94554 invoked by uid 89); 10 Dec 2015 15:37:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-ig0-f181.google.com Received: from mail-ig0-f181.google.com (HELO mail-ig0-f181.google.com) (209.85.213.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 10 Dec 2015 15:37:25 +0000 Received: by igcto18 with SMTP id to18so17870935igc.0; Thu, 10 Dec 2015 07:37:23 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.50.18.114 with SMTP id v18mr36187189igd.34.1449761843803; Thu, 10 Dec 2015 07:37:23 -0800 (PST) Received: by 10.107.34.75 with HTTP; Thu, 10 Dec 2015 07:37:23 -0800 (PST) Date: Thu, 10 Dec 2015 15:37:00 -0000 Message-ID: Subject: [Fortran, Patch} Fix ICE for coarray Critical inside module procedure From: Alessandro Fanfarillo To: gfortran , gcc-patches , opencoarrays@googlegroups.com Content-Type: multipart/mixed; boundary=047d7b418403b6026e05268cfb2e X-IsSubscribed: yes X-SW-Source: 2015-12/txt/msg00073.txt.bz2 --047d7b418403b6026e05268cfb2e Content-Type: text/plain; charset=UTF-8 Content-length: 482 Dear all, the compiler returns an ICE when a coarray critical section is used inside a module procedure. The symbols related with the lock variables were left uncommitted inside resolve_critical(). A gfc_commit_symbol after each symbol or a gfc_commit_symbols at the end of resolve_critical() fixed the issue. The latter solution is proposed in the attached patch. Built and regtested on x86_64-pc-linux-gnu Cheers Alessandro PS: This patch should be also included in GCC 5. --047d7b418403b6026e05268cfb2e Content-Type: text/plain; charset=US-ASCII; name="critical.diff" Content-Disposition: attachment; filename="critical.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ii0er3x10 Content-length: 1708 MjAxNS0xMi0xMCAgQWxlc3NhbmRybyBGYW5mYXJpbGxvIDxmYW5mYXJpbGxv LmdjY0BnbWFpbC5jb20+CgoJKiByZXNvbHZlLmMgKHJlc29sdmVfY3JpdGlj YWwpOiBDb21taXR0aW5nIHN5bWJvbHMgb2YKCWxvY2sgdmFyaWFibGVzLgoK MjAxNS0xMi0xMCAgQWxlc3NhbmRybyBGYW5mYXJpbGxvIDxmYW5mYXJpbGxv LmdjY0BnbWFpbC5jb20+CgoJKiBnZm9ydHJhbi5kZy9jb2FycmF5X2NyaXRp Y2FsXzEuZjkwOiBOZXcuCgpjb21taXQgY2NjMDZhY2NiNDg5MWFiOTVkMzMx MzViNjJjNDc5ZDg5NWIyMjcwZgpBdXRob3I6IEFsZXNzYW5kcm8gRmFuZmFy aWxsbyA8ZmFuZmFyaWxsb0BpbmcudW5pcm9tYTIuaXQ+CkRhdGU6ICAgVGh1 IERlYyAxMCAxNToyODozMyAyMDE1ICswMDAwCgogICAgQ29tbWl0dGluZyBz eW1ib2xzIG9mIGxvY2sgdmFyaWFibGVzIGluc2lkZSByZXNvbHZlX2NyaXRp Y2FsKCkKCmRpZmYgLS1naXQgYS9nY2MvZm9ydHJhbi9yZXNvbHZlLmMgYi9n Y2MvZm9ydHJhbi9yZXNvbHZlLmMKaW5kZXggNjVhMmI3Zi4uMzk4OGIzYyAx MDA2NDQKLS0tIGEvZ2NjL2ZvcnRyYW4vcmVzb2x2ZS5jCisrKyBiL2djYy9m b3J0cmFuL3Jlc29sdmUuYwpAQCAtODg1Miw2ICs4ODUyLDcgQEAgcmVzb2x2 ZV9jcml0aWNhbCAoZ2ZjX2NvZGUgKmNvZGUpCiAgIHN5bXRyZWUtPm4uc3lt LT5hcy0+Y290eXBlID0gQVNfRVhQTElDSVQ7CiAgIHN5bXRyZWUtPm4uc3lt LT5hcy0+bG93ZXJbMF0gPSBnZmNfZ2V0X2ludF9leHByIChnZmNfZGVmYXVs dF9pbnRlZ2VyX2tpbmQsCiAJCQkJCQkgICBOVUxMLCAxKTsKKyAgZ2ZjX2Nv bW1pdF9zeW1ib2xzKCk7CiB9CiAKIApkaWZmIC0tZ2l0IGEvZ2NjL3Rlc3Rz dWl0ZS9nZm9ydHJhbi5kZy9jb2FycmF5X2NyaXRpY2FsXzEuZjkwIGIvZ2Nj L3Rlc3RzdWl0ZS9nZm9ydHJhbi5kZy9jb2FycmF5X2NyaXRpY2FsXzEuZjkw Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjRkOTNiZjYK LS0tIC9kZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2dmb3J0cmFuLmRn L2NvYXJyYXlfY3JpdGljYWxfMS5mOTAKQEAgLTAsMCArMSwxMiBAQAorISB7 IGRnLWRvIGNvbXBpbGUgfQorISB7IGRnLW9wdGlvbnMgIi1mY29hcnJheT1s aWIiIH0KKyEKKworbW9kdWxlIG0KKyBjb250YWlucworICAgc3Vicm91dGlu ZSBmKCkKKyAgICAgY3JpdGljYWwKKyAgICAgZW5kIGNyaXRpY2FsCisgICBl bmQgc3Vicm91dGluZSBmCisgZW5kIG1vZHVsZSBtCitlbmQgcHJvZ3JhbQo= --047d7b418403b6026e05268cfb2e--