From: Janus Weil <janus@gcc.gnu.org>
To: Arjen Markus <arjen.markus895@gmail.com>
Cc: Manfred Schwarb <manfred99@gmx.ch>, gfortran <fortran@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 57160: short-circuit IF only with -ffrontend-optimize
Date: Wed, 08 Aug 2018 20:48:00 -0000 [thread overview]
Message-ID: <CAKwh3qg98_UJyi3OmfnHBEKez1A3_-njyewgYwTLyLW0313fRw@mail.gmail.com> (raw)
In-Reply-To: <CAKwh3qhy0tsq3LoJdU-pYpUZhC1qLkr1gMoKLdWEuXQr7LkJow@mail.gmail.com>
2018-08-08 20:20 GMT+02:00 Janus Weil <janus@gcc.gnu.org>:
> Hi all,
>
> since there seems to be significant support for this after all, I just
> rebased the last patch version and pushed it to github (I sincerely
> hope gcc will officially make the switch to git very soon):
>
> https://github.com/janusw/gcc/commit/35aae880ff2b3d4a9f6a9c821376fb510202961c
>
> This is still the most reasonable approach I can see. And I'd still be
> grateful for (technical) comments on the patch.
>
> What's the procedure in GCC for dealing with such controversial
> patches? The procedure for simple cases is: The patch author asks for
> review, an authorized reviewer/maintainer approves it or asks for
> improvements. What happens if that fails? Is there any rule on how
> decisions are to be made in the non-trivial case?
Re-reading the thread, I noticed that I haven't actually gotten a
clear "yes" or "no" from anyone with review privileges for the Fortran
front-end.
So, I'll just continue with the usual procedure: The patch above
regtests cleanly on x86_64-linux-gnu and provides a clear improvement
regarding the standard-conformance of the GNU Fortan compiler. Ok to
commit to trunk?
Cheers,
Janus
next prev parent reply other threads:[~2018-08-08 20:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 16:42 Dominique d'Humières
2018-07-28 8:03 ` Janus Weil
2018-08-01 20:46 ` Janus Weil
2018-08-06 20:59 ` Janus Weil
2018-08-07 10:11 ` Dominique d'Humières
2018-08-07 17:14 ` Janus Weil
2018-08-07 22:21 ` Thomas König
2018-08-08 0:17 ` William Clodius
2018-08-08 5:41 ` Janus Weil
2018-08-08 8:35 ` Manfred Schwarb
2018-08-08 11:23 ` Janus Weil
2018-08-08 11:29 ` Arjen Markus
2018-08-08 18:21 ` Janus Weil
2018-08-08 20:48 ` Janus Weil [this message]
2018-08-09 1:05 ` Jerry DeLisle
2018-08-09 21:14 ` Janus Weil
2018-08-10 0:38 ` Jerry DeLisle
2018-08-10 14:14 ` Janus Weil
2018-08-08 19:50 ` Janus Weil
-- strict thread matches above, loose matches on Subject: below --
2018-07-24 9:12 Dominique d'Humières
2018-07-24 13:46 ` Janus Weil
2018-07-24 15:42 ` Janne Blomqvist
2018-07-24 16:18 ` Janus Weil
2018-07-20 21:38 Janus Weil
2018-07-23 7:40 ` Adam Hirst
2018-07-23 17:11 ` Janus Weil
2018-07-23 21:06 ` Fritz Reese
2018-07-24 18:46 ` Janus Weil
2018-07-24 19:49 ` Janus Weil
2018-07-24 19:50 ` Thomas Koenig
2018-07-24 20:14 ` Janus Weil
2018-07-25 20:05 ` Janus Weil
2018-07-25 20:59 ` Nicolas Koenig
2018-07-25 21:01 ` Thomas Koenig
2018-07-25 21:31 ` Janus Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwh3qg98_UJyi3OmfnHBEKez1A3_-njyewgYwTLyLW0313fRw@mail.gmail.com \
--to=janus@gcc.gnu.org \
--cc=arjen.markus895@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=manfred99@gmx.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).