public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Janus Weil <janus@gcc.gnu.org>
To: Richard Biener <rguenther@suse.de>
Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>,
	Jakub Jelinek <jakub@redhat.com>, 	gfortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90)
Date: Mon, 12 Feb 2018 17:14:00 -0000	[thread overview]
Message-ID: <CAKwh3qgEiNKVuW2mkFx8N1jcDEGDODwJYsnOjvmcUf+qkpFQSg@mail.gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.20.1802120822040.18265@zhemvz.fhfr.qr>

2018-02-12 8:22 GMT+01:00 Richard Biener <rguenther@suse.de>:
>> 2018-02-10 0:21 GMT+01:00 Steve Kargl <sgk@troutmask.apl.washington.edu>:
>> > On Fri, Feb 09, 2018 at 06:13:34PM +0100, Janus Weil wrote:
>> >>
>> >> the attached patch fixes some checking code for PASS arguments in
>> >> procedure-pointer components, which does not properly account for the
>> >> fact that the PASS argument needs to be polymorphic.
>> >>
>> >> [The reason for this issue is probably that PPCs were mostly
>> >> implemented before polymorphism was available. The corresponding
>> >> pass-arg checks for TBPs are ok.]
>> >>
>> >> The patch also fixes an invalid test case (which was detected thanks
>> >> to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for
>> >> trunk?
>> >
>> > The patch looks ok to me.  Trunk is in regression and doc
>> > fixes only mode, so you'll probably need to ping Jakub or
>> > Richard (ie., release engineer) for an ok.
>>
>> would you mind if I applied this patch to trunk at the current stage?
>> It was approved by Steve and Paul, is rather simple and low-risk ...
>
> Go ahead.


Thanks! Committed as r257590.

Cheers,
Janus

      reply	other threads:[~2018-02-12 17:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-09 17:13 Janus Weil
2018-02-09 23:21 ` Steve Kargl
2018-02-10 11:46   ` Paul Richard Thomas
2018-02-11 13:42     ` Janus Weil
2018-02-11 21:44   ` Janus Weil
2018-02-12  7:22     ` Richard Biener
2018-02-12 17:14       ` Janus Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwh3qgEiNKVuW2mkFx8N1jcDEGDODwJYsnOjvmcUf+qkpFQSg@mail.gmail.com \
    --to=janus@gcc.gnu.org \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=rguenther@suse.de \
    --cc=sgk@troutmask.apl.washington.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).