From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64944 invoked by alias); 9 Aug 2018 21:14:36 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 64931 invoked by uid 89); 9 Aug 2018 21:14:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=saturday, Saturday, fortan, controversial X-HELO: mail-yw1-f67.google.com Received: from mail-yw1-f67.google.com (HELO mail-yw1-f67.google.com) (209.85.161.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 21:14:33 +0000 Received: by mail-yw1-f67.google.com with SMTP id y203-v6so6641949ywd.9 for ; Thu, 09 Aug 2018 14:14:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xIDLo3vok+81YSGDkfqlPIHhqlq99xO/+Yb8KrJsdgQ=; b=TP7BEGxZCtC8P9ZKSUKYeV1DmCdf+fYHX1eq/dkyOJJCiBDr0AUiOJ/oOqM87K8yhh RHSU6SOfdGeQi0Bxh5xwv8ALQK4d11v34P+5oznF08g8UzdMtxxgMUb9IYbFxOx0hCmw DpUWyw3Hy7ybqAb5c16PqI+D6qQPqg9LQhd5K46uHIo6z6EqASemNHKcts9KNfHGqe6A 42M5HBmpgMiVTyX7fV9qjgvbFv9CCEn06Jrz5c9xToWQ9MLfthnz2FT7mFY+zQdBdlTW gwYC9Mq0aLXnCCYoeb5KvPSfFzUU+6SctmRvK5CSr5aQbHpNIgUr7k+fWewibs+eO3Oh vCRg== MIME-Version: 1.0 Sender: jaydub66@gmail.com Received: by 2002:a0d:fe84:0:0:0:0:0 with HTTP; Thu, 9 Aug 2018 14:14:30 -0700 (PDT) In-Reply-To: <7b6abaf1-162d-2d72-5a7d-8459231d438b@charter.net> References: <707691ED-E885-4038-B493-E1E97FE96358@lps.ens.fr> <8656c8dd-7a0b-48c0-9ff8-37319db96897@gmx.ch> <7b6abaf1-162d-2d72-5a7d-8459231d438b@charter.net> From: Janus Weil Date: Thu, 09 Aug 2018 21:14:00 -0000 Message-ID: Subject: Re: [Patch, Fortran] PR 57160: short-circuit IF only with -ffrontend-optimize To: Jerry DeLisle Cc: Arjen Markus , Manfred Schwarb , gfortran Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00044.txt.bz2 2018-08-09 3:04 GMT+02:00 Jerry DeLisle : > On 08/08/2018 01:48 PM, Janus Weil wrote: >> >> 2018-08-08 20:20 GMT+02:00 Janus Weil : >>> >>> Hi all, >>> >>> since there seems to be significant support for this after all, I just >>> rebased the last patch version and pushed it to github (I sincerely >>> hope gcc will officially make the switch to git very soon): >>> >>> >>> https://github.com/janusw/gcc/commit/35aae880ff2b3d4a9f6a9c821376fb510202961c >>> >>> This is still the most reasonable approach I can see. And I'd still be >>> grateful for (technical) comments on the patch. >>> >>> What's the procedure in GCC for dealing with such controversial >>> patches? The procedure for simple cases is: The patch author asks for >>> review, an authorized reviewer/maintainer approves it or asks for >>> improvements. What happens if that fails? Is there any rule on how >>> decisions are to be made in the non-trivial case? >> >> >> Re-reading the thread, I noticed that I haven't actually gotten a >> clear "yes" or "no" from anyone with review privileges for the Fortran >> front-end. >> >> So, I'll just continue with the usual procedure: The patch above >> regtests cleanly on x86_64-linux-gnu and provides a clear improvement >> regarding the standard-conformance of the GNU Fortan compiler. Ok to >> commit to trunk? >> > > Yes, OK for trunk. Thanks, Jerry. I'll wait until Saturday to allow for further comments ... Cheers, Janus