From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100694 invoked by alias); 10 Jun 2018 07:03:21 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 99441 invoked by uid 89); 10 Jun 2018 07:02:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sentinel, H*r:sk:h141-v6 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yb0-f169.google.com Received: from mail-yb0-f169.google.com (HELO mail-yb0-f169.google.com) (209.85.213.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Jun 2018 07:02:08 +0000 Received: by mail-yb0-f169.google.com with SMTP id h141-v6so5717349ybg.4; Sun, 10 Jun 2018 00:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=h3pvV4OY+niZd7KQ1kCFUzmvKnQoQ2PXV0vWqnLRB6g=; b=iNtP671n6wzPSiGsEQJXOLZ91gkJygFgxSu7kbgxhpxsenzWVXUsP8GIjnbMM29KTs VD6Va98k5N3o3W9s/CN0/NeqCH00gVCZFuS147WdhP83eLvvI3ah+6vOUnCCbV1kSbbw djF4hMDEMfyrV9Y+jvdnNfwl7p/9UKy9O/E4+TO085y8pAmrXROJpWYY1Fh0NhQXaFtQ virMl6KYMtkbdJitPzmqL8ZpXKvViquoB/LS8zcisAnNJ/kHKw4yCRmv5FPMp4Z2uKDb y7aVOplotLlS855lsjEyW7RVPKto6RXZALA+XWTk9BG49YFv6HbWXtRbDRLVxnlP6Jc6 9Veg== X-Gm-Message-State: APt69E0B49rJ5Dd/pdbSqcJtQgVzaek+zAGaed4uvX/ZCGjdKFt6ffVQ fgHlEI69GISNjLUlODa5pmoNVnlRP73Z5Atzj2o= X-Google-Smtp-Source: ADUXVKJ1/ItoTP6LFTduTwDgb9rsqm+K0IMLzOdsrs11W+E+3CbBgEVbg5oyCDGjgwrmoplI5bqWWOuCz+utUrN8GUw= X-Received: by 2002:a25:9d0b:: with SMTP id i11-v6mr7511488ybp.1.1528614127203; Sun, 10 Jun 2018 00:02:07 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:71d4:0:0:0:0:0 with HTTP; Sun, 10 Jun 2018 00:02:06 -0700 (PDT) In-Reply-To: <05e69e99-05c3-0d77-81fc-68afe18241e2@netcologne.de> References: <05e69e99-05c3-0d77-81fc-68afe18241e2@netcologne.de> From: Janus Weil Date: Sun, 10 Jun 2018 12:09:00 -0000 Message-ID: Subject: Re: [Patch, Fortran] PR 85088: improve diagnostic for bad INTENT declaration To: Thomas Koenig Cc: gfortran , gcc-patches Content-Type: multipart/mixed; boundary="0000000000000d19ad056e44367e" X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00047.txt.bz2 --0000000000000d19ad056e44367e Content-Type: text/plain; charset="UTF-8" Content-length: 1025 Hi Thomas, > I like what the patch does. However, I have one concern. > >> * decl.c (match_attr_spec): Synchronize the DECL_* enum values with >> the >> INTENT_* values from the enum 'sym_intent'. > > > This part > > + { GFC_DECL_BEGIN = 0, DECL_ALLOCATABLE = GFC_DECL_BEGIN, > + DECL_IN = INTENT_IN, DECL_OUT = INTENT_OUT, DECL_INOUT = INTENT_INOUT, > + DECL_DIMENSION, DECL_EXTERNAL, > + DECL_INTRINSIC, DECL_OPTIONAL, > > brings a dependency of the values of sym_intent into this enum. > > I know that the order of sym_intent is not likely to change, but I would > still prefer if you could add a comment to the sym_intent definition in > gfortran.h noting that INTENT_IN cannot be zero, and add a > > gcc_assert (INTENT_IN > 0); > > somewhere (which will be optimized away) with an explanatory comment. good point. I have added the assert and some comments. Updated patch attached. > OK with that change. Thanks. I'm doing another regtest now and will commit if that goes well ... Cheers, Janus --0000000000000d19ad056e44367e Content-Type: text/x-patch; charset="US-ASCII"; name="pr85088_v2.diff" Content-Disposition: attachment; filename="pr85088_v2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ji8hct9h0 Content-length: 2989 SW5kZXg6IGdjYy9mb3J0cmFuL2RlY2wuYwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBnY2MvZm9ydHJhbi9kZWNsLmMJKHJldmlzaW9uIDI2MTM1OCkK KysrIGdjYy9mb3J0cmFuL2RlY2wuYwkod29ya2luZyBjb3B5KQpAQCAtNDcx Niw5ICs0NzE2LDEwIEBAIG1hdGNoX2F0dHJfc3BlYyAodm9pZCkKIHsKICAg LyogTW9kaWZpZXJzIHRoYXQgY2FuIGV4aXN0IGluIGEgdHlwZSBzdGF0ZW1l bnQuICAqLwogICBlbnVtCi0gIHsgR0ZDX0RFQ0xfQkVHSU4gPSAwLAotICAg IERFQ0xfQUxMT0NBVEFCTEUgPSBHRkNfREVDTF9CRUdJTiwgREVDTF9ESU1F TlNJT04sIERFQ0xfRVhURVJOQUwsCi0gICAgREVDTF9JTiwgREVDTF9PVVQs IERFQ0xfSU5PVVQsIERFQ0xfSU5UUklOU0lDLCBERUNMX09QVElPTkFMLAor ICB7IEdGQ19ERUNMX0JFR0lOID0gMCwgREVDTF9BTExPQ0FUQUJMRSA9IEdG Q19ERUNMX0JFR0lOLAorICAgIERFQ0xfSU4gPSBJTlRFTlRfSU4sIERFQ0xf T1VUID0gSU5URU5UX09VVCwgREVDTF9JTk9VVCA9IElOVEVOVF9JTk9VVCwK KyAgICBERUNMX0RJTUVOU0lPTiwgREVDTF9FWFRFUk5BTCwKKyAgICBERUNM X0lOVFJJTlNJQywgREVDTF9PUFRJT05BTCwKICAgICBERUNMX1BBUkFNRVRF UiwgREVDTF9QT0lOVEVSLCBERUNMX1BST1RFQ1RFRCwgREVDTF9QUklWQVRF LAogICAgIERFQ0xfU1RBVElDLCBERUNMX0FVVE9NQVRJQywKICAgICBERUNM X1BVQkxJQywgREVDTF9TQVZFLCBERUNMX1RBUkdFVCwgREVDTF9WQUxVRSwg REVDTF9WT0xBVElMRSwKQEAgLTQ3MjksNiArNDczMCw5IEBAIG1hdGNoX2F0 dHJfc3BlYyAodm9pZCkKIC8qIEdGQ19ERUNMX0VORCBpcyB0aGUgc2VudGlu ZWwsIGluZGV4IHN0YXJ0cyBhdCAwLiAgKi8KICNkZWZpbmUgTlVNX0RFQ0wg R0ZDX0RFQ0xfRU5ECiAKKyAgLyogTWFrZSBzdXJlIHRoYXQgdmFsdWVzIGZy b20gc3ltX2ludGVudCBhcmUgc2FmZSB0byBiZSB1c2VkIGhlcmUuICAqLwor ICBnY2NfYXNzZXJ0IChJTlRFTlRfSU4gPiAwKTsKKwogICBsb2N1cyBzdGFy dCwgc2Vlbl9hdFtOVU1fREVDTF07CiAgIGludCBzZWVuW05VTV9ERUNMXTsK ICAgdW5zaWduZWQgaW50IGQ7CkBAIC00ODQ2LDEzICs0ODUwLDEyIEBAIG1h dGNoX2F0dHJfc3BlYyAodm9pZCkKIAkJICAgICAgaWYgKG1hdGNoX3N0cmlu Z19wICgibnQiKSkKIAkJCXsKIAkJCSAgLyogTWF0Y2hlZCAiaW50ZW50Ii4g ICovCi0JCQkgIC8qIFRPRE86IENhbGwgbWF0Y2hfaW50ZW50X3NwZWMgZnJv bSBoZXJlLiAgKi8KLQkJCSAgaWYgKGdmY19tYXRjaCAoIiAoIGluIG91dCAp IikgPT0gTUFUQ0hfWUVTKQotCQkJICAgIGQgPSBERUNMX0lOT1VUOwotCQkJ ICBlbHNlIGlmIChnZmNfbWF0Y2ggKCIgKCBpbiApIikgPT0gTUFUQ0hfWUVT KQotCQkJICAgIGQgPSBERUNMX0lOOwotCQkJICBlbHNlIGlmIChnZmNfbWF0 Y2ggKCIgKCBvdXQgKSIpID09IE1BVENIX1lFUykKLQkJCSAgICBkID0gREVD TF9PVVQ7CisJCQkgIGQgPSBtYXRjaF9pbnRlbnRfc3BlYyAoKTsKKwkJCSAg aWYgKGQgPT0gSU5URU5UX1VOS05PV04pCisJCQkgICAgeworCQkJICAgICAg bSA9IE1BVENIX0VSUk9SOworCQkJICAgICAgZ290byBjbGVhbnVwOworCQkJ ICAgIH0KIAkJCX0KIAkJICAgIH0KIAkJICBlbHNlIGlmIChjaCA9PSAncicp CkluZGV4OiBnY2MvZm9ydHJhbi9nZm9ydHJhbi5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGdjYy9mb3J0cmFuL2dmb3J0cmFuLmgJKHJldmlzaW9u IDI2MTM1OCkKKysrIGdjYy9mb3J0cmFuL2dmb3J0cmFuLmgJKHdvcmtpbmcg Y29weSkKQEAgLTI5MSw3ICsyOTEsOCBAQCBlbnVtIHByb2NlZHVyZV90eXBl CiAgIFBST0NfSU5UUklOU0lDLCBQUk9DX1NUX0ZVTkNUSU9OLCBQUk9DX0VY VEVSTkFMCiB9OwogCi0vKiBJbnRlbnQgdHlwZXMuICAqLworLyogSW50ZW50 IHR5cGVzLiBOb3RlIHRoYXQgdGhlc2UgdmFsdWVzIGFyZSBhbHNvIHVzZWQg aW4gYW5vdGhlciBlbnVtIGluCisgICBkZWNsLmMgKG1hdGNoX2F0dHJfc3Bl YykuICAqLwogZW51bSBzeW1faW50ZW50CiB7IElOVEVOVF9VTktOT1dOID0g MCwgSU5URU5UX0lOLCBJTlRFTlRfT1VULCBJTlRFTlRfSU5PVVQKIH07Cg== --0000000000000d19ad056e44367e--