From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73285 invoked by alias); 11 Feb 2016 23:29:21 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 72760 invoked by uid 89); 11 Feb 2016 23:29:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=UD:intrinsic.c, intrinsicc, intrinsic.c, H*Ad:D*ch X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f172.google.com Received: from mail-yw0-f172.google.com (HELO mail-yw0-f172.google.com) (209.85.161.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 11 Feb 2016 23:29:19 +0000 Received: by mail-yw0-f172.google.com with SMTP id u200so52552854ywf.0; Thu, 11 Feb 2016 15:29:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=gJ4R6dMvGqHB418SObEs4lEKDURuJ4nwzs9bw00ZnhM=; b=XWM1MqQ6T/+lVNFuDmllFUWrkIBqPtEu9AM5g0DbYyyPUq/OKqIy/4OcJX/6zRcJge JF0tA7gmeJ/dRAqlY++Rrr4kL4ODFPHjzwpnpPVOa9OtHcNBMP6ZHD3hyp0pBhF94C7Q AVdsPxNxBIJeIrpofjdn2tfvJt2k7LadQm12YXB4n3WOFN/GLP8hTiqqFf5sJE+1cSFE C5R1dAOhUsNTj75HwqQLR4S2S1T33NWqrhzqSlG5nxtrM9NcRYmlHEvTzpWVVXP999Al cJHUtPkEnc1bpOi5N+7vNdX27eD6F/fQGf2VU+DzZcVnkSTUr1/85ZJWvtuvXKQfY1cd 4JKw== X-Gm-Message-State: AG10YOQDgU/Skt6AT8zwLWCu8dhQJZKqNiRW9nBKY+qyiwJunGJpHgMCnX86JUV8Ls3hvf+7JMiKkUfrzTcMdA== MIME-Version: 1.0 X-Received: by 10.13.247.4 with SMTP id h4mr29541418ywf.15.1455233357617; Thu, 11 Feb 2016 15:29:17 -0800 (PST) Received: by 10.13.226.150 with HTTP; Thu, 11 Feb 2016 15:29:17 -0800 (PST) In-Reply-To: References: <56B1C681.4020508@gmx.ch> <56B2756F.2030908@gmx.ch> Date: Thu, 11 Feb 2016 23:29:00 -0000 Message-ID: Subject: Re: [Patch, Fortran] PR 69495: unused-label warning does not tell which flag triggered it From: Janus Weil To: Joseph Myers Cc: Manfred Schwarb , gfortran , gcc-patches Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00042.txt.bz2 ping! 2016-02-05 19:19 GMT+01:00 Janus Weil : > Hi all, > > I have slightly updated the patch now to avoid string-breaking issues > (even if it may not be a problem at all, as mentioned by Jospeh). Also > I removed the questionable part in intrinsic.c that I was not sure > about. > > This version of the patch should not be too far from obvious now. Ok for trunk? > > Cheers, > Janus > > > > 2016-02-03 23:27 GMT+01:00 Joseph Myers : >> On Wed, 3 Feb 2016, Manfred Schwarb wrote: >> >>> There are 2 things with translation, and there is a third issue: >>> - As you noticed, breaking things differently means translation has to be >>> done again. >>> - Normally, each string is translated independently, and depending on the >>> language there may be lack of context (e.g. adjectives get different >>> suffixes >>> depending on the noun). >> >> I believe gettext works fine with (compile-time) string constant >> concatenation - that is, extracts the whole concatenated string for >> translation, so these are non-issues. What doesn't work includes: >> >> * Runtime concatenation of strings or otherwise putting English fragments >> together at runtime. >> >> * String constant concatenation where one of the concatenated pieces comes >> from a macro expansion. >> >> * The argument for translation being a conditional expression: >> >> error (cond ? "message 1" : "message 2"); >> >> (in this case, only one of the messages may be extracted for translation, >> so you need to mark both of them up with appropriate macros such as G_). >> >> -- >> Joseph S. Myers >> joseph@codesourcery.com