From: Janus Weil <janus@gcc.gnu.org>
To: gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR 87172: [9 Regression] Spurious "Derived type 'c_funptr' at (1) has not been declared" error after r263782
Date: Tue, 11 Sep 2018 11:14:00 -0000 [thread overview]
Message-ID: <CAKwh3qhzoA8YMr5oecX2FUDzwW3CBAoYxvLEe__MdMnYBdxpbg@mail.gmail.com> (raw)
In-Reply-To: <CAKwh3qhqPJ7jjZEPoBmYsYDV-twfQ0SUOeKubiaoD2cmpYP7qQ@mail.gmail.com>
ping!
Am Mo., 3. Sep. 2018 um 21:19 Uhr schrieb Janus Weil <janus@gcc.gnu.org>:
>
> Hi all,
>
> attached is a simple patch that fixes a regression which was
> introduced by one of my recent commits (spotted by Dominique).
>
> My first impulse to fix the spurious error was to check for the
> 'intrinsic' attribute, however it is actually not set (yet?) in
> resolve_fl_derived, so the next-best thing is to check for
> 'use_assoc'. That is probably even better, since it's more general.
> Obviously, if a type has the 'use_assoc' attribute, then it has been
> declared in another module, so there is no need to complain that it
> was not declared.
>
> The patch regtests cleanly on x86_64-linux-gnu. Ok for trunk?
>
> Cheers,
> Janus
prev parent reply other threads:[~2018-09-11 11:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 19:19 Janus Weil
2018-09-11 11:14 ` Janus Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwh3qhzoA8YMr5oecX2FUDzwW3CBAoYxvLEe__MdMnYBdxpbg@mail.gmail.com \
--to=janus@gcc.gnu.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).