From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12672 invoked by alias); 18 Jul 2018 18:43:35 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 12652 invoked by uid 89); 18 Jul 2018 18:43:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=3.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPAM_BODY,SPF_PASS autolearn=no version=3.3.2 spammy=H*f:sk:0yA@mai, H*f:CAKwh3qi_N7, H*f:sk:NTctsTT, H*f:sk:xcgSKzC X-HELO: mail-yw0-f195.google.com Received: from mail-yw0-f195.google.com (HELO mail-yw0-f195.google.com) (209.85.161.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jul 2018 18:43:32 +0000 Received: by mail-yw0-f195.google.com with SMTP id q129-v6so2102701ywg.8; Wed, 18 Jul 2018 11:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ARbjbmG5m4/CuigBb3TRQJQT5gulBa6lrFKSZDLARlI=; b=JsDGBLq/aQwDfbRZfipNcWTJavfdOGkTxqukcIPzKSQWgJqM25EG9UgyitpVI/W9SS tBZ/fowNzteC8VAljmxXYq//lokz5TA6QK4DvV1MKhOeAzUrfhDAECv21fX/wfsWh1gD PIhkfR1Zocnc7Q7RKFKaO6SV60lAQcgXXaQD8XoeA04nFdcA8sLwR/SGvrxegke7cd33 1ct43FchPDkwVUiLX3vjuxOS9wpyo05qefuofTXsRja3A5CKLfg+ZQNXbgKWpLbn9Zze ag5jlsWPO58ksiH16931HqiEUtiKYOqXVPPtikMCKrWjzy2vrSMhxAxC84w6uJ2RHRrU 3Fkw== MIME-Version: 1.0 Sender: jaydub66@gmail.com Received: by 2002:a0d:ea0c:0:0:0:0:0 with HTTP; Wed, 18 Jul 2018 11:43:30 -0700 (PDT) In-Reply-To: References: <7ce70d80-88ac-f2cb-89cc-d622ac873b9e@netcologne.de> <13295d17-0718-a0af-d6bf-d30b523af848@netcologne.de> From: Janus Weil Date: Wed, 18 Jul 2018 18:43:00 -0000 Message-ID: Subject: Re: [Patch, Fortran] PR 85599: warn about short-circuiting of logical expressions for non-pure functions To: Fritz Reese Cc: Thomas Koenig , fortran , gcc-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00079.txt.bz2 I have now finally committed this as r262860. Thanks everyone for helping to bring this to a constructive end (and especially to Thomas for the useful input and for putting up with me). Cheers, Janus PS: The next step here would be to tackle PR57160 and avoid the short-circuiting with -O0 (I might actually look into that soon). Once that is done we could even talk about further optimizations (as previously suggested by Thomas), provided they are only done with -O... flags and warned about with appropriate -W... flags. 2018-07-17 21:21 GMT+02:00 Janus Weil : > 2018-07-17 20:55 GMT+02:00 Fritz Reese : >> On Tue, Jul 17, 2018 at 2:36 PM Janus Weil wrote: >>> >>> 2018-07-17 19:34 GMT+02:00 Thomas Koenig : >>> > Am 17.07.2018 um 19:19 schrieb Janus Weil: >> [...] >>> >>> I do hope that things have converged by now and that this will be the >>> last incarnation of the patch. If there is no more feedback in the >>> next 24 hours, I'll commit this tomorrow. >> >> I hate to be pedantic but it is still worth fixing the style discrepancies: > > Oh, sure. Such things are non-optional in GCC, I was just a bit sloppy > with this. Thanks for catching! Should be fixed in the attached > update. > > >> My only other comment is I am not sure why you make >> pure_function()/gfc_implicit_pure_function() public... but I have no >> real problem with it. Just means rebuilding all of f951 instead of one >> object. :-( > > Well, originally they were only used in resolve.c, but now I need them > also in frontend-passes.c, therefore they have to be public. > > >> Otherwise if the patch does what it appears to do and passes tests >> then it seems fine to me. > > Thanks for the review! > > Cheers, > Janus