From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119058 invoked by alias); 9 Feb 2018 17:13:40 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 119035 invoked by uid 89); 9 Feb 2018 17:13:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:janus@g, janus@gcc.gnu.org, U*janus, sk:janusg X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f179.google.com Received: from mail-yw0-f179.google.com (HELO mail-yw0-f179.google.com) (209.85.161.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Feb 2018 17:13:37 +0000 Received: by mail-yw0-f179.google.com with SMTP id j128so5574834ywg.7; Fri, 09 Feb 2018 09:13:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=59MXQvUe8L1gmRDoSpYrxxZz+ILBkJ2JdFpMwjDrSik=; b=P4hKxnRniPyzBvY/t5iR/8UX3mc9LHdbfuRVgy4zZga/wSN5XTLmemMCMRXTmf2jI0 wEug/QW64UGm+mKM0B75TH6goKQtOs9U/69qg2D2ko8B8awTHf+XV73TSrl2IIJAObEl ZMfMHUMYuGCqQLjPIqvb4bYVrGz+U7EQswVvQqtamSLizy/1Y46RO7tK38Ko1BlsI8j5 nrHXhGLJvlY/oQdncoyTHQhL7ihl2xzELnMR/cUBdw82n/pYsga5XQRfdiTsJA9ec7k4 MuoR++BjLC7VG2ld/NcxFLLTwuzWZubErIvABltIks2iZpyFCFdppmYzvDrEgR1PUsHf iYGA== X-Gm-Message-State: APf1xPBqH+6KjSfTEXigkPUo/C7h5c/xqJuv/RffcbBU8hRiNjhBRZNY +CiQOQFJewfDVP+vGcxF/puvjc2RbwLmwEJGqEtuwQ== X-Google-Smtp-Source: AH8x224CvumvFEXEAk6xzm5pVvDYsoTVniNJmZtt583ITcmrdkOauXvoJ//GflH5He8OXr75rNTs+BJiYcMDexhsVOY= X-Received: by 10.37.182.139 with SMTP id s11mr2244850ybj.399.1518196415969; Fri, 09 Feb 2018 09:13:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.85.138 with HTTP; Fri, 9 Feb 2018 09:13:34 -0800 (PST) From: Janus Weil Date: Fri, 09 Feb 2018 17:13:00 -0000 Message-ID: Subject: [Patch, Fortran] PR 84273: Reject allocatable passed-object dummy argument (proc_ptr_47.f90) To: gfortran , gcc-patches Content-Type: multipart/mixed; boundary="089e0821f4d4135ab30564caa606" X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00040.txt.bz2 --089e0821f4d4135ab30564caa606 Content-Type: text/plain; charset="UTF-8" Content-length: 886 Hi all, the attached patch fixes some checking code for PASS arguments in procedure-pointer components, which does not properly account for the fact that the PASS argument needs to be polymorphic. [The reason for this issue is probably that PPCs were mostly implemented before polymorphism was available. The corresponding pass-arg checks for TBPs are ok.] The patch also fixes an invalid test case (which was detected thanks to Neil Carlson). It regtests cleanly on x86_64-linux-gnu. Ok for trunk? Cheers, Janus 2018-02-09 Janus Weil PR fortran/84273 * resolve.c (resolve_component): Fix checks of passed argument in procedure-pointer components. 2018-02-09 Janus Weil PR fortran/84273 * gfortran.dg/proc_ptr_47.f90: Fix invalid test case. * gfortran.dg/proc_ptr_comp_pass_4.f90: Fix and extend test case. --089e0821f4d4135ab30564caa606 Content-Type: text/plain; charset="US-ASCII"; name="pr84273.diff" Content-Disposition: attachment; filename="pr84273.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jdg3txec0 Content-length: 3823 SW5kZXg6IGdjYy9mb3J0cmFuL3Jlc29sdmUuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBnY2MvZm9ydHJhbi9yZXNvbHZlLmMJKHJldmlzaW9uIDI1 NzQ5OCkKKysrIGdjYy9mb3J0cmFuL3Jlc29sdmUuYwkod29ya2luZyBjb3B5 KQpAQCAtMTM3MDMsOCArMTM3MDMsOCBAQCByZXNvbHZlX2NvbXBvbmVudCAo Z2ZjX2NvbXBvbmVudCAqYywgZ2ZjX3N5bWJvbCAqcwogICAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICAgICAgfQogCi0gICAgICAvKiBDaGVjayBmb3Ig QzQ1My4gICovCi0gICAgICBpZiAobWVfYXJnLT5hdHRyLmRpbWVuc2lvbikK KyAgICAgIC8qIENoZWNrIGZvciBGMDM6QzQ1My4gICovCisgICAgICBpZiAo Q0xBU1NfREFUQSAobWVfYXJnKS0+YXR0ci5kaW1lbnNpb24pCiAgICAgICAg IHsKICAgICAgICAgICBnZmNfZXJyb3IgKCJBcmd1bWVudCAlcXMgb2YgJXFz IHdpdGggUEFTUyglcykgYXQgJUwgIgogICAgICAgICAgICAgICAgICAgICAg Im11c3QgYmUgc2NhbGFyIiwgbWVfYXJnLT5uYW1lLCBjLT5uYW1lLCBtZV9h cmctPm5hbWUsCkBAIC0xMzcxMyw3ICsxMzcxMyw3IEBAIHJlc29sdmVfY29t cG9uZW50IChnZmNfY29tcG9uZW50ICpjLCBnZmNfc3ltYm9sICpzCiAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAKLSAgICAgIGlmICht ZV9hcmctPmF0dHIucG9pbnRlcikKKyAgICAgIGlmIChDTEFTU19EQVRBICht ZV9hcmcpLT5hdHRyLmNsYXNzX3BvaW50ZXIpCiAgICAgICAgIHsKICAgICAg ICAgICBnZmNfZXJyb3IgKCJBcmd1bWVudCAlcXMgb2YgJXFzIHdpdGggUEFT UyglcykgYXQgJUwgIgogICAgICAgICAgICAgICAgICAgICAgIm1heSBub3Qg aGF2ZSB0aGUgUE9JTlRFUiBhdHRyaWJ1dGUiLCBtZV9hcmctPm5hbWUsCkBA IC0xMzcyMiw3ICsxMzcyMiw3IEBAIHJlc29sdmVfY29tcG9uZW50IChnZmNf Y29tcG9uZW50ICpjLCBnZmNfc3ltYm9sICpzCiAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgICAgICB9CiAKLSAgICAgIGlmIChtZV9hcmctPmF0dHIu YWxsb2NhdGFibGUpCisgICAgICBpZiAoQ0xBU1NfREFUQSAobWVfYXJnKS0+ YXR0ci5hbGxvY2F0YWJsZSkKICAgICAgICAgewogICAgICAgICAgIGdmY19l cnJvciAoIkFyZ3VtZW50ICVxcyBvZiAlcXMgd2l0aCBQQVNTKCVzKSBhdCAl TCAiCiAgICAgICAgICAgICAgICAgICAgICAibWF5IG5vdCBiZSBBTExPQ0FU QUJMRSIsIG1lX2FyZy0+bmFtZSwgYy0+bmFtZSwKSW5kZXg6IGdjYy90ZXN0 c3VpdGUvZ2ZvcnRyYW4uZGcvcHJvY19wdHJfNDcuZjkwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIGdjYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHJv Y19wdHJfNDcuZjkwCShyZXZpc2lvbiAyNTc0OTgpCisrKyBnY2MvdGVzdHN1 aXRlL2dmb3J0cmFuLmRnL3Byb2NfcHRyXzQ3LmY5MAkod29ya2luZyBjb3B5 KQpAQCAtMjEsMTMgKzIxLDkgQEAKIAogY29udGFpbnMKICAgZnVuY3Rpb24g Zm9vKEEpCi0gICAgY2xhc3MoQUEpLCBhbGxvY2F0YWJsZSA6OiBBCisgICAg Y2xhc3MoQUEpIDo6IEEKICAgICB0eXBlKEFBKSBmb28KIAotICAgIGlmICgu bm90LmFsbG9jYXRlZCAoQSkpIHRoZW4KLSAgICAgIGFsbG9jYXRlIChBLCBz b3VyY2UgPSBBQSAoMiwgZm9vKSkKLSAgICBlbmRpZgotCiAgICAgc2VsZWN0 IHR5cGUgKEEpCiAgICAgICB0eXBlIGlzIChBQSkKICAgICAgICAgZm9vID0g QUEgKDMsIGZvbykKSW5kZXg6IGdjYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcv cHJvY19wdHJfY29tcF9wYXNzXzQuZjkwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGdjYy90ZXN0c3VpdGUvZ2ZvcnRyYW4uZGcvcHJvY19wdHJfY29t cF9wYXNzXzQuZjkwCShyZXZpc2lvbiAyNTc0OTgpCisrKyBnY2MvdGVzdHN1 aXRlL2dmb3J0cmFuLmRnL3Byb2NfcHRyX2NvbXBfcGFzc180LmY5MAkod29y a2luZyBjb3B5KQpAQCAtMzcsMjIgKzM3LDIzIEBAIG1vZHVsZSBtCiAKICB0 eXBlIDo6IHQ4CiAgICBwcm9jZWR1cmUoZm9vOCksIHBhc3MsIHBvaW50ZXIg OjogZjggICEgeyBkZy1lcnJvciAibXVzdCBiZSBvZiB0aGUgZGVyaXZlZCB0 eXBlIiB9CisgICBwcm9jZWR1cmUoZm9vOSksIHBhc3MsIHBvaW50ZXIgOjog ZjkgICEgeyBkZy1lcnJvciAiTm9uLXBvbHltb3JwaGljIHBhc3NlZC1vYmpl Y3QgZHVtbXkgYXJndW1lbnQiIH0KICBlbmQgdHlwZQogCiBjb250YWlucwog CiAgc3Vicm91dGluZSBmb28xICh4MSx5MSkKLSAgdHlwZSh0MSkgOjogeDEo OikKKyAgY2xhc3ModDEpIDo6IHgxKDopCiAgIHR5cGUodDEpIDo6IHkxCiAg ZW5kIHN1YnJvdXRpbmUKIAogIHN1YnJvdXRpbmUgZm9vMiAoeDIseTIpCi0g IHR5cGUodDIpLHBvaW50ZXIgOjogeDIKKyAgY2xhc3ModDIpLHBvaW50ZXIg OjogeDIKICAgdHlwZSh0MikgOjogeTIKICBlbmQgc3Vicm91dGluZQogCiAg c3Vicm91dGluZSBmb28zICh4Myx5MykKLSAgdHlwZSh0MyksYWxsb2NhdGFi bGUgOjogeDMKKyAgY2xhc3ModDMpLGFsbG9jYXRhYmxlIDo6IHgzCiAgIHR5 cGUodDMpIDo6IHkzCiAgZW5kIHN1YnJvdXRpbmUKIApAQCAtNjksNCArNzAs OCBAQCBjb250YWlucwogICAgaW50ZWdlciA6OiBpCiAgZW5kIGZ1bmN0aW9u CiAKKyBzdWJyb3V0aW5lIGZvbzkoeCkKKyAgIHR5cGUodDgpIDo6IHgKKyBl bmQgc3Vicm91dGluZQorCiBlbmQgbW9kdWxlIG0K --089e0821f4d4135ab30564caa606--