From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35232 invoked by alias); 23 Jul 2018 20:20:20 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 35207 invoked by uid 89); 23 Jul 2018 20:20:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=H*i:xCQKYb2V, H*i:sk:JA@mail, H*f:CAGkQGi, H*f:sk:UMw7Z0m X-HELO: mail-yw0-f174.google.com Received: from mail-yw0-f174.google.com (HELO mail-yw0-f174.google.com) (209.85.161.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Jul 2018 20:20:17 +0000 Received: by mail-yw0-f174.google.com with SMTP id q129-v6so705453ywg.8; Mon, 23 Jul 2018 13:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=c3I643lOArb6Lrrc+QkwO6x7AySpvvrL9PHL1yqijLk=; b=mNqasqC/r82ys/7adIfgdlSexKX35AQjW9nGprRjw3LAFoFvkSlezTrOPTEoUqQuaF NEHLVIBvhPlynUhOfPhpkeTGijNsxgqRS6lIV8SiyW6CDpV3sMYPSr/zH68VLKxF/lUZ KIfkr567hWP/q7rTGcO9wx0IqSC/CMaXINCxbZJ0u39ePAbqSEruZXQCMGn/jjyr3FuG HGl4up6oAvh94pyA6XMYIK0nSg7oV2q4cFNrM9VZq0xSjaVteGJseasnSU5wUJ3/K4yO rqQk8sF0Exu+GplIqtqLE+WeRRfSeXg5LNJoV8OkncT93DqWSPlXmVE3vT/BfdA81jW9 xAJg== MIME-Version: 1.0 Sender: jaydub66@gmail.com Received: by 2002:a0d:ea0c:0:0:0:0:0 with HTTP; Mon, 23 Jul 2018 13:20:15 -0700 (PDT) In-Reply-To: References: From: Janus Weil Date: Mon, 23 Jul 2018 20:20:00 -0000 Message-ID: Subject: Re: [Patch, fortran] PR66679 - [OOP] ICE with class(*) and transfer To: Paul Richard Thomas Cc: "fortran@gcc.gnu.org" , gcc-patches , Miha Polajnar Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00094.txt.bz2 Hi Paul, 2018-07-23 17:51 GMT+02:00 Paul Richard Thomas : > Ping! > On Thu, 5 Jul 2018 at 08:51, Paul Richard Thomas > wrote: >> >> The comment in the patch says it all. >> >> Bootstrapped and regtested on FC28/x86_64 - OK for trunk? I don't see anything wrong with the patch, so as far as I'm concerned it's ok for trunk. Just one minor style-wise suggestion: I'd move the declaration of the 'class_expr' into the else branch where it's used (in order to have it as locally as possible). Thanks for the patch, Janus >> 2018-07-05 Paul Thomas >> >> PR fortran/66679 >> * trans-intrinsic.c (gfc_conv_intrinsic_transfer): Class array >> elements are returned as references to the data element. Get >> the class expression by stripping back the references. Use this >> for the element size. >> >> 2018-07-05 Paul Thomas >> >> PR fortran/66679 >> * gfortran.dg/transfer_class_3.f90: New test. > > > > -- > "If you can't explain it simply, you don't understand it well enough" > - Albert Einstein