* Fwd: [PATCH 17/25] Fix Fortran STOP. [not found] <3b1ee6252e6bc42be1886f45fd4512efda27bcbd.1536144068.git.ams@codesourcery.com> @ 2018-09-05 16:55 ` Toon Moene 2018-09-05 17:06 ` Bernhard Reutner-Fischer 2018-09-05 18:09 ` Janne Blomqvist 0 siblings, 2 replies; 4+ messages in thread From: Toon Moene @ 2018-09-05 16:55 UTC (permalink / raw) To: gfortran [-- Attachment #1: Type: text/plain, Size: 614 bytes --] -------- Forwarded Message -------- Subject: [PATCH 17/25] Fix Fortran STOP. Date: Wed, 5 Sep 2018 12:51:18 +0100 From: ams@codesourcery.com To: gcc-patches@gcc.gnu.org The minimal libgfortran setup was created for NVPTX, but will also be used by AMD GCN. This patch simply removes an assumption that NVPTX is the only user. Specifically, NVPTX exit is broken, but AMD GCN exit works just fine. 2018-09-05 Andrew Stubbs <ams@codesourcery.com> libgfortran/ * runtime/minimal.c (exit): Only work around nvptx bugs on nvptx. --- libgfortran/runtime/minimal.c | 2 ++ 1 file changed, 2 insertions(+) [-- Attachment #2: 0017-Fix-Fortran-STOP.patch --] [-- Type: text/x-patch, Size: 555 bytes --] diff --git a/libgfortran/runtime/minimal.c b/libgfortran/runtime/minimal.c index 0b1efeb..8940f97 100644 --- a/libgfortran/runtime/minimal.c +++ b/libgfortran/runtime/minimal.c @@ -197,10 +197,12 @@ sys_abort (void) #define st_printf printf #undef estr_write #define estr_write printf +#if __nvptx__ /* Map "exit" to "abort"; see PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process'. */ #undef exit #define exit(...) do { abort (); } while (0) +#endif #undef exit_error #define exit_error(...) do { abort (); } while (0) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 17/25] Fix Fortran STOP. 2018-09-05 16:55 ` Fwd: [PATCH 17/25] Fix Fortran STOP Toon Moene @ 2018-09-05 17:06 ` Bernhard Reutner-Fischer 2018-09-05 18:09 ` Janne Blomqvist 1 sibling, 0 replies; 4+ messages in thread From: Bernhard Reutner-Fischer @ 2018-09-05 17:06 UTC (permalink / raw) To: toon; +Cc: gfortran On Wed, 5 Sep 2018 at 18:55, Toon Moene <toon@moene.org> wrote: > > Looks ok and obvious but i cannot approve it. cheers, > > > -------- Forwarded Message -------- > Subject: [PATCH 17/25] Fix Fortran STOP. > Date: Wed, 5 Sep 2018 12:51:18 +0100 > From: ams@codesourcery.com > To: gcc-patches@gcc.gnu.org > > > The minimal libgfortran setup was created for NVPTX, but will also be > used by > AMD GCN. > > This patch simply removes an assumption that NVPTX is the only user. > Specifically, NVPTX exit is broken, but AMD GCN exit works just fine. > > 2018-09-05 Andrew Stubbs <ams@codesourcery.com> > > libgfortran/ > * runtime/minimal.c (exit): Only work around nvptx bugs on nvptx. > --- > libgfortran/runtime/minimal.c | 2 ++ > 1 file changed, 2 insertions(+) > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 17/25] Fix Fortran STOP. 2018-09-05 16:55 ` Fwd: [PATCH 17/25] Fix Fortran STOP Toon Moene 2018-09-05 17:06 ` Bernhard Reutner-Fischer @ 2018-09-05 18:09 ` Janne Blomqvist 2018-09-12 13:56 ` Andrew Stubbs 1 sibling, 1 reply; 4+ messages in thread From: Janne Blomqvist @ 2018-09-05 18:09 UTC (permalink / raw) To: Toon Moene, GCC Patches, ams; +Cc: Fortran List Same, please send fortran patches to the fortran list as well! On Wed, Sep 5, 2018 at 7:55 PM Toon Moene <toon@moene.org> wrote: > > > > -------- Forwarded Message -------- > Subject: [PATCH 17/25] Fix Fortran STOP. > Date: Wed, 5 Sep 2018 12:51:18 +0100 > From: ams@codesourcery.com > To: gcc-patches@gcc.gnu.org > > > The minimal libgfortran setup was created for NVPTX, but will also be > used by > AMD GCN. > > This patch simply removes an assumption that NVPTX is the only user. > Specifically, NVPTX exit is broken, but AMD GCN exit works just fine. > > 2018-09-05 Andrew Stubbs <ams@codesourcery.com> > > libgfortran/ > * runtime/minimal.c (exit): Only work around nvptx bugs on nvptx. > --- > libgfortran/runtime/minimal.c | 2 ++ > 1 file changed, 2 insertions(+) > > Ok, thanks. -- Janne Blomqvist ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 17/25] Fix Fortran STOP. 2018-09-05 18:09 ` Janne Blomqvist @ 2018-09-12 13:56 ` Andrew Stubbs 0 siblings, 0 replies; 4+ messages in thread From: Andrew Stubbs @ 2018-09-12 13:56 UTC (permalink / raw) To: Janne Blomqvist, Toon Moene, GCC Patches; +Cc: Fortran List On 05/09/18 19:09, Janne Blomqvist wrote: > Ok, thanks. Committed, thanks. Andrew ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-12 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <3b1ee6252e6bc42be1886f45fd4512efda27bcbd.1536144068.git.ams@codesourcery.com>
2018-09-05 16:55 ` Fwd: [PATCH 17/25] Fix Fortran STOP Toon Moene
2018-09-05 17:06 ` Bernhard Reutner-Fischer
2018-09-05 18:09 ` Janne Blomqvist
2018-09-12 13:56 ` Andrew Stubbs
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).