From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47472 invoked by alias); 10 Feb 2018 21:07:49 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 47446 invoked by uid 89); 10 Feb 2018 21:07:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=practices, yours X-HELO: mail-yw0-f170.google.com Received: from mail-yw0-f170.google.com (HELO mail-yw0-f170.google.com) (209.85.161.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 10 Feb 2018 21:07:46 +0000 Received: by mail-yw0-f170.google.com with SMTP id j128so7532605ywg.7 for ; Sat, 10 Feb 2018 13:07:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RhK3NVMe0lnytwThnt9tpXuU2HbECfaNo5X7SsTyNJU=; b=DgaqmdxJkHSWODfGiwukkD9yTUirKgn92ZOm6Grt1whcaZbNASij087C84EdFEhQkh pqfYMIHqK+3KciFvDFtxSkLgYHCW5hNbTi0krbgS2iYU6TlSdPUt+ZBeSxmjJWTudMg0 ARj0GJnNhVox9dCoWe5LfixDmeBjYd37SfkJbNY2nAH+hd7qAEOpn7wbkKVSSrSOHU18 22kMVmpqC9ocb2xGSwr0H3x5ujklPbW1/1xITIhzm25q/qC6Qf6Oxec0XlKv85WiSRUW naQeEpjA9yq+swWs+FYikhG44HrX2yz3RDHfidpPpKo5o9OGiw4e1LZoD/sadqElbP+2 tiYw== X-Gm-Message-State: APf1xPAZBk/kJZp/iCqy4meuXNXFfyQJQMewvbwbdCgG+M0nO0e0UVKB o0iX/IhQ+px4IpeatI5X5EKIrqZY0xEc+sx5Pik= X-Google-Smtp-Source: AH8x2261BTObzTfyFWeDmfiWsiaYpahx0SXwX6XjYCMPnY/6jRwnO9ZvbpVNQV/Tz9drR4+YbNZH9OScOc8o/dl7rnw= X-Received: by 10.129.175.12 with SMTP id n12mr3701756ywh.37.1518296865014; Sat, 10 Feb 2018 13:07:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.241.4 with HTTP; Sat, 10 Feb 2018 13:07:44 -0800 (PST) In-Reply-To: References: <1518284822.56399.ezmlm@gcc.gnu.org> From: Janne Blomqvist Date: Sat, 10 Feb 2018 21:07:00 -0000 Message-ID: Subject: Re: [PATCH] Character length cleanup for Coarray Fortran library To: Zaak Beekman Cc: Fortran List Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00053.txt.bz2 On Sat, Feb 10, 2018 at 9:25 PM, Zaak Beekman wrote: >> >> Janne, I've scanned the patch and it appears to a >> fairly straight foward mechanical s/int/size_t >> (and similar for nodes). OK to commit (although >> you may want to wait for a response from Damain >> or Izaak Beekman). >> >> As this breaks an ABI and we've broken it for 8.0, >> I think this should go into trunk. You may need >> to ping Jakub or Richard for final approval. >> >> -- >> Steve >> > > Hi Janne & Steve, > > I'm still getting used to the GFortran mailing list, and trying to get up > to speed with your dev practices, so please bear with me. > > Also, let me add the caveat that, to date, I have mostly dealt with the > OpenCoarrays build system and various project > management/documentation/QA/CI and other administrivia and devops related > stuff---I am not *super* intimately familiar with the actual code base and > ABI. I am even less familiar with the GFortran inner workings. Alessandro > Fanfarillo and Andre are certainly more knowledgeable than I am in this > area. > > Is my understanding correct that I can just look at changes to caf_single.c > and the header files to determine where the type changes will impact > OpenCoarrays? A concise list of ABIs/APIs that need changes on the > OpenCoarrays side would go a long way in helping us/me make the > corresponding changes on the OpenCoarrays side. Also, this patch will only > be merged into trunk, right? I.e., it will impact GFortran 8+, and not > future releases on the 6 and 7 branches? AFAICT, the change to libgfortran/caf/libcaf.h tells you what would be necessary to change on the OpenCoarrays side. And yes, the idea would be to push this change only to the 8 branch. My problem is a bit the opposite of yours, namely that apart from skimming through the github repo I have zero experience of opencoarrays. A related question (, not directed to you specifically), if anybody happens to know: Is libgfortran/caf/mpi.c actually used by anything, or is it some pre-OpenCoarrays attempt at creating an MPI runtime for coarrays? In other words, can we remove it? -- Janne Blomqvist