From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Steve Kargl <sgk@troutmask.apl.washington.edu>
Cc: Fortran List <fortran@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/64124,70409 -- Reduce a charlen
Date: Wed, 07 Mar 2018 07:11:00 -0000 [thread overview]
Message-ID: <CAO9iq9EbMPjmUHrg+XrVT2=v1oxh9rKbyv2nDoRCp0TX9iY_Sg@mail.gmail.com> (raw)
In-Reply-To: <20180307002019.GA32497@troutmask.apl.washington.edu>
On Wed, Mar 7, 2018 at 2:20 AM, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> All,
>
> As everyone knows, gfortran reads source into a trees and
> and at some point she passes those trees to a resolution
> phases. There are instances, for example the new tests,
> where resolution fails to use the character length
> parameter in declaration statements. The attach patch
> seems to cure this problem.
>
> Previously, after reading the scalar-integer-expr, gfortran
> would assign the expression to the charlen without trying
> to reduce it to a constant (which should happen but doesn't
> in the resolution phase). The patch now tries to reduce
> the scalar-integer-expr to a constant, and then assigns
> that constant to the charlen.
>
> Bootstrap and regression tested on 7-branch and trunk.
> OK to commit?
>
> 2018-03-06 Steven G. Kargl <kargl@gcc.gnu.org>
>
> PR fortran/64124
> PR fortran/70409
> * decl.c (gfc_match_char_spec): Try to reduce a charlen to a constant.
>
> 2018-03-06 Steven G. Kargl <kargl@gcc.gnu.org>
>
> PR fortran/64124
> PR fortran/70409
> * gfortran.dg/pr64124.f90: New tests.
> * gfortran.dg/pr70409.f90: New tests.
Ok, thanks.
--
Janne Blomqvist
prev parent reply other threads:[~2018-03-07 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 0:20 Steve Kargl
2018-03-07 7:11 ` Janne Blomqvist [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO9iq9EbMPjmUHrg+XrVT2=v1oxh9rKbyv2nDoRCp0TX9iY_Sg@mail.gmail.com' \
--to=blomqvist.janne@gmail.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sgk@troutmask.apl.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).