Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

[Janne Blomqvist <blomqvist.janne@gmail.com>]

On Fri, Feb 16, 2018 at 12:30 AM, Thomas Koenig <tkoenig@netcologne.de> wrote:
> Hello world,
>
> the attached patch replaces the non-standard "call abort" by
> "STOP n", where n is a number counted up from 1 for each occurrence.
> This numbering was suggested by Neil Carlson.
>
> This makes the gfortran testsuite _much_ more standard-conforming.
> It also makes it easier to see _which_ of the numerous tests failed,
> if anything happens.
>
> I had to adjust the tree dump in a couple of places to check
> for stop instead of abort.  In the standards tests where the
> compiler was supposed to complain about call abort, I left it in :-)

Hi,

as a result of this, you should be able to remove the vast majority of
-fall-intrinsics extra options. Please do that as well.

I actually liked the usage of "call abort" in testcases, as a failing
testcase provided a backtrace with line number information and a core
dump. With this change, one now has to check on which line the
testcase failed, set a breakpoint there and run it again in the
debugger. Oh well, I guess that convenience has to be sacrificed on
the altar of standards conformance.

There's also the issue that without special tricks only the lower 8
bits of the exit code are used, and furthermore there are various
conventions. See e.g. https://stackoverflow.com/a/1535733/75652 for
what's typically the meaning on Linux. Anyway, I guess this is mostly
a theoretical quibble as I don't think we have any testcases with that
many error checks.


-- 
Janne Blomqvist