public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Janne Blomqvist <blomqvist.janne@gmail.com>
To: Alastair McKinstry <alastair.mckinstry@sceal.ie>
Cc: Fortran List <fortran@gcc.gnu.org>
Subject: Re: Bit-reproduciblity issue for gfortran .mod files
Date: Tue, 13 Feb 2018 08:09:00 -0000	[thread overview]
Message-ID: <CAO9iq9GU8y0Fx-C34eSNOG8CkV39oRvs7wOqN8n49CVFCJc48A@mail.gmail.com> (raw)
In-Reply-To: <032a646b-bb87-a6e4-7cf4-2d2470e8ea90@sceal.ie>

On Tue, Feb 13, 2018 at 8:55 AM, Alastair McKinstry
<alastair.mckinstry@sceal.ie> wrote:
>
>>>> So while reproducible builds are important and this is a good catch,
>>>> your patch as-is is not really usable. But luckily gcc includes a copy
>>>> of libiberty, including lbasename(). That function seems to be used by
>>>> other frontends, so I'd suggest using that instead.
>>> Thanks, I hadn't heard of lbasename(). I've just tested it and it works.
>>> No header inclusion needed.
>> This is Ok for trunk with a proper ChangeLog entry. Since it's
>> effectively a change in a comment I think we can dispense with nagging
>> the release managers, even though we're in stage 4.
>>
>> Do you, or anybody else, have any particular opinion on whether it
>> should be backported to older release branches?
>>
>> Do you have commit access, or do you need somebody to do it for you?
>>
> I have no opinion on whether it should be backported; there is a patch
> for it in Debian at the moment; it would help reproducible builds
> elsewhere (eg OpenSUSE have a reproducible builds project too).
>
> I don't have commit access.

Hi,

here's the patch I tested and committed:
https://gcc.gnu.org/ml/gcc-patches/2018-02/msg00706.html

Committed to trunk as r257613, gcc-7 branch as r257614, and gcc-6
branch as r257615.

Thanks for bringing up this issue!

-- 
Janne Blomqvist

      reply	other threads:[~2018-02-13  8:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02 13:22 Alastair McKinstry
2018-02-03  1:58 ` Steve Kargl
2018-02-05  9:03   ` Alastair McKinstry
2018-02-05  9:53     ` Janne Blomqvist
2018-02-05 21:13       ` Alastair McKinstry
2018-02-12 19:54         ` Janne Blomqvist
2018-02-13  6:56           ` Alastair McKinstry
2018-02-13  8:09             ` Janne Blomqvist [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAO9iq9GU8y0Fx-C34eSNOG8CkV39oRvs7wOqN8n49CVFCJc48A@mail.gmail.com \
    --to=blomqvist.janne@gmail.com \
    --cc=alastair.mckinstry@sceal.ie \
    --cc=fortran@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).