From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82359 invoked by alias); 11 Mar 2018 20:16:06 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 82230 invoked by uid 89); 11 Mar 2018 20:16:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-yw0-f171.google.com Received: from mail-yw0-f171.google.com (HELO mail-yw0-f171.google.com) (209.85.161.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 11 Mar 2018 20:16:04 +0000 Received: by mail-yw0-f171.google.com with SMTP id g198so4140357ywb.3; Sun, 11 Mar 2018 13:16:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7DKJhzJelBDLXppe6doISYfErrfEF5WBJS2xDMhX0/Y=; b=SPZkO104aSVcTw4tN6jNM2ofD3tJHxo/GB9urA1K/DO67MEEQ7Xm8UQVdQa7AcStT8 AOTbO2lC+fl+z2Pl1t3Rg1i1wvCOc4cdSGUVwojVPN1WOZnAb0jxn5aj1mcXls1gLv+5 CP9A70DH/sJCFYBCufY8g3ZHw4mZkXLl24hCcz4qo9Z5tsUM7beXAAS1GgjIUorbcepA ELVBFX9ijsY34hYgwVWSBrUzYeysRo2eRiv5v+MJCCXvmdnhKlmHzulkfDnISiXF1T1G xRStQBe5mDiHsxogTD0qUkFVp7zgrAdWdMXQc0LsPIFLnI9GFNtFBZ0mr4r6VvsV56SB xImw== X-Gm-Message-State: AElRT7GDJ8uwa946CNtEkhHSfJI2gm3U/UuC1Okt2Ffv8Y8jrrz/KO5A 4pZe7AwRKobT9Exl2yf4r4zAwb5jG6b9P4tG8do= X-Google-Smtp-Source: AG47ELtXjU2adAgBjfTsyrjQWXSmOIJDsJsnaS+ZjONXY269Rnfevioacc8usvmi4WOWLIzy9sS5UhpJsXE7zrGJr0w= X-Received: by 2002:a25:dbcb:: with SMTP id g194-v6mr2766059ybf.511.1520799362355; Sun, 11 Mar 2018 13:16:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.230.151 with HTTP; Sun, 11 Mar 2018 13:16:01 -0700 (PDT) In-Reply-To: <20180311165209.GA60279@troutmask.apl.washington.edu> References: <20180311165209.GA60279@troutmask.apl.washington.edu> From: Janne Blomqvist Date: Sun, 11 Mar 2018 20:16:00 -0000 Message-ID: Subject: Re: [PATCH] Fortran -- clean up KILL To: Steve Kargl Cc: Fortran List , GCC Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00038.txt.bz2 On Sun, Mar 11, 2018 at 6:52 PM, Steve Kargl wrote: > The attach patch cleans up KILL to match its > documentation. In doing so, I have changed > the argument keywords to consistently use > pid and sig. If no one objects, I intend to > commit this tomorrow. > > 2018-03-11 Steven G. Kargl > > * check.c (gfc_check_kill): Check pid and sig are scalar. > (gfc_check_kill_sub): Restrict kind to 4 and 8. > * intrinsic.c (add_function): Sort keyword list. Add pid and sig > keywords for KILL. Remove redundant *back="back" in favor of the > original *bck="back". > (add_subroutines): Sort keyword list. Add pid and sig keywords > for KILL. > * intrinsic.texi: Fix documentation to consistently use pid and sig. > * iresolve.c (gfc_resolve_kill): Kind can only be 4 or 8. Choose the > correct function. > (gfc_resolve_rename_sub): Add comment. The patch per se looks fine, but while you're at it, it would be nice to get rid of all but one of the libgfortran entry points and do the typecasting etc. in the frontend instead.. -- Janne Blomqvist