From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id DB41B3858CD1 for ; Mon, 27 Nov 2023 10:20:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB41B3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DB41B3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701080424; cv=none; b=s0EBwtq8HUh0X+vxAGXwYuj1GzupX6GkglRsWfOp7QBd3OEmP40wqOmHyeawAJtswSfOGwyk+xH0uvQ9FVFqtYri/Jwnmxex3JiF6rkV398CyhfAo2jJV6SCPidxrcAiKiH4yEv0z/xyKa4UGwL7mkBhDnhax+pL1elxXkDlvNw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701080424; c=relaxed/simple; bh=B0/ZzBXDOMqe/MMuYHjeDS88Z5oglNr0NsXpi6M/5vQ=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=fMaMOI0Vu/Op3tHaXm9aU7uQXIyM5gJWFuUG8OIzsyL/69UMvf94577ExfjrbERPkU0b+mAlbl64r9JOu63moqq6cdEFdcAq4OhKmdxbYBHBGIi6rVnyzi4UZc6QQyN4hgGmXpskcgKItEjC53Zc+WK5itGpdIAtxXMqEe66tH4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-54af0eca12dso3864799a12.3 for ; Mon, 27 Nov 2023 02:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701080421; x=1701685221; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Flj0qd1ksphvoiGZdz9jzjYte/dhFWNNzr+xDAHI2Cw=; b=GvspWFXPz4C8ovNoYzxZ6zRRmnCwbdj6JOpBfsT/KColvAMK+hFsoW03EWNsKTkC3V EMD/4yKzgtbhyR+JaduOS2axk3KF10eLLdFdSGo1OAOTn+qO4ONyaFoS5o82H0nHIMQK OOSAplHu4q9plJu2RTjmOijlS4GQUGHiKOqzwPp/a6n0tUCJkriqavpkn866hEk8f5a3 No+dE+TgFDSVQfY2RI6sIUoEStISsUlumApusm8rqKG6DP4SPDp7cjt8zL1BSWxbVWbW 4P2ROieyR79PXJ7joRomUXnax5tYRFPw8xHgqNQCASd8RIj9vask6kjt5kmkHtfMmwz7 xqIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701080421; x=1701685221; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Flj0qd1ksphvoiGZdz9jzjYte/dhFWNNzr+xDAHI2Cw=; b=nLn8mzMBT4EGJz+8CQCqFQHoOBrldj6j2nxbEhUuSMjqxUKbQ7BmzCJXZKyTceYcB5 v2V6daZ4HYxyD9d5nqfLnDHrkjTuVJot8Q8SR6nqlmR3Uq9pczeWWphXLYSrcoYe8SHO 9i81Jh8ngblHRaPORTLxMdOkG3q/UBXmVuyBnzLhg71EoVXiUWgoVX/BqCi4U6pw8UV5 EIMqpmwp1ldOdWUB+incEDlKCT6YkVEdY8R+eYlmmpUoCHBHon8k1Z+3bw1gXJ4n9rbJ xouxEfkho+0yeNKfdX3LFqyhl6hGglSF+1OsxU2/tgolJQRrbEfqp9LTADnPfbEWTHa8 bNYQ== X-Gm-Message-State: AOJu0YzObctgdlTzTz++42VSa9caFXKUh18POEGGhIPlvxl5fjnar/62 3pWY/lXxG0lFbDfudKWdQ/yoX7jmmLfYqaB3JTquEg== X-Google-Smtp-Source: AGHT+IFZNs5hhmx8diOPnz8yFQ1xSrgnDRloz8y8SF3lsSE/AR9n/2vdlcbR3atu5/jsrF8bnwhzcnln6B16ThH1wlM= X-Received: by 2002:a17:906:3787:b0:a02:9700:bf53 with SMTP id n7-20020a170906378700b00a029700bf53mr7604689ejc.46.1701080421477; Mon, 27 Nov 2023 02:20:21 -0800 (PST) MIME-Version: 1.0 References: <958dc0d6-7b1f-4a03-b7d4-1e13b47a545b@codesourcery.com> In-Reply-To: From: Christophe Lyon Date: Mon, 27 Nov 2023 11:20:20 +0100 Message-ID: Subject: Re: [patch] OpenMP: Add -Wopenmp and use it To: Jakub Jelinek Cc: Tobias Burnus , gcc-patches , fortran Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On Fri, 24 Nov 2023 at 15:08, Jakub Jelinek wrote: > > On Fri, Nov 24, 2023 at 02:51:28PM +0100, Tobias Burnus wrote: > > Following the general trend to add a "[-W...]" to the warning messages > > for both better grouping of the warnings and - more importantly - for providing > > a means to silence such a warning (or to -Werror= them explicitly), this patch > > replaces several '0' by OPT_Wopenmp. > > > > Comments or remarks before I commit it? > > LGTM, thanks for working on it. > > Jakub > I think the lack of final '.' in: gcc/c-family/c.opt + Warn about suspicious OpenMP code has caused the following regressions: Running gcc:gcc.misc-tests/help.exp ... FAIL: compiler driver --help=c option(s): "^ +-.*[^:.]$" absent from output: " -Wopenmp Warn about suspicious OpenMP code" FAIL: compiler driver --help=c++ option(s): "^ +-.*[^:.]$" absent from output: " -Wopenmp Warn about suspicious OpenMP code" FAIL: compiler driver --help=fortran option(s): "^ +-.*[^:.]$" absent from output: " -Wopenmp Warn about suspicious OpenMP code" FAIL: compiler driver --help=warnings option(s): "^ +-.*[^:.]$" absent from output: " -Wopenmp Warn about suspicious OpenMP code" I think you have received a notification from our CI about that? Can you check it's as simple as that? Thanks, Christophe