From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126953 invoked by alias); 4 Feb 2018 13:01:17 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 126927 invoked by uid 89); 4 Feb 2018 13:01:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=sk:associa, transfer X-Spam-User: qpsmtpd, 2 recipients X-HELO: nef2.ens.fr Received: from nef2.ens.fr (HELO nef2.ens.fr) (129.199.96.40) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 04 Feb 2018 13:01:14 +0000 Received: from mailhost.lps.ens.fr (tournesol.lps.ens.fr [129.199.120.1]) by nef2.ens.fr (8.13.6/1.01.28121999) with ESMTP id w14D1AX0008898 ; Sun, 4 Feb 2018 14:01:11 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mailhost.lps.ens.fr (Postfix) with ESMTP id C71A1151; Sun, 4 Feb 2018 14:01:10 +0100 (CET) Received: from mailhost.lps.ens.fr ([127.0.0.1]) by localhost (tournesol.lps.ens.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tQR8uD2WW78e; Sun, 4 Feb 2018 14:01:10 +0100 (CET) Received: from [192.168.1.12] (log78-1-82-242-47-10.fbx.proxad.net [82.242.47.10]) by mailhost.lps.ens.fr (Postfix) with ESMTPSA id 974DC149; Sun, 4 Feb 2018 14:01:10 +0100 (CET) From: =?utf-8?Q?Dominique_d=27Humi=C3=A8res?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Subject: [RFA PATCH] Bug 84094 - several correctness issues in gfortran.dg Message-Id: Date: Sun, 04 Feb 2018 13:01:00 -0000 Cc: gfortran , gcc-patches To: Paul Richard Thomas X-SW-Source: 2018-02/txt/msg00014.txt.bz2 Is the following patch OK? For associate_23.f90 I have restricted should_wo= rk to two elements, an alternative would be to use ASSOCIATE(should_work=3D= >char_var_dim(1:3)); any preference? Note that none of these invalid codes are detected by gfortran, except intr= insic_actual_4.f90 which gives a confusing warning i =3D len ("123") 1 Warning: Type specified for intrinsic function 'len' at (1) is ignored [-Ws= urprising] when compiled with -Wall. Should I open PRs for these missing/confusing diagnostics? TIA Dominique --- ../_clean/gcc/testsuite/gfortran.dg/matmul_3.f90 2009-11-25 18:17:41.00= 0000000 +0100 +++ gcc/testsuite/gfortran.dg/matmul_3.f90 2018-02-04 13:25:39.000000000 +0= 100 @@ -22,7 +22,7 @@ iX2(1:n,1) =3D matmul( iB(2,1:n),iC(1:n,1:n) ) =20 ! Whereas, we should have 8, 8, 99 - if (any (iX1(1:n,1) .ne. (/8, 8, 99/))) call abort () + if (any (iX1(1:n+1,1) .ne. (/8, 8, 99/))) call abort () if (any (iX1 .ne. iX2)) call abort () =20 ! Make sure that the fix does not break transpose temporaries. --- ../_clean/gcc/testsuite/gfortran.dg/associate_23.f90 2016-11-04 20:34:0= 0.000000000 +0100 +++ gcc/testsuite/gfortran.dg/associate_23.f90 2018-02-04 13:28:18.00000000= 0 +0100 @@ -27,7 +27,8 @@ program test_this =20 ! Found to be failing during debugging ASSOCIATE(should_work=3D>char_var_dim(1:2)) - should_work =3D ["test SUCCESFUL", "test_SUCCESFUL", "test.SUCCESFUL"] +! should_work =3D ["test SUCCESFUL", "test_SUCCESFUL", "test.SUCCESFUL"] + should_work =3D ["test SUCCESFUL", "test_SUCCESFUL"] write (buffer, *) should_work(:)(5:14) END ASSOCIATE =20 --- ../_clean/gcc/testsuite/gfortran.dg/transfer_array_intrinsic_2.f90 2009= -11-25 18:17:42.000000000 +0100 +++ gcc/testsuite/gfortran.dg/transfer_array_intrinsic_2.f90 2018-02-04 13:= 40:17.000000000 +0100 @@ -88,7 +88,7 @@ contains ch(1:2) =3D transfer (y, ch, 2) if (any (ch(1:2) .ne. (/"ABCD","EFGH"/))) call abort () =20 - z =3D transfer (ch, y) + z =3D transfer (ch, y, 2) if (any (y(1:2) .ne. z)) call abort () =20 end subroutine test2 --- ../_clean/gcc/testsuite/gfortran.dg/intrinsic_actual_4.f90 2009-11-25 1= 8:17:49.000000000 +0100 +++ gcc/testsuite/gfortran.dg/intrinsic_actual_4.f90 2018-02-04 13:48:05.00= 0000000 +0100 @@ -13,6 +13,7 @@ =20 implicit none integer i + intrinsic len i =3D len ("123") call sub (len, "abcdef") end