From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id E93A73858436; Wed, 8 Dec 2021 15:47:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E93A73858436 Received: by mail-wr1-x429.google.com with SMTP id a9so4801733wrr.8; Wed, 08 Dec 2021 07:47:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=whAb3PuDttisd6TUqg6pTaHRgelXK9oXPBRIoNLNtGw=; b=OXptwN05LPWbiQOChmNQ/R9+35fUDa2mnNyCxEckRBNg2MIn2R8JdkMa5MeiLJ988m ot7srOawYSJ5uTUzorRZgmBmIyshj6AOPrGp8NOizRIXTUzrGYraIG7NA30Wfbupd1TI ZakCR9+vSUGI6rpsMj6Q2QJ/zw+lZnO8jEtkXSs7cfMAVUVBPU2RBCcsFfpwrxKu+Vlr TaSYHeRuSirJ4MzpNIQKZKwADuWZ8TjXq/xJdQSroZ/8b4QoqFaF3DcqEnO6BcAjCiSJ Ypx7LEdkQQ3Enqj7Pq8PRfd73ScVvMdVnvU1XmQEfdJQ0smbU78yD049ODs7nVpspTNH 7arQ== X-Gm-Message-State: AOAM5334D6dwSSzYqJ4S/tHSrv0GW1AsUV5EHr/khz+eIt4yZwGaPsTP T5yDUFBTzniY7ZDGQNent2Y= X-Google-Smtp-Source: ABdhPJxQ/diAdpxzG9iplpaqydVw6OVsJ07q3N49hp7Xj14c5mH/foSCACjwpSaVhFX+rbr7a0wF0A== X-Received: by 2002:adf:fb0c:: with SMTP id c12mr64443283wrr.614.1638978461013; Wed, 08 Dec 2021 07:47:41 -0800 (PST) Received: from smtpclient.apple ([2a01:e34:ec28:8cb0:3d3e:6305:77d5:ce02]) by smtp.gmail.com with ESMTPSA id q4sm2956421wrs.56.2021.12.08.07.47.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Dec 2021 07:47:40 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\)) Subject: Re: [patch, Fortran] IEEE support for aarch64-apple-darwin From: FX In-Reply-To: Date: Wed, 8 Dec 2021 16:47:40 +0100 Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <93D8CCF9-4230-4517-A993-A811092ADC4B@gmail.com> To: Richard Earnshaw X-Mailer: Apple Mail (2.3693.20.0.1.32) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2021 15:47:43 -0000 Hi Richard, > This isn't a full review, but I do have a question: is this really = specific to Darwin? or is it really generic aarch64 code? If the = former, then the file name is not right and it should reflect the = darwin-specific nature of the contents. If the latter, then I wonder = why most other fortran targets don't seem to have specific = implementations of this. The code is not specific to Darwin, but right now I chose to only enable = on Darwin because: - All glibc targets are covered already by using glibc function = calls - I don=E2=80=99t know if there are other aarch64 targets that exist, = support Fortran and IEEE, but don=E2=80=99t have glibc I=E2=80=99d suggest other non-glibc aarch64 targets could be added to = the support and enable this code, but I don=E2=80=99t want to do it = unless it=E2=80=99s been tested there. IEEE support is optional in = Fortran, so I suggest we keep it =E2=80=9Copt-in=E2=80=9D: targets where = it=E2=80=99s known to work enable it, but it=E2=80=99s off by default on = other targets. I hope this explains the rationale. FX=