Re: [PATCH] Make integer output faster in libgfortran

[FX <fxcoudert@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

Follow-up patch committed, after my use of the one-argument variant of static_assert() broke bootstrap on Solaris (sorry Rainer!).
The one-arg form is new since C23, while Solaris <assert.h> only supports the two-arg form (C11).

I have confirmed that other target libraries use the two-arg form, and bootstrapped the attached patch on x86_64-pc-linux-gnu.

FX


[-- Attachment #2: static_assert.diff --]
[-- Type: application/octet-stream, Size: 1030 bytes --]

commit 3430132f3e8289f1b789a1a91206c44c47fb032c
Author: Francois-Xavier Coudert <fxcoudert@gmail.com>
Date:   2021-12-27 21:32:08 +0100

    Fortran: fix use of static_assert() to conform to C11
    
    libgfortran/ChangeLog:
    
            PR libfortran/98076
            * runtime/string.c (gfc_itoa): Use two args for static_assert().

diff --git a/libgfortran/runtime/string.c b/libgfortran/runtime/string.c
index 0ccd731852a..21585f48dc9 100644
--- a/libgfortran/runtime/string.c
+++ b/libgfortran/runtime/string.c
@@ -242,7 +242,8 @@ gfc_itoa (GFC_UINTEGER_LARGEST n, char *buffer, size_t len)
 	 integers (we would need three calls), but they do suffice for all
 	 values up to 2^127, which is the largest that Fortran can produce
 	 (-HUGE(0_16)-1) with its signed integer types.  */
-      static_assert(sizeof(GFC_UINTEGER_LARGEST) <= 2 * sizeof(uint64_t));
+      static_assert(sizeof(GFC_UINTEGER_LARGEST) <= 2 * sizeof(uint64_t),
+		    "integer too large");
 
       GFC_UINTEGER_LARGEST r;
       r = n % TEN19;