From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63595 invoked by alias); 18 Jun 2016 19:47:58 -0000 Mailing-List: contact fortran-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: fortran-owner@gcc.gnu.org Received: (qmail 63576 invoked by uid 89); 18 Jun 2016 19:47:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=rep.dot.nop@gmail.com, repdotnopgmailcom, aldotgccgnuorg, aldot@gcc.gnu.org X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 18 Jun 2016 19:47:47 +0000 Received: by mail-wm0-f68.google.com with SMTP id 187so5183837wmz.1; Sat, 18 Jun 2016 12:47:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:user-agent:in-reply-to:references:mime-version :content-transfer-encoding:subject:from:date:to:cc:message-id; bh=qnz4Db4VFeophW5ARnrx/lcgbWQXASNnxmU88F1xS9w=; b=m5b4wVINee5bdPBf2BkIuN9IaC1Ag7Y3WY47w8YJMdQ5/jtBy4bTBa9tVduqKZGY1X tUyGNTiqN/yeVfeDycocL7VKPXwHLBlsBgb8SKT4Z5MuBfd0YZZej6hjYb/8U7edWKNd nVLYqjUxYI3hMUaVE9nuSb0sVTYvMvESs+o7exHezPUvsoxSVbu6z+SDxZLjsI991imW Idm3Zl4gFxt8iLWIR1KFhBPo/6vpCfe+Gdnyp0tzb5rAyNvBHM5Zbtq+z/imNqlEr96l gRltG3G6HtVHVJ8Q68Bh5Km9I5LqNjGN0W9xAyDQB9mLHcnp2xmAOgcWfxv55Agr+Pts Ky+Q== X-Gm-Message-State: ALyK8tI8I1c0ym/n+f4PHnYAh6K7urY2paRsKLBmFydKUA6FmVlUHDFVgJHYuQ6YnNpJmA== X-Received: by 10.28.93.142 with SMTP id r136mr3973065wmb.70.1466279264139; Sat, 18 Jun 2016 12:47:44 -0700 (PDT) Received: from [10.45.252.35] (089144230035.atnat0039.highway.a1.net. [89.144.230.35]) by smtp.gmail.com with ESMTPSA id e5sm55143217wjj.10.2016.06.18.12.47.43 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 18 Jun 2016 12:47:43 -0700 (PDT) User-Agent: K-9 Mail for Android In-Reply-To: <1448974501-30981-1-git-send-email-rep.dot.nop@gmail.com> References: <1448974501-30981-1-git-send-email-rep.dot.nop@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH] Use gfc_add_*_component defines where appropriate From: Bernhard Reutner-Fischer Date: Sat, 18 Jun 2016 19:47:00 -0000 To: fortran@gcc.gnu.org CC: gcc-patches@gcc.gnu.org Message-ID: X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00049.txt.bz2 Ping. On December 1, 2015 1:54:58 PM GMT+01:00, Bernhard Reutner-Fischer wrote: >A couple of places used gfc_add_component_ref(expr, "string") instead >of >the defines from gfortran.h > >Regstrapped without regressions, ok for trunk stage3 now / next stage1? > >gcc/fortran/ChangeLog > >2015-11-29 Bernhard Reutner-Fischer > > * class.c (gfc_add_class_array_ref): Call gfc_add_data_component() > instead of gfc_add_component_ref(). > (gfc_get_len_component): Call gfc_add_len_component() instead of > gfc_add_component_ref(). > * trans-intrinsic.c (gfc_conv_intrinsic_loc): Call > gfc_add_data_component() instead of gfc_add_component_ref(). > * trans.c (gfc_add_finalizer_call): Call > gfc_add_final_component() and gfc_add_size_component() instead > of gfc_add_component_ref. > >Signed-off-by: Bernhard Reutner-Fischer >--- > gcc/fortran/class.c | 4 ++-- > gcc/fortran/trans-intrinsic.c | 2 +- > gcc/fortran/trans.c | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c >index 8b49ae9..027cb89 100644 >--- a/gcc/fortran/class.c >+++ b/gcc/fortran/class.c >@@ -258,7 +258,7 @@ gfc_add_class_array_ref (gfc_expr *e) > int rank = CLASS_DATA (e)->as->rank; > gfc_array_spec *as = CLASS_DATA (e)->as; > gfc_ref *ref = NULL; >- gfc_add_component_ref (e, "_data"); >+ gfc_add_data_component (e); > e->rank = rank; > for (ref = e->ref; ref; ref = ref->next) > if (!ref->next) >@@ -584,7 +584,7 @@ gfc_get_len_component (gfc_expr *e) > ref = ref->next; > } > /* And replace if with a ref to the _len component. */ >- gfc_add_component_ref (ptr, "_len"); >+ gfc_add_len_component (ptr); > return ptr; > } > >diff --git a/gcc/fortran/trans-intrinsic.c >b/gcc/fortran/trans-intrinsic.c >index 1dabc26..2ef0709 100644 >--- a/gcc/fortran/trans-intrinsic.c >+++ b/gcc/fortran/trans-intrinsic.c >@@ -7112,7 +7112,7 @@ gfc_conv_intrinsic_loc (gfc_se * se, gfc_expr * >expr) > if (arg_expr->rank == 0) > { > if (arg_expr->ts.type == BT_CLASS) >- gfc_add_component_ref (arg_expr, "_data"); >+ gfc_add_data_component (arg_expr); > gfc_conv_expr_reference (se, arg_expr); > } > else >diff --git a/gcc/fortran/trans.c b/gcc/fortran/trans.c >index 2a91c35..14dad0f 100644 >--- a/gcc/fortran/trans.c >+++ b/gcc/fortran/trans.c >@@ -1132,11 +1132,11 @@ gfc_add_finalizer_call (stmtblock_t *block, >gfc_expr *expr2) > > final_expr = gfc_copy_expr (expr); > gfc_add_vptr_component (final_expr); >- gfc_add_component_ref (final_expr, "_final"); >+ gfc_add_final_component (final_expr); > > elem_size = gfc_copy_expr (expr); > gfc_add_vptr_component (elem_size); >- gfc_add_component_ref (elem_size, "_size"); >+ gfc_add_size_component (elem_size); > } > > gcc_assert (final_expr->expr_type == EXPR_VARIABLE);