public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Chung-Lin Tang <cltang@codesourcery.com>,fortran@gcc.gnu.org
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,Thomas Schwinge
	<thomas@codesourcery.com>
Subject: Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE
Date: Tue, 10 May 2016 18:58:00 -0000	[thread overview]
Message-ID: <F1E73865-ED59-4FFB-8EEA-D3CB26281745@gmail.com> (raw)
In-Reply-To: <2b4f59d5-be38-2814-27bb-73aa7ffb4b8f@codesourcery.com>

On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang <cltang@codesourcery.com> wrote:
>Hi, this patch resolves an ICE for Fortran when using the OpenACC
>host_data directive.  Actually, rather than say resolve, it's more like
>adjusting the front-end to same middle-end restrictions as C/C++,
>namely that we only support pointers or arrays for host_data right now.
>
>This patch contains a little bit of adjustments in
>fortran/openmp.c:resolve_omp_clauses(),
>and some testcase adjustments. This has been tested without regressions
>for Fortran.
>
>Is this okay for trunk?
>
>Thanks,
>Chung-Lin
>
>2015-05-09  Chung-Lin Tang  <cltang@codesourcery.com>
>
>	gcc/
>	* fortran/openmp.c (resolve_omp_clauses): Adjust use_device clause
>	handling to only allow pointers and arrays.

Fortran has it's own ChangeLog. The patch itself looks somewhat plausible to me, fwiw, but Jakub or a FE maintainer has the say.

  reply	other threads:[~2016-05-10 18:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAKe2ite0OWGjtQtHkLY-FDxqJLXmDbKAWOiRLqTP+cUS1-qWog@mail.gmail.com>
2016-04-27 17:16 ` OpenACC-Library-Interoperability Vladimír Fuka
2016-04-15 14:36   ` OpenACC-Library-Interoperabilit Salvatore Filippone
2016-05-09 14:27     ` [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE Chung-Lin Tang
2016-05-10 18:58       ` Bernhard Reutner-Fischer [this message]
2016-06-07 12:04         ` Chung-Lin Tang
2016-06-21  6:18           ` [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x2) Chung-Lin Tang
2016-07-13 11:53             ` [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x3) Chung-Lin Tang
2016-07-21  9:29               ` [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x4) Chung-Lin Tang
2016-07-21 10:54                 ` Paul Richard Thomas
2016-07-21 11:13       ` [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE Jakub Jelinek
2016-07-29 15:47         ` Chung-Lin Tang
2016-08-09 15:30           ` Jakub Jelinek
2016-04-12 15:00 OpenACC-Library-Interoperability Vikram Singh
2016-04-15  6:16 ` OpenACC-Library-Interoperability Thomas Schwinge
2016-04-15  8:36   ` OpenACC-Library-Interoperability Vikram Singh
2016-04-15  8:58     ` OpenACC-Library-Interoperability Thomas Schwinge
2016-04-15 11:00       ` OpenACC-Library-Interoperability Vikram Singh
2016-05-12 15:35         ` OpenACC-Library-Interoperability Thomas Schwinge
2016-05-12 16:41           ` OpenACC-Library-Interoperability Vikram Singh
2016-05-12 17:54             ` OpenACC-Library-Interoperability Vikram Singh
     [not found]           ` <CAD0gq3VoRWCiXRkgi-bnGLBfSjR-bFc0Mzp19LRr+yWP4MrYLg@mail.gmail.com>
     [not found]             ` <CANSzZf6md-w8SZOJEeawThYbVfH0cLgNRS9r5VaADqZKdy6KtA@mail.gmail.com>
2016-08-02 16:56               ` OpenACC-Library-Interoperability Salvatore Filippone
2016-08-03 15:53             ` OpenACC-Library-Interoperability Vikram Singh
2016-08-29 13:59               ` OpenACC-Library-Interoperability Vikram Singh
2016-08-29 14:05                 ` OpenACC-Library-Interoperability James Norris
2016-08-29 14:15                   ` OpenACC-Library-Interoperability Vikram Singh
2016-08-29 14:34                 ` OpenACC-Library-Interoperability Cesar Philippidis
2016-08-29 15:39                   ` OpenACC-Library-Interoperability Vikram Singh
2016-08-29 16:16                     ` OpenACC-Library-Interoperability Cesar Philippidis
2016-08-31  9:43                       ` OpenACC-Library-Interoperability Vikram Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F1E73865-ED59-4FFB-8EEA-D3CB26281745@gmail.com \
    --to=rep.dot.nop@gmail.com \
    --cc=cltang@codesourcery.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).