From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id BFA46385C403 for ; Tue, 25 Jan 2022 20:56:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFA46385C403 Received: by mail-wm1-x329.google.com with SMTP id f202-20020a1c1fd3000000b0034dd403f4fbso2760794wmf.1 for ; Tue, 25 Jan 2022 12:56:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=EE7kwjL7LNSwALHS5upONym2umO70S4Y1k/KRGvgCO4=; b=WL7Szcly6GYtNEEh9saGHwQLTMqgFWGUOCziQTFUMwTn4pj5pNHi3ssrt31xtN6B1M 2s+i0xgpDyrQPf5gNYiqhut85KKvHaCKVADGr2QUixFDnj7Cnyfhy1NEav+rHz6WEY86 pieEhdR+0uy736YxkVaUvg3Cf8Tktx2t3Y6ci26FAbPXBy6iiy5RyCjEBGb0Qg6KiRex cxZ8Vis+G39qEb2yHFFp2WLkKTJzDY5znk/hQfkmoQzbmNszi5YSyQu/+Q7d41V0WtRK 4rFaSYq0z3qYoQrtzTqQ2PRQg38MMnTaS7dl0+UkRPWYMUmsEcf9gU0tivlgATQ4dFuP 4Bxg== X-Gm-Message-State: AOAM533Y9l0r1lTslFoAVp7mGoWzty7YC57n9pooy11iW8SagDU/THto 9pR5nZTeuTnkq84Dc9iTmvhe9Da6XuRDog== X-Google-Smtp-Source: ABdhPJwpJ9x0S/5salCgKNW9rv7rSEXicQFMiG/Y0WUL71D8lrwDjuxVaeiOMkV7OSsCriMDA3o4kw== X-Received: by 2002:a05:600c:1e8b:: with SMTP id be11mr4590500wmb.96.1643144166607; Tue, 25 Jan 2022 12:56:06 -0800 (PST) Received: from smtpclient.apple ([2a01:e34:ec28:8cb0:e18b:1110:2e58:8065]) by smtp.gmail.com with ESMTPSA id f8sm1713564wmg.3.2022.01.25.12.56.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jan 2022 12:56:06 -0800 (PST) From: FX Message-Id: Content-Type: multipart/mixed; boundary="Apple-Mail=_32B7F638-4260-435A-A17A-57D07D1B3087" Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) Subject: Re: New signaling NaN causes 12 testsuite failures Date: Tue, 25 Jan 2022 21:56:05 +0100 In-Reply-To: <20220125204544.GE69322@troutmask.apl.washington.edu> Cc: fortran@gcc.gnu.org To: Steve Kargl References: <20220125004453.GA16729@troutmask.apl.washington.edu> <1DA16214-53F0-4B2E-AB56-503AAD59B266@gmail.com> <20220125193526.GA69322@troutmask.apl.washington.edu> <154020AE-C99E-400F-B86C-A8AF4720F16F@gmail.com> <20220125204544.GE69322@troutmask.apl.washington.edu> X-Mailer: Apple Mail (2.3693.40.0.1.81) X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 20:56:12 -0000 --Apple-Mail=_32B7F638-4260-435A-A17A-57D07D1B3087 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Found it. = https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html >=20 > Add trailing undersores to __FLOAT_WORD_ORDER and change > __BIG_ENDIAN to __ORDER_BIG_ENDIAN__. Likewise for LITTLE. Thanks Steve! What I wonder is: if those conditions failed, then the struct they = define should have been empty, and therefore the code shouldn=E2=80=99t = compile anyway (that was the intent). Does the attached patch fix the remaining failures? FX --Apple-Mail=_32B7F638-4260-435A-A17A-57D07D1B3087 Content-Disposition: attachment; filename=fix.txt Content-Type: text/plain; x-unix-mode=0644; name="fix.txt" Content-Transfer-Encoding: quoted-printable commit 03cfe155f46c05e4dda349be2abe467c16789491 Author: Francois-Xavier Coudert Date: 2022-01-25 21:54:03 +0100 Fortran: fix issignaling() implementation =20 libgfortran/ChangeLog: =20 * ieee/issignaling_fallback.h: Fix GCC-specific preprocessor macros. diff --git a/libgfortran/ieee/issignaling_fallback.h = b/libgfortran/ieee/issignaling_fallback.h index 4632bc510f7..fc59481c43b 100644 --- a/libgfortran/ieee/issignaling_fallback.h +++ b/libgfortran/ieee/issignaling_fallback.h @@ -103,12 +103,12 @@ typedef union long double value; struct { -#if __FLOAT_WORD_ORDER =3D=3D __BIG_ENDIAN +#if __FLOAT_WORD_ORDER__ =3D=3D __ORDER_BIG_ENDIAN__ int sign_exponent:16; unsigned int empty:16; uint32_t msw; uint32_t lsw; -#elif __FLOAT_WORD_ORDER =3D=3D __LITTLE_ENDIAN +#elif __FLOAT_WORD_ORDER__ =3D=3D __ORDER_LITTLE_ENDIAN__ uint32_t lsw; uint32_t msw; int sign_exponent:16; @@ -146,10 +146,10 @@ typedef union long double value; struct { -#if __FLOAT_WORD_ORDER =3D=3D __BIG_ENDIAN +#if __FLOAT_WORD_ORDER__ =3D=3D __ORDER_BIG_ENDIAN__ uint64_t msw; uint64_t lsw; -#elif __FLOAT_WORD_ORDER =3D=3D __LITTLE_ENDIAN +#elif __FLOAT_WORD_ORDER__ =3D=3D __ORDER_LITTLE_ENDIAN__ uint64_t lsw; uint64_t msw; #endif @@ -191,10 +191,10 @@ typedef union __float128 value; struct { -#if __FLOAT_WORD_ORDER =3D=3D __BIG_ENDIAN +#if __FLOAT_WORD_ORDER__ =3D=3D __ORDER_BIG_ENDIAN__ uint64_t msw; uint64_t lsw; -#elif __FLOAT_WORD_ORDER =3D=3D __LITTLE_ENDIAN +#elif __FLOAT_WORD_ORDER__ =3D=3D __ORDER_LITTLE_ENDIAN__ uint64_t lsw; uint64_t msw; #endif --Apple-Mail=_32B7F638-4260-435A-A17A-57D07D1B3087--