public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Thompson, Matt (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC]" <matthew.thompson@nasa.gov>
To: Martin Stein <mscfd@gmx.net>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: Re: [EXTERNAL] Aw: Help with long compile time of all-USE module
Date: Mon, 17 May 2021 16:19:51 +0000	[thread overview]
Message-ID: <F9726ED2-D522-466D-BC2D-B9022F0721FF@nasa.gov> (raw)
In-Reply-To: <trinity-b117cb0e-d53c-4676-8859-eba7e02836d5-1621246508030@3c-app-gmx-bs72>

Martin,

Thanks. I'll try to give it a try soon...

...though that might be a while. Our preliminary tests with GCC 11 seem to show some issues with our code (other than slowness). Our devs (including Tom Clune who might be known to some here) are looking to see why GCC 10.3 is happy, but GCC 11 isn't. The changelog didn't seem to exciting but you never know when things like polymorphism, strings, et al are all happening at once!

Matt

--
Matt Thompson, SSAI, Ld Scientific Programmer/Analyst
NASA GSFC,    Global Modeling and Assimilation Office
Code 610.1,  8800 Greenbelt Rd,  Greenbelt,  MD 20771
Phone: 301-614-6712                 Fax: 301-614-6246
http://science.gsfc.nasa.gov/sed/bio/matthew.thompson

From: Martin Stein <mscfd@gmx.net>
Date: Monday, May 17, 2021 at 6:15 AM
To: "Thompson, Matt (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC]" <matthew.thompson@nasa.gov>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: [EXTERNAL] Aw: Help with long compile time of all-USE module

PS: I am currently using (with 11.1) the following simple patch to significantly speeding up my compilation. The patch is not correct, but I could not find any examples, where this makes a difference. Even by looking at the orignal commit introducing the find_symbol call I could not come up with an example where this matters. I would be interested to know whether this is the cause for the long compilation times in your case as well.

gcc/fortran/module.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gcc/fortran/module.c b/gcc/fortran/module.c
index 089453caa03..a29865c7412 100644
--- a/gcc/fortran/module.c
+++ b/gcc/fortran/module.c
@@ -5501,11 +5501,12 @@ read_module (void)
            this symbol, which is not in an ONLY clause, must not be
            added to the namespace(11.3.2).  Note that find_symbol
            only returns the first occurrence that it finds.  */
-         if (!only_flag && !info->u.rsym.renamed
+/*       if (!only_flag && !info->u.rsym.renamed
               && strcmp (name, module_name) != 0
               && find_symbol (gfc_current_ns->sym_root, name,
                               module_name, 0))
           continue;
+*/

         st = gfc_find_symtree (gfc_current_ns->sym_root, p);


Best regards
Martin


      parent reply	other threads:[~2021-05-17 16:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 13:52 Thompson, Matt (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC]
2021-05-12 14:39 ` Aw: " Martin Stein
     [not found] ` <trinity-b117cb0e-d53c-4676-8859-eba7e02836d5-1621246508030@3c-app-gmx-bs72>
2021-05-17 16:19   ` Thompson, Matt (GSFC-610.1)[SCIENCE SYSTEMS AND APPLICATIONS INC] [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F9726ED2-D522-466D-BC2D-B9022F0721FF@nasa.gov \
    --to=matthew.thompson@nasa.gov \
    --cc=fortran@gcc.gnu.org \
    --cc=mscfd@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).