From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtphub2.cc.ic.ac.uk (smtphub2.cc.ic.ac.uk [IPv6:2a0c:5bc0:88:101::47]) by sourceware.org (Postfix) with ESMTPS id A11663858D38; Fri, 12 Apr 2024 10:41:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A11663858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=imperial.ac.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=imperial.ac.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A11663858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a0c:5bc0:88:101::47 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712918497; cv=pass; b=o4NjKBF10RhP8hopFvqrEbsT7aBSHaystAQjJRcl3SyijyFf+NmKfaoaLsONB4E9OmFPuRJA1pKfKGT0EgP662YztjR5FI1Xc68Ag5HHqoa4WUiNT7VUyj5j5tMyld4yfh728BLuw3gWhB1OeUXG20/xDY2T3FGnPVCSNHjVP4I= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712918497; c=relaxed/simple; bh=9S0leNCPkZj+xjLuFYE8dovGMEItHcDS84d7CRFrHyI=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=ufN80pchjD408/HvO4KLAKhnH5TXwtmk55NKJ8PqkYi/86sow9hekYlatc1aK1IvBKIBizVYlNkdVCZDlqoiMObusJ4wCHNra3muuZqWgIAv3Xl6jq1+r1yCh1lpqAUu9AGONcnY/pTlwtJiOO2bgZyiK+7st9JvWLOJYpCBOmc= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=imperial.ac.uk; s=main01; h=MIME-Version:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9S0leNCPkZj+xjLuFYE8dovGMEItHcDS84d7CRFrHyI=; b=T7QfrENUBU+bAaeQmh1hkwTkK6 1UrxJAyXY4zaztGxEBFSEipNBmJ3tDttfDC9jFn/5jcPI1YPkh803oFH3uCzdLvcLz8u36RUeRhJC 9TprtX52aPGMs0n7ggBhFb0AyPZVyPNnDviqniuLgCmgro5icR72UDu9Lg09evLjDEsQ=; Received: from mail-cwxgbr01lp2041.outbound.protection.outlook.com ([104.47.85.41] helo=GBR01-CWX-obe.outbound.protection.outlook.com) by smtphub2.cc.ic.ac.uk with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rvELe-0003D6-Dq; Fri, 12 Apr 2024 11:41:34 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ad9eET2iEi91FzieoI/xkZdOACTqBV8ZVwd4uA2GKvnvAIZxhBItu9jBAs9NbwWpBjwQHjSjzDiFt4giplaLygMmB0tgiVbibKHm3kS8IVaANm3lgHE+UoUIXtBsWdluR61DUaYe96tqBp18LgBbXiPNFDxIWYfHD2r7Zk05fGY4rUuyA3hsGBmHtc5t4PTSfG+3LI80gjkigv7bc+30vqHlE6BQWlJl51cyRXxVAg3NuO8f8DZ5lIUVPzd/DZI70Hb7sVCKwnQ2tcCVHLK/SOVYiHKuRL6sijvZSruNF2UBl3WiiDo24loYa/I7A4UGcAXGif4x0JeviSjfKBU5PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9S0leNCPkZj+xjLuFYE8dovGMEItHcDS84d7CRFrHyI=; b=eHBkCeZMU3XW6INkETKKKc69Ya046ug07R0WSWMSApR5WnQCtpki2i7mCsckk/us5Vx0TEnzJXjO3zKxV9g3dqaNCO1sV6i4n4sDh4uGoxv9veuIjdQMpCayDmMj8GL9YBOWF3KygFP2MaRLI7fHbaBe6CX/6byY0QhIjEPNA3oLE6TH9Uq40V6pF3ra38+rK2C5UQONjTvfqh4zo3gy7FO/pmuTtoGm3REFLMKi8MgqEEZLNP3cTnRgbPqfH+ThG32jg9WqSGsVVfX+1lwcjFy+ZapEHKI6VIP779yqQd5qN7lpXN2tktDqTHWUNIlafeUVqAoFqfrnyRpoqZJJHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=imperial.ac.uk; dmarc=pass action=none header.from=imperial.ac.uk; dkim=pass header.d=imperial.ac.uk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ImperialLondon.onmicrosoft.com; s=selector2-ImperialLondon-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9S0leNCPkZj+xjLuFYE8dovGMEItHcDS84d7CRFrHyI=; b=ooc/6GNGRh5Xy6IHjHaMTfo9/nzsIeN37a5GGdZ9xTw+xuGiTy5m31NeDgCPVwIyxRoselfgD7UAYKk1BmJEgDiuWHO15WVyviwyJGgUB/4L9OjHMMUih/wv7F+pSgbX+EPo9OBr6AGgtXCZBYqtwBAnWdejzSRuG2ZvmIp5s44= Received: from LO2P265MB4117.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:1ea::12) by LO4P265MB6479.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2d4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.56; Fri, 12 Apr 2024 10:41:33 +0000 Received: from LO2P265MB4117.GBRP265.PROD.OUTLOOK.COM ([fe80::be6f:a150:b84:d826]) by LO2P265MB4117.GBRP265.PROD.OUTLOOK.COM ([fe80::be6f:a150:b84:d826%4]) with mapi id 15.20.7409.053; Fri, 12 Apr 2024 10:41:33 +0000 From: "McInerney, Ian S" To: "fortran@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH 0/1] libgfortran: Fix compilation of gf_vsnprintf Thread-Topic: [PATCH 0/1] libgfortran: Fix compilation of gf_vsnprintf Thread-Index: AQHahqMgMn3YWs5JokOtJhZ/MPFvVrFkfiLX Date: Fri, 12 Apr 2024 10:41:33 +0000 Message-ID: References: <20240404151632.3026631-1-i.mcinerney17@imperial.ac.uk> In-Reply-To: <20240404151632.3026631-1-i.mcinerney17@imperial.ac.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=imperial.ac.uk; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LO2P265MB4117:EE_|LO4P265MB6479:EE_ x-ms-office365-filtering-correlation-id: 5f0839c9-fc44-4f4c-a450-08dc5add1ee6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VTaAMwZIf6aV8p3vn9y6Al/aviDy9PsGd/WvujoeGc+nOtR1eruIgoZkSsZOlt7e4k1+VhTl+m/s9nMfW5BnM8i2dfFqilWTQq1nNLuHw9kUVvnEQjq5XlCeYq/CzxuyOhlPBYdFiFiip0ZAxrvOtzVEwo8i1VWZKKJS98zNdJkbYZHrDgL0q7wrP98p5YEbBFv0vejtLuBX9goiblxSndcXrS2I8d51awC/9WOZDYKhfQtfVyNm2bkTI3JDj/JoWv1/Su16cbPLqpHyl9G4j2XKFTXn2OXBaIRfXJMJcjKSjKsQiiy8fa43h088mZzpp4lOdZTGVDMi7dMLe9ZKDNMp2xxpkwc1xT64V0tT9xzbyl2oUzgtQrhN18qv0UtYdCiqMsaZTNdFM9wL0v+r9B6bpkro3b7bJzwiaqg2bW1OQa5BFKOvuy5ENYvgXvTPsQkJFSIe0h0STmP6UYtDQ7cBnagT38jgTAEtXszpz39TZuHp9xak1euSz7Q5CBG50BuohuTK5CgOfi/JvWQs/61nM5Ob8DmlKID0/Tovna5+CDAw0tEVOL+v2yCzHnwu35weiV0S7T5W3ABkSWhji5QYRRy3Zbc0tmv1bvzFMASG53g18zs1/3MVOlI+jm+E4Th9DjQM67X0CAH5wGpAtPkRyUfh96AWotp3iUmkyxd5a+w4KpQKQnJlwRS1A9L1CMztS8KHAkOEwWXxPcNyKh/Oel56mUgv0sAfk9H9T+E= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LO2P265MB4117.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ToWcge0qBHtJ+YG8g9PUaLui+l9BGlax23k8TgL+ElqFA9dMPub2g7/JY0?= =?iso-8859-1?Q?t4yM87dx/glfIY4CdGI93uCIuMlG4gjJQTVqmw0RByh8Fa8q8JMt+FdVcd?= =?iso-8859-1?Q?sdV8EoSmUmWkHZYur01Guxd10zGzD/vjOJ90vOy0/Jy225du5WJ+OmrJXH?= =?iso-8859-1?Q?DkVLAlE+K+tIwgYbQqO+88Wh9ZVbfwHpFJbbdc5tIsY17C5tdYn6wJ3m/h?= =?iso-8859-1?Q?m4K07DR3ukpprZ3QUp6S3boz7hqZTZ1myACqc8jDu8csGdSXMtuwsHfuvF?= =?iso-8859-1?Q?klZps6DiLnzkTn6HwbprPxMxeVwv5a/jVKxzYDyh5cGuCvIXPNDVJ+LTKf?= =?iso-8859-1?Q?gtwINs0zswwn96erTtekdS58xouc5bC+35KCf84GSgV9ozp1RYnwSwREXP?= =?iso-8859-1?Q?xKREtYkODUp3EKYSKzqsTTPKQ25mODJrfg4MabZ4ze8aN3V3OT2V3C2vH3?= =?iso-8859-1?Q?DPiyY+Xq0KrsIl/dYP4WRWAbrv0AIMiYWV0BXLu69ChNvsVabbqf+W92X2?= =?iso-8859-1?Q?IEi40C5TG0Zp0XIa++53fd2zBAA3YIz7OS/d8oFXXTDBYIcRfo/GxMpvD7?= =?iso-8859-1?Q?RoDrb61SKqujWei2FcZMMq+LxTyOLOyxOhVDc18XfNnCfrMk0ys1jBYGYA?= =?iso-8859-1?Q?z6ntFt9IojrydRBp5L6jYy5fadWcjUUhpDhky8q3SKiEgTYCHqU2KH4YP6?= =?iso-8859-1?Q?abhEGIAxg0RyTKwG4gC0LPLSzOnJ2bn8FwgxFFJ5YIsxT2HJOAYyYD3jJx?= =?iso-8859-1?Q?7XZv7YX+KNfusBSRX0UGZAyJQPzMF+T62HXz1Xwodb7Hc7/cFaaORfM1fX?= =?iso-8859-1?Q?6RGRP9UDMNiBXGRLgeahldxQfRIl2W7NRQACBazIt5PD/osajaBZPQvUDr?= =?iso-8859-1?Q?+6hiIlz0BkrjmYJBi6t7yo5vnWABV4XOQk+oMxTvlAuBBhV6m0iXqPlRZR?= =?iso-8859-1?Q?0d3cSrbixlTrdTvxKFAMmq8x4lJjPhlcaNucCrTt+CV3eropYi4dKxOB/m?= =?iso-8859-1?Q?G+h/0M4aCUU4S5vNYhh6dhzHFlmzlZHjeg58M15c/IidWuXHbHO3xhah/U?= =?iso-8859-1?Q?d4HnJx9khW1SrzJeDjdWnGZofySQ6ES5U3ASvITIF6JC1XcbCwJVY22JVJ?= =?iso-8859-1?Q?2s4YfMdGgQPFKHfmloKNI/j+zUEP77jiNavOIVbkrJ95GiSOkzjRsgFhYm?= =?iso-8859-1?Q?VI+ELjYpCCKb49/cGryKjIGDIkZzuTERHSezLTnjb7a95pe8r1Bp341B9p?= =?iso-8859-1?Q?qDF859CXl/652mhSAprlUFKj4S0RO14Ksj8SM1akiYz9rFQ6MNTLHk2J+M?= =?iso-8859-1?Q?0NVmpEK+m9SnGwzKrQjmXzKCMZ65NiTr+2bVfScmU+PJbqq1BJZ8pWEJQq?= =?iso-8859-1?Q?gb5pTpuy5GkccKP+K6xTNMY8sQ+cV655nTDVrCb9A0EOCjUIodLCVVK/c9?= =?iso-8859-1?Q?BysjmOh9IFyJvsc+dKc7s7U86uJ46Y0iZLT803OPHd4GfKN28BepB2NVrn?= =?iso-8859-1?Q?URC6J/oFzsdVr7amxOF6MR1OuzCxbWes20DzelwWY+nFhxeV9RAt62tjsw?= =?iso-8859-1?Q?GaOu4iHzJWJ4Ej9EKcwi5/bypzWaRDmZdeKFAPQLw96q+6Mc/mJkkaZHGf?= =?iso-8859-1?Q?unP1LxVZ4KeiQ=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: imperial.ac.uk X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB4117.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 5f0839c9-fc44-4f4c-a450-08dc5add1ee6 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2024 10:41:33.2092 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 2b897507-ee8c-4575-830b-4f8267c3d307 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KSCGs1IwpjBygZ2ATDJlW/LD5alvZZCu6Ep41iDvgD+iC3PXQPaR2MDJrd5oIXxA X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB6479 X-IC-MsgID: 1rvELe-0003D6-Dq X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Gentle ping. If this looks good, can someone commit to main (I don't have c= ommit privileges). This is also something that could be considered for stab= le, since it's been around for many years.=0A= =0A= -Ian=0A= =0A= =0A= =0A= =0A= From:=A0McInerney, Ian S =0A= Sent:=A0Thursday, April 4, 2024 4:16 PM=0A= To:=A0fortran@gcc.gnu.org ; gcc-patches@gcc.gnu.org =0A= Cc:=A0McInerney, Ian S =0A= Subject:=A0[PATCH 0/1] libgfortran: Fix compilation of gf_vsnprintf=0A= =A0=0A= The fallback function (gf_vsnprintf) to provide a vsnprintf function=0A= if the system library doesn't have one would not compile due to the=0A= variable name for the string's destination buffer not being updated=0A= after the refactor in 2018 in edaaef601d0d6d263fba87b42d6d04c99dd23dba.=0A= =0A= This updates the internal logic of gf_vsnprintf to now use the str=0A= variable defined in the function signature.=0A= =0A= I am not actually sure what configurations are using this fallback, since= =0A= it was added in 2018 and no patches have been made to fix this compilation= =0A= error. Testing this also isn't straightforward, and I had to do a bit of a= =0A= hack to get it to use the codepath to show the compilation error:=0A= =A01) Configure and build as normal to generate the config.h header=0A= =A02) Modify config.h directly to undefine HAVE_VSNPRINTF=0A= =A03) Directly call the libgfortran compilation step=0A= =0A= Ian McInerney (1):=0A= =A0 libgfortran: Fix compilation of gf_vsnprintf=0A= =0A= =A0libgfortran/runtime/error.c | 8 ++++----=0A= =A01 file changed, 4 insertions(+), 4 deletions(-)=0A= =0A= =0A= base-commit: b7bd2ec73d66f7487bc8842b24daecaa802a72e6=0A= --=0A= 2.43.0=0A= =0A=