From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id BDB723858D39; Thu, 23 Nov 2023 09:36:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDB723858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BDB723858D39 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=192.55.52.120 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700732170; cv=pass; b=lEavtUBei/eUvSn/WSLfNI9gD+xUfTGUIDBGI976weL17H9bbazYFCmxRyPfc+sIuO5xe2r6R+F0qxAskUFGBXCXbwXjWlSlfVgHnuLkAq1BHajT+nKbeuAzK+35GgupPRkgxY3iV7VaUy8kFFodwWjXnTs2HfEKECtKqiB3Xt4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700732170; c=relaxed/simple; bh=zAAWasDu10qUnuxPStnAuKeuTJIh0u8zQid63MJJS9k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GwFKBnjd+YhZx81GS2kp/BrkmwwHH1v1DrX6zwriSIuH7+rVm5wFAYLLoNWxQpzrETsyesXrxoM+uUU8dBwnQuOV9ciY6jbg7x/14bKUUF0l5Yq/3DcFrd6+yp2se3leuf+OzJMsUwRW61mT0shLlPXPTyYBycRpUELURLiZPbo= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700732168; x=1732268168; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zAAWasDu10qUnuxPStnAuKeuTJIh0u8zQid63MJJS9k=; b=ZWKMCziVaWULMhbkL1U2SP4bcN7S7v/aJFHIAK7DRROLEbxylysGVgLr incgic2fwICs/QN8boVG9StzbYiq7nghqQw5zZr5zA8goEvxzJKR4AZdy CEWgUjf7XXukGSXbbxemQBfedfr0NSeLKgdKABJaOMVOgOqCstSQCeOSY 3Yx9mSg3m6ZEI82Ztyno7cTy/PRluCIYCBmRMxXDcxFKN8XfFszeSE8Gl VGmh3HM5M0eWCEKfLvGBPPgmgBLNfiyRgyVA4Ww8oZedwX31d9CX8Y0ee enjRdQ/OU61n0Y7vFUvIe5kAbTd8C7P+ICkHSx9kFBr++OvE4tIa+wiT7 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="391112113" X-IronPort-AV: E=Sophos;i="6.04,221,1695711600"; d="scan'208";a="391112113" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 01:36:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="767152250" X-IronPort-AV: E=Sophos;i="6.04,221,1695711600"; d="scan'208";a="767152250" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Nov 2023 01:36:07 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 23 Nov 2023 01:36:06 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Thu, 23 Nov 2023 01:36:06 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Thu, 23 Nov 2023 01:36:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CwkE/wWvlamkZzq91oGPcS5EN9Ew9mmiQN9q51sQ0liTYEmR/ENPWRvj8Bxs2AkF0q2Z9LSb6lt7+DquqyHpDtZ0ncTAIZmI834FOywIiOht54e8LZZGOFNOANM18HwAnAEbLjPhuVscKlxO966XxTolMetQZL2/n6yn27yEZM1eZvEJ91egUZOGJ4Hh/FWz95/26AB2KdMr71eS+zwKuDxpkcW1p4zbeOOtoa27U9Dk429+yU6eMnh2FS7bdwcbbkkSIPhA2psJq0pHq+EfylpmpSEDaHQocLpMMjy0ok2SkAL1iIJwPXwqWImUlzk6ot/lrrMK3Vh+ebWgUjwsxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iPWm+mtzLThnFWQK5T/I8r9G1AHjnVw7Z7fgwWPXeWQ=; b=QmbwEjFMO5rmVZFQLncqE+/xQDjQlr8zUX6+kXwiBJY41+OSe2qscRJwa1uIo4hfjyKt5zdUwYLLloR0tgEakoEZs0atQbl6gtaEVDZvQsR7mfGasKe5dFrLHbuLpF6uqN2exE3tjNI7wJSLls58Kn1mRXwpoHA73uNJ9sZEBWtY8V2BhgXQnOSFT1rogWrt+DiYuKVvQExBfnIMb5kEzCfLBWirtbBpSTOwQnwN65XnfdWe7tNhrrremBuOcJr51eOtE9XQGrHtEynGqiQBjKjFXtbJSJEbDXPBYd3Hs0bdZ2HfxRk4rwS4ZXK3hZ4/Lo6Il0w5lpN5HtAHyTLXSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6056.namprd11.prod.outlook.com (2603:10b6:510:1d4::20) by SA2PR11MB4923.namprd11.prod.outlook.com (2603:10b6:806:fa::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.20; Thu, 23 Nov 2023 09:36:04 +0000 Received: from PH7PR11MB6056.namprd11.prod.outlook.com ([fe80::a74b:825d:7dc3:67]) by PH7PR11MB6056.namprd11.prod.outlook.com ([fe80::a74b:825d:7dc3:67%3]) with mapi id 15.20.7025.017; Thu, 23 Nov 2023 09:36:03 +0000 From: "Zhu, Lipeng" To: "ian@airs.com" , Jakub Jelinek , "Bernhard Reutner-Fischer" CC: Thomas Koenig , "fortran@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" , "Lu, Hongjiu" , "Li, Tianyou" , "Deng, Pan" , "Guo, Wangyang" Subject: RE: [PATCH v4] libgfortran: Replace mutex with rwlock Thread-Topic: [PATCH v4] libgfortran: Replace mutex with rwlock Thread-Index: AQHZjnSfaJBwUZwj3E+ssbm/v3Oko6/v5JkQgCrGN9CAPNP9MIAATqAAgAA2rOCADjZf4IABjvaAgCD3iVA= Date: Thu, 23 Nov 2023 09:36:03 +0000 Message-ID: References: <81c359ae-ab69-7f03-f113-4b865441de44@intel.com> <9e30db8a-2a6f-89d0-84fb-2f549f61954c@intel.com> <93b9e2d5-4355-136a-a961-da1ae9c1468f@netcologne.de> <20231102105847.2b48a607@nbbrfq.loc> In-Reply-To: <20231102105847.2b48a607@nbbrfq.loc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6056:EE_|SA2PR11MB4923:EE_ x-ms-office365-filtering-correlation-id: ec918f35-2658-42b9-adb6-08dbec079c5c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UH2K5StyCXehRHkf3Y4j5rH67pteHMCyXZ3yIFeyDWdXIirHdXaiX03YjAJD7nql2s69dAE8I7JQXpOlcn9DpX8DwyOc1NldnUEBUgQaq/Mn8zCZKohRXt5jY3JZDX6LPeOluwzbfqyMCdKMGG3bDF/IkootvKssfLbZVV7b/or7gYAQ674TcAoaK+CQO10q2acnU/CTQlBj6sggzqWRqoDNjWbCU7H5R3jpoidWCb7VGCOzOLufw3YFsgV7ZzAcl782P67ssSfPW6wo/uq1ik/CRC7pIg28hSM7AYwo1UEowKsaUVECayJ0RJEVueERJmYNxYTW/t3IcoCeyJRZniokYEPkvHm4xesde7K2s6+5XJq9yQD8PnzPFx4rvfmnIMZ82ao7XU8kzvT4oMFaqcIoDlZDuiAccjX4UbLo+sdTwZXSVe6FeQCVEJ5xpBVJDVBRXTw7Re3EcRTHWYxfivyRZpR3opr4XrCQS+fizmL5DkjG5vsGxreISf059EPzSgnZjrZs6gjQQqD1yZ77ytbSSDbaqYF/VKkXnyOhPG4A8HrjKej2c/BI/YqKI9EtHLPAKgvn9cB7aedPl3xvnknYZ7Lf62QzxeKcJd3+Soo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6056.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(396003)(376002)(136003)(366004)(39860400002)(84040400005)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(110136005)(316002)(54906003)(66556008)(66446008)(66476007)(76116006)(64756008)(66946007)(9686003)(7696005)(6506007)(71200400001)(26005)(107886003)(478600001)(38070700009)(38100700002)(82960400001)(122000001)(33656002)(83380400001)(86362001)(966005)(52536014)(2906002)(55016003)(5660300002)(8676002)(8936002)(41300700001)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6MsuCmKKWe23uBSwaRQRMgx0i7L3HWd7/YdTueo/+j4fNn+mFgx/Ouul/tUU?= =?us-ascii?Q?lFALErJlZU6PK63/EkoMFWH+FPE5KUtkgDfRf+KVgiRAIXHXyKnQ7bm43FFa?= =?us-ascii?Q?Ved3caZPZd6ai9ay0OlXU83mDpl07DrnCvN23+78DV2bvSJeCzRoUD1SQ+1V?= =?us-ascii?Q?qL++tYxTdKJN7yxUVEvHXNldbyjtaeOxFwDlbuUuYjz8dcTckpHpDi8q491S?= =?us-ascii?Q?Zwvk+FecBxr5nVszMiqVEV4JAo/DLfx+lpvnoWoDbBjr5/MVZtQUuiZEIq95?= =?us-ascii?Q?41qjtfo1M2TA+JuZgyBiNOykA0lsgE15QMRTblIlK8IA0s9AJMMFq+ZgMz4g?= =?us-ascii?Q?Qd+7J1a7R86zT4c/h36yrs2SJt7n3r2kQ0wvQ5K5uYs+0/SemCf3hkxSEPgX?= =?us-ascii?Q?om1vLMlSo/AZ9dU9vyL2Mj6UPcKYlwpeM06hp38EQIRWBloKz8FFG5IyW+Nx?= =?us-ascii?Q?o7Vf5PHpnvQ+D3FbiEhz9zM84Xw4/PZcu+3mbzH5EONPEDl6KypBeCbMFYxS?= =?us-ascii?Q?iA3Ovp/Th9CA/rxeLzHJHNnZ0M0GMcs7u/9vhJ1+OiOeusKczJ7omV8ovOUZ?= =?us-ascii?Q?CuitvmvaZONPlubLtckY6Jp8wEv+Mub1KLJYo+Z13rOKXL3y80pCWtF1VTNA?= =?us-ascii?Q?sWOn/7kGGGiu6tx7hRRunL+2N7D40AT2n9ah5BgTKkbMJo26GEV9QSjXtyoD?= =?us-ascii?Q?y2dhFXe0tsdeH3j/6OdC5BCfuxx/UjUEEOF5rMYTcglVCejfWj1HvRgA+4kz?= =?us-ascii?Q?fUrgnCkHe/Q9aMVpzGUvZ+fqpqIKM7uJTJb+JRFqV/yzzKl8LSuK43KWo65P?= =?us-ascii?Q?CoaAifLDCkK6MqQuPUHOdZT91hh/Hz+TreLT3STn3icp6EOAGUGn8yrRl8RH?= =?us-ascii?Q?xjzHC4TlNNy8QSTbzpylw/MFNTwoHDuh2N3eWdpL1zXCtiAKNFj2VYc6wogp?= =?us-ascii?Q?CeuL+rd8BCxa1hvu35lYwY0MKFrSEo7qFmtgVhfcibWoveJL+JE6DSR0Dc37?= =?us-ascii?Q?W+YHbygTYZMemyRuAWIDMTf1oTJdwYl6Jl+5PMF3i/UEsXpEf7L+hFsNiohV?= =?us-ascii?Q?w3GQIc7ROu4byYkD8eCPqk4xlX6rr+m9QTvzNUXXrfSw0CCZrNNaMRTs/o3d?= =?us-ascii?Q?LtcdKrg53YW5n5BNDxEthyZlUX22b37J3uZZ3Noisc+fOKNqyxPzi9OKFHWs?= =?us-ascii?Q?kp7P18KS94eWHqtG83dixtQoZWOBgzaLaLOo2VVHKdsn9wtmbnN+RVQGhoh2?= =?us-ascii?Q?U4ZqAF/IiJhIAN2pa/lvH7Vrh4qG3uq/SVVXvOmuXOkY0SWNeIC+VYIf7kZh?= =?us-ascii?Q?WmqvlgYCduLU16csSuf1FUi13qjZYAtBPrOzJYzzYVCdcqrEvKNoEkRyIvx/?= =?us-ascii?Q?kIAktP47so19zfvf2ZCdKRj7FfBXa7X2p7X6p9pcmZJZX8WEiWcf2cmugA7f?= =?us-ascii?Q?AhCSoThEwOyCsBiy/euE/hv1zFWooJAuUPq8UD3aWcudCDjj6KPkMzrYZLT8?= =?us-ascii?Q?PEwdlog3PXxQE7AniZ+vbRAdGpmZVNyYd1op85CpdEzOd6Yro71LlSLuB7cq?= =?us-ascii?Q?V+3lZQXa/cev/yFFWTlD7lhP8fmaogVK1cf5gA/X?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ec918f35-2658-42b9-adb6-08dbec079c5c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 09:36:03.4913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uRSyz5YeSNXVxSmTJnDLyD2DPHPRalNS+8ZL+Ji+DvL8DpfMW7rAj8LNnQIWVdcLUb+6pw95oGY2VIK5ZvsOGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4923 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > [CCing Ian as libgcc maintainer] >=20 > On Wed, 1 Nov 2023 10:14:37 +0000 > "Zhu, Lipeng" wrote: >=20 > > > > > > > > Hi Lipeng, > > > > > > > > >>> Sure, as your comments, in the patch V6, I added 3 test cases > > > > >>> with OpenMP to test different cases in concurrency respectively= : > > > > >>> 1. find and create unit very frequently to stress read lock and= write > lock. > > > > >>> 2. only access the unit which exist in cache to stress read loc= k. > > > > >>> 3. access the same unit in concurrency. > > > > >>> For the third test case, it also help to find a bug: When > > > > >>> unit can't be found in cache nor unit list in read phase, then > > > > >>> threads will try to acquire write lock to insert the same > > > > >>> unit, this will cause duplicate key > > > > >> error. > > > > >>> To fix this bug, I get the unit from unit list once again > > > > >>> before insert in write > > > > >> lock. > > > > >>> More details you can refer the patch v6. > > > > >>> > > > > >> > > > > >> Could you help to review this update? I really appreciate your > assistance. > > > > >> > > > > > > > > > Could you help to review this update? Any concern will be > appreciated. > > > > > > > > Fortran parts are OK (I think I wrote that already), we need > > > > somebody for the non-Fortran parts. > > > > > > > Hi Thomas, > > > > > > Thanks for your response. Very appreciate for your patience and help. > > > > > > > Jakub, could you maybe take a look? > > > > > > > > Best regards > > > > > > > > Thomas > > > > > > Hi Jakub, > > > > > > Can you help to take a look at the change for libgcc part that added > > > several rwlock macros in libgcc/gthr-posix.h? > > > > > > > Hi Jakub, > > > > Could you help to review this, any comment will be greatly appreciated. >=20 > Latest version is at > https://inbox.sourceware.org/gcc-patches/20230818031818.2161842-1- > lipeng.zhu@intel.com/ >=20 Thanks Bernhard. Hi Ian,=20 Could you help to review the changes for libgcc part? =20 Very looking forward to your help. > > > > > Best Regards, > > > Lipeng Zhu > >