From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 11A923858408 for ; Mon, 20 Feb 2023 11:57:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 11A923858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676894227; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yZDAToFIntCrAO5ahChTcM4H6dgvrESQeh7KpxG0eQw=; b=Dpi7QQAZxeIq5wu+Ry5STj0ECXeJauH4Df4CIdSgkEP73aLrHnXtkCP2b1zWJmuYRrxtWE PiolXv8zqYuHTZ/OJmPqzSXP/PcFJ3eo09dAr/gHiN/bbhOSAq31Xt9RMsrcWOi99zfsip cTUKhnh0bNdT00Dt9m5iJfAg4O9sjew= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-480-jKbAnKRHNTStp6wvWgbVNA-1; Mon, 20 Feb 2023 06:57:04 -0500 X-MC-Unique: jKbAnKRHNTStp6wvWgbVNA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B57E3823D63; Mon, 20 Feb 2023 11:56:59 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.62]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 69082140EBF6; Mon, 20 Feb 2023 11:56:59 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 31KBuuAw1786323 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 20 Feb 2023 12:56:57 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 31KBut8d1786322; Mon, 20 Feb 2023 12:56:55 +0100 Date: Mon, 20 Feb 2023 12:56:55 +0100 From: Jakub Jelinek To: Tobias Burnus Cc: Richard Biener , sgk@troutmask.apl.washington.edu, gcc-patches , fortran , Paul Richard Thomas Subject: Re: [Patch] Fortran: Avoid SAVE_EXPR for deferred-len char types Message-ID: Reply-To: Jakub Jelinek References: <27cd606a-f019-60b2-a9c8-0a570433b5eb@codesourcery.com> <34e0f9e6-ebb8-ce86-ea11-08b37e5be1f8@codesourcery.com> <8d3fae03-2638-9c6b-eccc-d0a31d1b9733@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <8d3fae03-2638-9c6b-eccc-d0a31d1b9733@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Feb 20, 2023 at 12:48:38PM +0100, Tobias Burnus wrote: > On 20.02.23 12:15, Jakub Jelinek wrote: > > On Mon, Feb 20, 2023 at 12:07:43PM +0100, Tobias Burnus wrote: > > > As mentioned in the TODO for 'deferred', I think we really want > > > to have NULL as upper value for the domain for the type, but that > > > requires literally hundred of changes to the compiler, which > > > I do not want to due during Stage 4, but that are eventually > > > required.* — In any case, this patch fixes some of the issues > > > in the meanwhile. > > Yeah, the actual len can be in some type's lang_specific member. > > Actually, I think it should be bound to the DECL and not to the TYPE, > i.e. lang_decl not type_lang. > > I just see that, the latter already has a 'tree stringlen' (for I/O) > which probably could be reused for this purpose. I'd drop the && TREE_CODE (TYPE_SIZE (type)) == SAVE_EXPR and assert == SAVE_EXPR part, with SAVE_EXPRs one never knows if they are added around the whole expression or say some subexpression has it and then some trivial arithmetics happens on the SAVE_EXPR tree. > > Anyway, for the patch for now, I'd probably instead of stripping > > SAVE_EXPR overwrite the 2 sizes with newly built expressions. > > What I now did. (Unchanged otherwise, except that I now also mention > GFC_DECL_STRING_LEN in the TODO.) > > OK for mainline? If Richard doesn't object. Jakub