From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by sourceware.org (Postfix) with ESMTPS id A072B3858427 for ; Tue, 1 Nov 2022 16:22:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A072B3858427 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=kitware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kitware.com Received: by mail-qk1-x72a.google.com with SMTP id v8so3414325qkg.12 for ; Tue, 01 Nov 2022 09:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kitware.com; s=google; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=a2mLpn4mNqsW4PoWCq/7aFooXkS3FjZRMmKuiEkMuTo=; b=Gw/ak8lm1gAsN+so/OXahEfe4CCXJVdguUlo65aTFF9zQEbneYJv5PsEivzhd6SwzZ Rd4w/fOBDL8IM8aNtSvYkwHBPt0yEXUQuCUop5LwImEPyLaMObkXdvWkMqiBqnshm0Wr 4NOHwLmO+vS0oPEJJ735uj1FjJIKU71ptwC8E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a2mLpn4mNqsW4PoWCq/7aFooXkS3FjZRMmKuiEkMuTo=; b=l84USEygRHrbYbUx63Hr+g1l+pUL16zzyG1KaUaF0Ur0e4yue/Q2Phf1gYF2/tS+6v vsm9WIXMQmnLLIoVsiDnK8TGmyjEm3WKDIDIM4/GAtUMuKeSiXPdNVIF0X/DUgwjQ1Cn 7u8eiJpqMJ2dcJyUrVP2K997Fwvp3XdSjUr8ynRnYr93ICWa0JpYcJURXJV1wMYZGIEv beKS4fqWnDiwiwNu4XqoobZ+vF0Ye/YrGtfzFljhlACpO/092gNiOkaK1LHrKvJtbqh8 zmq//Hewb8kUilus9y4o/o2z5WJWY61SMkfvkdmpS/4T8mRwiD4jImbqnW/58tiT45kX Dd6g== X-Gm-Message-State: ACrzQf0ie4KPCP9+rSZZFfslt0+Hq5OIQRn/W0O9M5VqcZn09PLPsCBv 3lkxUAkwrEogwUIj8CKp8oXzAw== X-Google-Smtp-Source: AMsMyM6+nBrxcrY1JTLjSnGAG+5M/bmdcSibccsTwtbzcDlyR2ihsFIaHZSpWHwp95YGKBFxDp0IyQ== X-Received: by 2002:a05:620a:800e:b0:6fa:5270:ad81 with SMTP id ee14-20020a05620a800e00b006fa5270ad81mr1241026qkb.460.1667319763930; Tue, 01 Nov 2022 09:22:43 -0700 (PDT) Received: from localhost (cpe-142-105-146-128.nycap.res.rr.com. [142.105.146.128]) by smtp.gmail.com with ESMTPSA id n17-20020a05620a295100b006ce1bfbd603sm6901053qkp.124.2022.11.01.09.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Nov 2022 09:22:43 -0700 (PDT) Date: Tue, 1 Nov 2022 12:22:42 -0400 From: Ben Boeckel To: Tom Tromey Cc: Ben Boeckel via Gcc-patches , gcc@gcc.gnu.org, brad.king@kitware.com, fortran@gcc.gnu.org, anlauf@gmx.de, nathan@acm.org Subject: Re: [PATCH v2 3/3] p1689r5: initial support Message-ID: References: <20221027231645.67623-1-ben.boeckel@kitware.com> <20221027231645.67623-4-ben.boeckel@kitware.com> <87sfj290ym.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87sfj290ym.fsf@tromey.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Nov 01, 2022 at 08:57:37 -0600, Tom Tromey wrote: > >>>>> "Ben" == Ben Boeckel via Gcc-patches writes: > > Ben> - `-fdeps-file=` specifies the path to the file to write the format to. > > I don't know how this output is intended to be used, but one mistake > made with the other dependency-tracking options was that the output file > isn't created atomically. As a consequence, Makefiles normally have to > work around this to be robust. If that's a possible issue here then it > would be best to handle it in this patch. I don't think there'll be any race here because it's the "output" of the rule as far as the build graph is concerned. It's also JSON, so anything reading it "early" will get a partial object and easily detect "something went wrong". And for clarity, the `-o` flag used in CMake with this is just a side effect of the `-E` mechanism used and is completely ignored in the CMake usage of this. --Ben