From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] OpenMP/Fortran: 'target update' with strides + DT components
Date: Thu, 3 Nov 2022 13:44:01 +0100 [thread overview]
Message-ID: <Y2O3kcf1PyrqXpjM@tucnak> (raw)
In-Reply-To: <51e764f7-635f-9754-dc4b-d2cd2b58435d@codesourcery.com>
On Mon, Oct 31, 2022 at 03:46:25PM +0100, Tobias Burnus wrote:
> OpenMP/Fortran: 'target update' with strides + DT components
>
> OpenMP 5.0 permits to use arrays with strides and derived
> type components for the list items to the 'from'/'to' clauses
> of the 'target update' directive.
>
> gcc/fortran/ChangeLog:
>
> * openmp.cc (gfc_match_omp_clauses): Permit derived types.
> (resolve_omp_clauses):Accept noncontiguous
> arrays.
Formatting. Missing space before Accept and arrays. could fit on the
same line.
> * trans-openmp.cc (gfc_trans_omp_clauses): Fixes for
> derived-type changes; fix size for scalars.
>
> libgomp/ChangeLog:
>
> * testsuite/libgomp.fortran/target-11.f90: New test.
> * testsuite/libgomp.fortran/target-13.f90: New test.
Otherwise LGTM, assuming it actually works correctly.
I don't remember support for non-contiguous copying to/from devices
being actually added, on the library side we certainly have
omp_target_memcpy_rect which under the hood just does multiple copies
of the contiguous subparts, but I don't remember something similar
done in GOMP_target_update. And I think it is not ok to copy bytes
that aren't requested to be copied.
Jakub
next prev parent reply other threads:[~2022-11-03 12:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 14:46 Tobias Burnus
2022-11-03 12:44 ` Jakub Jelinek [this message]
2022-11-03 13:35 ` [Patch] OpenMP/Fortran: 'target update' with DT components (was: [Patch] OpenMP/Fortran: 'target update' with strides + DT components) Tobias Burnus
2022-11-03 13:38 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2O3kcf1PyrqXpjM@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).