From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) by sourceware.org (Postfix) with ESMTPS id 832DF3802BA3; Sun, 11 Dec 2022 23:52:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 832DF3802BA3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=troutmask.apl.washington.edu Authentication-Results: sourceware.org; spf=none smtp.mailfrom=troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.16.1/8.16.1) with ESMTPS id 2BBNqEx4057182 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 11 Dec 2022 15:52:14 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.16.1/8.16.1/Submit) id 2BBNqE10057181; Sun, 11 Dec 2022 15:52:14 -0800 (PST) (envelope-from sgk) Date: Sun, 11 Dec 2022 15:52:14 -0800 From: Steve Kargl To: Harald Anlauf via Fortran Cc: gcc-patches Subject: Re: [PATCH] Fortran: improve checking of assumed size array spec [PR102180] Message-ID: Reply-To: sgk@troutmask.apl.washington.edu References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Dec 11, 2022 at 11:33:43PM +0100, Harald Anlauf via Fortran wrote: > Dear all, > > the attached patch improves checking of array specs in two ways: > - bad assumed size array spec > - a bad first array element spec may already trigger an error, > leading to a more consistent behavior > > Regtested on x86_64-pc-linux-gnu. OK for mainline? > OK with minor nit. > + /* F2018:R821: "assumed-implied-spec is [ lower-bound : ] *". */ > + if (gfc_match (" : * ") == MATCH_YES) > + { > + gfc_error ("A lower bound must precede colon in " > + "assumed size array specification at %C"); "assumed size" should likely be "assumed-size" > + return AS_UNKNOWN; > + } > + -- Steve