From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=sqNr=5U=troutmask.apl.washington.edu=sgk@sourceware.org>
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21])
	by sourceware.org (Postfix) with ESMTPS id 12F3B3858D33;
	Mon, 23 Jan 2023 20:46:39 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 12F3B3858D33
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=troutmask.apl.washington.edu
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=troutmask.apl.washington.edu
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])
	by troutmask.apl.washington.edu (8.16.1/8.16.1) with ESMTPS id 30NKkcWa037617
	(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
	Mon, 23 Jan 2023 12:46:38 -0800 (PST)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
	by troutmask.apl.washington.edu (8.16.1/8.16.1/Submit) id 30NKkcPL037616;
	Mon, 23 Jan 2023 12:46:38 -0800 (PST)
	(envelope-from sgk)
Date: Mon, 23 Jan 2023 12:46:38 -0800
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Harald Anlauf via Fortran <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: avoid ICE on invalid array subscript triplets
 [PR108501]
Message-ID: <Y87yLotE7wxguCFa@troutmask.apl.washington.edu>
Reply-To: sgk@troutmask.apl.washington.edu
References: <trinity-ecf6c22d-c54d-48b8-9e31-bec40bcc5bc7-1674506099182@3c-app-gmx-bap50>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <trinity-ecf6c22d-c54d-48b8-9e31-bec40bcc5bc7-1674506099182@3c-app-gmx-bap50>
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <fortran.gcc.gnu.org>

On Mon, Jan 23, 2023 at 09:34:59PM +0100, Harald Anlauf via Fortran wrote:
> 
> we did not check array element triplets for validity strictly enough
> (i.e. defensively in the case of invalid code), so we could encounter
> non-integer constant expressions that were passed to mpz_get_si.
> 
> The attached obvious patch tries to fix all such potential issues
> in get_expr_storage_size.
> 
> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
> 

Yes.  Thanks for the patch.

-- 
Steve